Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp659802iob; Thu, 12 May 2022 01:42:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZtv+xZnUL3sY3aAZINe5Kln+YTrZ0MhbwkolDrx8h/AoW6fgbmibhcd57hj5ZmXlvL7+x X-Received: by 2002:a63:82c3:0:b0:3c2:85f2:b042 with SMTP id w186-20020a6382c3000000b003c285f2b042mr24088334pgd.419.1652344954394; Thu, 12 May 2022 01:42:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652344954; cv=none; d=google.com; s=arc-20160816; b=t4riOuSxH1ll/oBePevHugVqY3BtFFiHEiOO54ldO3BJ1cCsUVH4QcyzXJj2HW/eCl M3o8EjZ5Q/QaRhbbNKfc5QGOfkMEXFBmzmWfYcNHumqr4nynn0ztWfwzSzo3Ml8Pnzba BDvzGeXsnIo3O7Wx55SLA13wojy4HYQa16Q18Mx6oDIeqQgeV3mlwLfH0v373K1T/v8Y xXlkcKrNSMOCGTye2Brb/kA2jzd3F1dCmLX96wYXD5oNobvjRhQkDEvNkYHZNa+LxQpG BpmQ7wACbUbvXsNFzYWzOUBfPYg6Yr4XASER9167qNYxuyfoXKk4QE6ThTeLPXaNjnSv sOvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=IPRBvvBW0lETz5m8YN39fLl5gQS2Sga9Keu000AT3pU=; b=PwrpujDXZ6cn1ooOU+s2PtrBZ7q2staNIGFLmCDP8DCzLBXh2vFxUXKMUyJgS94lhw rlR2hg+lV7AcIF5KSfRILFPHhcct1WjwHRHhc31zbow0b3IxRn8SiBslB//D45ws3eK8 Jlwgmeb8z53AI04CL5/ZCqHyl7qhUl7uMdB5uL8cdmm3qblUsBERboNTE1nf7NrcWNnB ELjTo5osg0Btdv1fwis0h1fYsPih/IrCG6Oy9tlXoUYn3tdltL0y9gjn6Bfi3ombPN35 q6iDlot+8wm125bVLD1/rSSY0YpB7ZmfS/OndnDxQdspx8199WAag3DZ7oJmMVhJXBlT sDYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=UgsIpw2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a63e64b000000b003c21952c7c7si2734834pgj.37.2022.05.12.01.42.22; Thu, 12 May 2022 01:42:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=UgsIpw2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345754AbiEKRmv (ORCPT + 99 others); Wed, 11 May 2022 13:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345744AbiEKRmq (ORCPT ); Wed, 11 May 2022 13:42:46 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0A27237276 for ; Wed, 11 May 2022 10:42:40 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id j6so5480271ejc.13 for ; Wed, 11 May 2022 10:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IPRBvvBW0lETz5m8YN39fLl5gQS2Sga9Keu000AT3pU=; b=UgsIpw2ht5hPvVl099BLiCTT08ScStzT8c+FWysbU/Oy86z0w/uXgvQmDAbrMrlZGp 32M+oWHwDOkmTg6SHbcv/oXEJ0MJdTVAVh/ePYx9g5bOD6ZGeqIGFzfzNDU5F1MuRwV2 /mtUwL9J1sDC06DI+Q5uj5uScoyb2AKsRly0U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IPRBvvBW0lETz5m8YN39fLl5gQS2Sga9Keu000AT3pU=; b=T0nWj24l2j+/iGzY28erp6tQfdgbow3wDKBi+NNySLnkEktxUZ0nDDitWPZxVAu9bq ncnAKE5R2GUTvm+pDdmkvqfacZQCGEewHQzziTjfqUHICU1h5uYz6fEOZgg+fha9+pHI 7wN6vZEBqcfOtIyqs7D8eb0XnqQVyf8WyafevCe7btcZfErMaf0lEUPn96FFVUz/vlbV RSf6y+Mlt+G8aoURSKdQPX15McnoDGAVdiFCQqzrzLbByTNSgSR2E6EkLxtMfW78PCP2 uTJGY++uOJr50luS/PFUPxcmTvOAQGJKrCY0h3UCMeyoWAwHQrJnM4lrXevU6WRRPnTD gPOA== X-Gm-Message-State: AOAM5306xgW93Q9haS33WOW9GlprmeDC+/musWobVunNKFXK4boCkQlB 9ahLUAGZMsvNDZDzMWw0F45vCEk8yDTsL6xKw+s= X-Received: by 2002:a17:906:7d5:b0:6f3:a6a5:28c6 with SMTP id m21-20020a17090607d500b006f3a6a528c6mr26238977ejc.11.1652290958982; Wed, 11 May 2022 10:42:38 -0700 (PDT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id v3-20020a170906564300b006f3ef214e3esm1204803ejr.164.2022.05.11.10.42.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 10:42:38 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id a5so208543wrp.7 for ; Wed, 11 May 2022 10:42:37 -0700 (PDT) X-Received: by 2002:adf:dfc8:0:b0:20a:d256:5b5c with SMTP id q8-20020adfdfc8000000b0020ad2565b5cmr23591245wrn.97.1652290957387; Wed, 11 May 2022 10:42:37 -0700 (PDT) MIME-Version: 1.0 References: <87a6czifo7.fsf@email.froward.int.ebiederm.org> <87ilrn1drx.ffs@tglx> <877d7zk1cf.ffs@tglx> <87y20fid4d.ffs@tglx> <87bkx5q3pk.fsf_-_@email.froward.int.ebiederm.org> <87mtfu4up3.fsf@email.froward.int.ebiederm.org> <87r150ug1l.fsf_-_@email.froward.int.ebiederm.org> In-Reply-To: <87r150ug1l.fsf_-_@email.froward.int.ebiederm.org> From: Linus Torvalds Date: Wed, 11 May 2022 10:42:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 8/7] sched: Update task_tick_numa to ignore tasks without an mm To: "Eric W. Biederman" Cc: linux-arch , Tejun Heo , Peter Zijlstra , Vincent Guittot , Al Viro , Jens Axboe , Thomas Gleixner , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 10:37 AM Eric W. Biederman wrote: > > With the change to init and the user mode helper processes to not have > PF_KTHREAD set before they call kernel_execve the PF_KTHREAD test in > task_tick_numa became insufficient to detect all tasks that have > "->mm == NULL". Correct that by testing for "->mm == NULL" directly. If you end up rebasing at any time for other reasons (I didn't even check if you keep this series in a public git branch), please just fold this fix into the original commit, so that we don't have unnecessary bisection issues. Linus