Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510091654.8498-1-warp5tw@gmail.com> <20220510091654.8498-2-warp5tw@gmail.com>
 <20220511152422.GA339769-robh@kernel.org>
In-Reply-To: <20220511152422.GA339769-robh@kernel.org>
From:   Tyrone Ting <warp5tw@gmail.com>
Date:   Thu, 12 May 2022 09:31:05 +0800
Message-ID: <CACD3sJbiPYcckyLncXcVR-TFBo_-3XwSDYbmid4qwnoHX-JtUw@mail.gmail.com>
Subject: Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
To:     Rob Herring <robh@kernel.org>
Cc:     sven@svenpeter.dev, JJLIU0@nuvoton.com,
        linux-kernel@vger.kernel.org, olof@lixom.net,
        lukas.bulwahn@gmail.com, jarkko.nikula@linux.intel.com,
        yuenn@google.com, arnd@arndb.de, tali.perry1@gmail.com,
        openbmc@lists.ozlabs.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-i2c@vger.kernel.org,
        tmaimon77@gmail.com, benjaminfair@google.com,
        tomer.maimon@nuvoton.com, kfting@nuvoton.com,
        semen.protsenko@linaro.org, Avi.Fishman@nuvoton.com,
        jsd@semihalf.com, wsa@kernel.org, devicetree@vger.kernel.org,
        andriy.shevchenko@linux.intel.com, KWLIU@nuvoton.com,
        tali.perry@nuvoton.com, avifishman70@gmail.com, venture@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rob:

Thank you for your review. I would like to apply Krzysztof's comment
from the link https://www.spinics.net/lists/linux-i2c/msg56795.html
and remove the
quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"".

If it's okay with you, I'll come up with a new patch with
"Reviewed-by" from you and Krzysztof.

Thank you.

Rob Herring <robh@kernel.org> =E6=96=BC 2022=E5=B9=B45=E6=9C=8811=E6=97=A5 =
=E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=8811:24=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <kfting@nuvoton.com>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> > ---
> >  .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml     | 25 +++++++++++++++----
> >  1 file changed, 20 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Best Regards,
Tyrone