Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220511120532.2228616-1-hca@linux.ibm.com> <20220511120532.2228616-9-hca@linux.ibm.com>
 <CAKwvOd=EQa9tyWUi-ZfKrK-AABDRG7=TErHK+yb+_Z_dkjrmfQ@mail.gmail.com>
In-Reply-To: <CAKwvOd=EQa9tyWUi-ZfKrK-AABDRG7=TErHK+yb+_Z_dkjrmfQ@mail.gmail.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Wed, 11 May 2022 12:56:27 -0700
Message-ID: <CAKwvOd=T5bd69-pduh8OnYdzGuBdJmF692VYP833ZG3BfGUA+A@mail.gmail.com>
Subject: Re: [PATCH 8/8] scripts/min-tool-version.sh: raise minimum clang
 version to 14.0.0 for s390
To:     Heiko Carstens <hca@linux.ibm.com>
Cc:     Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Jonas Paulsson <paulsson@linux.vnet.ibm.com>,
        Ulrich Weigand <ulrich.weigand@de.ibm.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Alexander Egorenkov <egorenar@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Andreas Krebbel <krebbel@linux.ibm.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 11, 2022 at 12:27 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Wed, May 11, 2022 at 5:05 AM Heiko Carstens <hca@linux.ibm.com> wrote:
> >
> > Before version 14.0.0 llvm's integrated assembler fails to handle some
> > displacement variants:
> >
> > arch/s390/purgatory/head.S:108:10: error: invalid operand for instruction
> >  lg %r11,kernel_type-.base_crash(%r13)
> >
> > Instead of working around this and given that this is already fixed
> > raise the minimum clang version from 13.0.0 to 14.0.0.
>
> Do you have the commit in LLVM that fixed this? Might be nice to link

Maybe it's
https://reviews.llvm.org/D113341?

Also, these are the open issues we had for the integrated assembler.
https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+label%3A%22%5BARCH%5D+s390%22+label%3A%22%5BTOOL%5D+integrated-as%22

Any chance you could include relevant Link tags on your commit
messages for patches that address these? It makes it easier to track
when/where things land if we ever intend to backport anything to
stable.

Or can any of those be closed out?

> to the particular commit in the commit message. Either way:
> Acked-by: Nick Desaulniers <ndesaulniers@google.com>
>
> (Thanks for the series, will pull down and test!)
>
> If you have a github account, let me know it if you'd like to be cc'ed
> when we wire this up in our CI.
>
> >
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> > ---
> >  scripts/min-tool-version.sh | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> > index 53fe64856015..f1e8358ec19a 100755
> > --- a/scripts/min-tool-version.sh
> > +++ b/scripts/min-tool-version.sh
> > @@ -24,9 +24,8 @@ icc)
> >         echo 16.0.3
> >         ;;
> >  llvm)
> > -       # https://lore.kernel.org/r/YMtib5hKVyNknZt3@osiris/
> >         if [ "$SRCARCH" = s390 ]; then
> > -               echo 13.0.0
> > +               echo 14.0.0
> >         else
> >                 echo 11.0.0
> >         fi
> > --
> > 2.32.0
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers


-- 
Thanks,
~Nick Desaulniers