Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 09:11:22 -0500
From:   Rob Herring <robh@kernel.org>
To:     Satya Priya <quic_c_skakit@quicinc.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        swboyd@chromium.org, quic_collinsd@quicinc.com,
        quic_subbaram@quicinc.com, quic_jprakash@quicinc.com
Subject: Re: [PATCH V11 2/9] dt-bindings: mfd: pm8008: Change the address
 cells
Message-ID: <20220511141122.GA226988-robh@kernel.org>
References: <1651742739-12338-1-git-send-email-quic_c_skakit@quicinc.com>
 <1651742739-12338-3-git-send-email-quic_c_skakit@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1651742739-12338-3-git-send-email-quic_c_skakit@quicinc.com>
Precedence: bulk

On Thu, May 05, 2022 at 02:55:32PM +0530, Satya Priya wrote:
> Change the address cells as '2' so that the first cell
> describes the i2c address offset of the clients. 
> This helps us to define the child nodes of all
> clients under the same parent mfd node, instead of
> adding separate mfd DT nodes.
> 
> Change the gpios reg value accordingly.
> 
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---
> Changes in V11:
>  - New patch added from V11.
> 
>  Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> index a89649c..a41618e 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> @@ -39,7 +39,7 @@ properties:
>    interrupt-controller: true
>  
>    "#address-cells":
> -    const: 1
> +    const: 2
>  
>    "#size-cells":
>      const: 0
> @@ -48,7 +48,7 @@ properties:
>      maxItems: 1
>  
>  patternProperties:
> -  "^gpio@[0-9a-f]+$":
> +  "^gpio@[0],[0-9a-f]+$":

^gpio@0,[0-9a-f]+$

>      type: object
>  
>      description: |
> @@ -61,7 +61,7 @@ patternProperties:
>            - const: qcom,spmi-gpio
>  
>        reg:
> -        description: Peripheral address of one of the two GPIO peripherals.
> +        description: Peripheral offset and address of one of the two GPIO peripherals.
>          maxItems: 1
>  
>        gpio-controller: true
> @@ -110,7 +110,7 @@ examples:
>        pm8008i@8 {
>          compatible = "qcom,pm8008";
>          reg = <0x8>;
> -        #address-cells = <1>;
> +        #address-cells = <2>;
>          #size-cells = <0>;
>          interrupt-controller;
>          #interrupt-cells = <2>;
> @@ -120,9 +120,9 @@ examples:
>  
>          reset-gpios = <&pm8350c_gpios 4 GPIO_ACTIVE_LOW>;
>  
> -        pm8008_gpios: gpio@c000 {
> +        pm8008_gpios: gpio@0,c000 {
>            compatible = "qcom,pm8008-gpio", "qcom,spmi-gpio";
> -          reg = <0xc000>;
> +          reg = <0x0 0xc000>;
>            gpio-controller;
>            gpio-ranges = <&pm8008_gpios 0 0 2>;
>            #gpio-cells = <2>;
> -- 
> 2.7.4
> 
>