Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220512112106.2356120-1-zheyuma97@gmail.com>
In-Reply-To: <20220512112106.2356120-1-zheyuma97@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 12 May 2022 14:02:25 +0200
Message-ID: <CAHp75Vfz-Qq3qo3Re7tsL0mfXNVYZYspGDFCDXhtZxwac7bEiw@mail.gmail.com>
Subject: Re: [PATCH] gpio: ml-ioh: Add devm_free_irq() call to remove flow
To:     Zheyu Ma <zheyuma97@gmail.com>
Cc:     Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 12, 2022 at 1:21 PM Zheyu Ma <zheyuma97@gmail.com> wrote:
>
> When removing the module, we will get the following flaw:

Thanks for the report and patch! My comments below.

> [   14.204955] remove_proc_entry: removing non-empty directory 'irq/21', leaking at least 'gpio_ml_ioh'
> [   14.205827] WARNING: CPU: 0 PID: 305 at fs/proc/generic.c:717 remove_proc_entry+0x389/0x3f0
> [   14.209994] RIP: 0010:remove_proc_entry+0x389/0x3f0
> [   14.217820] Call Trace:
> [   14.218057]  <TASK>
> [   14.218264]  unregister_irq_proc+0x14c/0x170
> [   14.218674]  irq_free_descs+0x94/0xe0
> [   14.219019]  mp_unmap_irq+0xb6/0x100
> [   14.219357]  acpi_unregister_gsi_ioapic+0x27/0x40
> [   14.219796]  acpi_pci_irq_disable+0x1d3/0x320
> [   14.220206]  pci_disable_device+0x1ad/0x380
> [   14.220613]  ioh_gpio_remove+0xc5/0xe0 [gpio_ml_ioh]
> [   14.221075]  pci_device_remove+0x92/0x240

Can we remove not so important lines from the above? I guess ~3-4
selected ones would be enough.

> Fix this bug by adding devm_free_irq() call to remove flow.

Fixes tag?

> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>

The code looks okay on the first glance.

P.S. Do you have such hardware?

-- 
With Best Regards,
Andy Shevchenko