Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <012b7b4d-c9a5-9656-0a21-45bb8e0c7795@linaro.org>
Date:   Wed, 11 May 2022 18:04:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/3] MIPS: Loongson64: Add Loongson-2K1000 SMP support
Content-Language: en-US
To:     Qing Zhang <zhangqing@loongson.cn>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, yangtiezhu@loongson.cn
References: <20220511083007.17700-1-zhangqing@loongson.cn>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220511083007.17700-1-zhangqing@loongson.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/05/2022 10:30, Qing Zhang wrote:
> +		if (loongson_sysconf.nr_cpus >= NR_CPUS)
> +			break;
> +
> +		hwids[loongson_sysconf.nr_cpus] = hwid;
> +		loongson_sysconf.nr_cpus++;
> +
> +		np = of_find_compatible_node(NULL, NULL, "loongson, mmio-ipi");

Please document compatibles in the bindings.


Best regards,
Krzysztof