Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <69a3eaf4-0ad6-ffbf-f5be-d6fdc880276f@linux.intel.com>
Date:   Wed, 11 May 2022 15:07:34 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.0
Subject: Re: kismet: WARNING: unmet direct dependencies detected for
 SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH
Content-Language: en-US
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To:     kernel test robot <yujie.liu@intel.com>,
        Brent Lu <brent.lu@intel.com>
Cc:     ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        kbuild-all@lists.01.org, paul@pgazz.com, fazilyildiran@gmail.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>
References: <202205110550.80rLRw2L-lkp@intel.com>
 <cc9905dd-5b66-d01e-491c-64c18198d208@intel.com>
 <dfae72f1-0ee0-cf22-0fd7-5465209fb8b0@linux.intel.com>
In-Reply-To: <dfae72f1-0ee0-cf22-0fd7-5465209fb8b0@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


>>>> kismet: WARNING: unmet direct dependencies detected for
>> SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH
>>
>>    WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
>>      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
>> GPIOLIB [=n]
>>      Selected by [y]:
>>      - SND_SOC_INTEL_SOF_CS42L42_MACH [=y] && SOUND [=y] && !UML && SND
>> [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_HDA_LINK
>> [=y] || SND_SOC_SOF_BAYTRAIL [=n]) && I2C [=y] && ACPI [=y] &&
>> SND_HDA_CODEC_HDMI [=y] && SND_SOC_SOF_HDA_AUDIO_CODEC [=y] &&
>> (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n])
> 
> I can reproduce this, but I question the hard dependency on GPIOLIB in
> the amplifier Kconfig:
> 
> 	max98357a->sdmode = devm_gpiod_get_optional(&pdev->dev,
> 				"sdmode", GPIOD_OUT_LOW);
> 
> If the gpio is optional, max98357a.c should build and compile without
> GPIOLIB, no?

The warning goes away with the patch suggested in
https://github.com/thesofproject/linux/pull/3646

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig

index b106e55170904..8536773548090 100644

--- a/sound/soc/codecs/Kconfig

+++ b/sound/soc/codecs/Kconfig

@@ -986,7 +986,6 @@ config SND_SOC_MAX98095


 config SND_SOC_MAX98357A

        tristate "Maxim MAX98357A CODEC"

-       depends on GPIOLIB


 config SND_SOC_MAX98371

        tristate