Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <e0a9cf982a80f14efbf01cdc38e31128a9f41999.1652262437.git.geert@linux-m68k.org>
 <875ymcwek5.fsf@igel.home>
In-Reply-To: <875ymcwek5.fsf@igel.home>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 11 May 2022 14:02:01 +0200
Message-ID: <CAMuHMdXrd07goR2WffENJnLMAWZxtxoQzaL_7+SG-ZSvaYK1HQ@mail.gmail.com>
Subject: Re: [PATCH] m68k: math-emu: Fix dependencies of math emulation support
To:     Andreas Schwab <schwab@linux-m68k.org>
Cc:     Greg Ungerer <gerg@uclinux.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andreas,

On Wed, May 11, 2022 at 1:43 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Mai 11 2022, Geert Uytterhoeven wrote:
> > Drop the dependency on MMU, as the code should work fine on 68020 and up
> > without MMU (which are not yet supported by Linux, though).
> > Add dependencies on M68K_CLASSIC (to rule out Coldfire) and FPU (to rule
> > out 68xxx below 68020).
>
> Depending on FPU looks strange, since that is supposed to be an FPU
> emulation, for CPUs that _lack_ an FPU (ie. 680[23]0 without the
> 6888[12], or 68LC0[46]0).

I picked FPU because it is selected by all of M680[2346]0.
Upon closer look, both the hard FPU and soft FPU code are protected
by CONFIG_FPU, so the latter looks like the right symbol.
The FPU emu code also relies on the CPU trapping on the proper
instructions, which I believe you need a 68020+ for, too?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds