Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1147659iob; Thu, 12 May 2022 12:14:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNbiyz/zFN8Zq+RADof2DUq4+m+ajMnY5aYKhyc4QP6vOdNtU/mucWi6x8TKTJOa9Nngky X-Received: by 2002:a05:6a00:1a89:b0:50d:fee4:cdb1 with SMTP id e9-20020a056a001a8900b0050dfee4cdb1mr865793pfv.85.1652382852035; Thu, 12 May 2022 12:14:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652382852; cv=none; d=google.com; s=arc-20160816; b=CVwdVNm2dCcRrvKbGb8ZNWN/88A7Tu+RAT/gcwO9MJdu1lXPDgB2xhg8XEdY632o3b INataymNhif2h8QC0nuFqNqTiVTDOw3v7LNYpansMU52rXok/ejf77HfcLo5xKhsRPpd F2UNQpi3mzUwXebgZ5qi+dmyBcOOkvT344cQFWZMdxWWBbf9qx+lh32YVPytMLG0E/s8 dEy2dvLod3JAjV9/O7Xt03tH4lw3vzAy5fuxOVKRKsuyeeD75ScA5phtyvuphHogYI7O qf0VMCG+CMDyZcrFGfkxqIVOQl0J+LN15Aijjifx6kcYitv6T3pqgOky/Z8FPacEJnC1 Rg3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=1qOQZQPTy4U7t+rkSLUr0kIO0VTPczZpQ9pnwXXnwbA=; b=bpcnG/VSFXdctai7NYh4sMuv5rVQJS8um5XeMMIxzgruEtmmCOED6k0QdYbBHaczM+ Bqietu2tzNw0XivdRoCRTgMTZfow0wMwKt1Xq4e+XJQyth2/+58uYmE8MyPg7K0XuWra jEcWaA78R6s9TrPjv71isdda2PZP3xrdeeB4S0eEfc8vPrhwMmXriVpHGqk+3TX9E2pA ufzPB0+5H5bM7Epw+3Xh4xMOM8KQzxHbPvf5A7YHj7xT2LLmfDNQ0LQdzUB1Us27qPuW 8+33Fg8oS843rOGUj388lb9IFGoWRW/BtJOa4Fvukiaz9LESl47qBWleWaFO4mjnoqcu hhuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20210112 header.b=WD7JQy6f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rj1-20020a17090b3e8100b001dc391fd23csi496943pjb.134.2022.05.12.12.13.57; Thu, 12 May 2022 12:14:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20210112 header.b=WD7JQy6f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352891AbiELK4f (ORCPT + 99 others); Thu, 12 May 2022 06:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352978AbiELK4c (ORCPT ); Thu, 12 May 2022 06:56:32 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E67DDE7326 for ; Thu, 12 May 2022 03:56:29 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id y21so5780278edo.2 for ; Thu, 12 May 2022 03:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1qOQZQPTy4U7t+rkSLUr0kIO0VTPczZpQ9pnwXXnwbA=; b=WD7JQy6fN3kvH6v4mOydQ947Tw31kQgVUnaXgy31ouUajVtLLLRAW1tgkdaVG1wsak D2lRTCB/1lP7bJrcocRs4RbF1VsL3M68OHMwq1mDNsIoQdp3EqUAK8F2nKKhE4DTCrzp EmJpK9fI2F/0QHtUYcgGpcAMt9PbzdjpLG6bldHlUC9+qJoytLJr05g0AwEGgTvS1L+M Y+B9cUTITp90Zi8awi4Dppw5hqncJs5ox1bzohJ/DAllxsX0TgSQkfXdzNJP7ULIkSZc kua/FlRjij/TYEwClw3iq7oaN9yrVNHHegzNfMn31Rv9qE5GMO95VrNrpznV5kWBKNHg lP9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1qOQZQPTy4U7t+rkSLUr0kIO0VTPczZpQ9pnwXXnwbA=; b=xxTMaSsPiOyS8pULcHQPpYWopt8D/Z9MBTFvJ+oY7mQMHAOYtAHm9/0bwVwPdze1KZ 27mFw1Zoe8v0wrX1W6D9ACD50u2lJU+hdXInm8s/bR83HcoN4uBc6mX4t5egmb8cmx+Z GgNJkOCpqPX9ByX9saiCLP1Ooc9u/TDI1XN3F7+OqkjaqZKzvgOUt4ZyPTej4C5nuAOU RbGnkY011SijQJlqXW+xZRNTEOlBYmLBuyKfsMOq/xkGBrc8PED6Nc7XYTwyVgwc81xH n3gzPYh+uaasUnZq1rMgOTRwJa7HoUzF+JU382h7HJHUq0QNkef1LwS6/c8+FDYnfW2A bYew== X-Gm-Message-State: AOAM5315VieSVCWG5CZnAT1jwJBFJD0oRueMfy2WF04Al8WIuOjNFACb QqUp/38tbr4Zsf6toDAJIJpHbqkQSjrtPV5P0oc= X-Received: by 2002:a50:ed0e:0:b0:425:e476:f4ed with SMTP id j14-20020a50ed0e000000b00425e476f4edmr34023372eds.32.1652352988427; Thu, 12 May 2022 03:56:28 -0700 (PDT) MIME-Version: 1.0 References: <20220512021611.47921-1-linmq006@gmail.com> In-Reply-To: <20220512021611.47921-1-linmq006@gmail.com> From: Martin Blumenstingl Date: Thu, 12 May 2022 12:56:17 +0200 Message-ID: Subject: Re: [PATCH] ARM: meson: Fix refcount leak in meson_smp_prepare_cpus To: Miaoqian Lin Cc: Russell King , Neil Armstrong , Kevin Hilman , Jerome Brunet , Carlo Caione , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 4:16 AM Miaoqian Lin wrote: > > of_find_compatible_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: d850f3e5d296 ("ARM: meson: Add SMP bringup code for Meson8 and Meson8b") > Signed-off-by: Miaoqian Lin Reviewed-by: Martin Blumenstingl Thank you for spotting and fixing this issue!