Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Mike Christie <michael.christie@oracle.com>,
        Varun Prakash <varun@chelsio.com>,
        Guo Zhengkui <guozhengkui@vivo.com>,
        linux-scsi@vger.kernel.org (open list:SCSI TARGET SUBSYSTEM),
        target-devel@vger.kernel.org (open list:SCSI TARGET SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com
Subject: [PATCH linux-next] scsi: target: cxgbit: replace ternary operator with min()
Date:   Thu, 12 May 2022 21:37:52 +0800
Message-Id: <20220512133754.40849-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YKuObxdaeHHQ81VACLYnPuqZS2efaLgFbSPc+qkxLXQE2NfdDxhB+PSOtneC?=
 =?us-ascii?Q?O/nYWgg9t/RWKAIrFdOJ7Ew+Q2Ene2xe5+suBDdULmOuKelB8cxKwRbTGkxN?=
 =?us-ascii?Q?2TtcgNV7t0voPcDU2kdSvgLPUv4nu39WkV6R2QM3C8KIv8XGqm4gBPtIBa2r?=
 =?us-ascii?Q?B5BUAjYwB55qaErnlztndahisjwkFdcyPihH7C0WEcEd7XzJB7ScsCY/i2qL?=
 =?us-ascii?Q?CrV5DITNmJz7JnTh8ERoEwL2+RzC2uYfKb5PodJtoCky61t3K3MKn9FfFlkj?=
 =?us-ascii?Q?T3SA3eggTgm8alJBMmeo9opxVhj5Qs+QdLb5fBtAxCnHuo9yyU/+lNzr3jD8?=
 =?us-ascii?Q?KZpfVWcPWN2KoKvISlrkLZjHyZlcWkOCV4KFEQpwHek0Z/SWsg00EFVuEcFq?=
 =?us-ascii?Q?2DZLcmf4XFY5+PIAJ3qgTmxBZoYqUPbhRaUqX//Fe3bopZKSlwS+EhEFFwGK?=
 =?us-ascii?Q?8nTu0+6qgt75YfK9Ji+kPEoEwVYG7ub0dUocWymYjVcgMBdSIxuK6QPBhB8N?=
 =?us-ascii?Q?mtKmYGLhJvNpDbrSukihVb+8lCJnufTynH12gmfpdVjmRs4sgkrqbW1SURRl?=
 =?us-ascii?Q?7s8AMdZ8aNXJTQZX9EckCzQ39nAJSf1OshIi8+00RRXgjfkKZvxor0d/T1CT?=
 =?us-ascii?Q?/YD3rE1lJM+FN64lB3/EUR+jAREFkAdyfCVsvvYPZIXYzQdd68ew1flvcNK9?=
 =?us-ascii?Q?qLfuSE1TMhAziCFLq1AdiR2bTPIxDfRWk1huXvAaVNeZByQ2hZUPKcYpiund?=
 =?us-ascii?Q?46EcbaVJvff/H/NDa+0oNgHvdmGPPn8L7ysGOnhBIUe1JtXGEv3iAFNhrJkI?=
 =?us-ascii?Q?/xqpg4yI59y51tCPKamO1a3lWjp+OyPwzGnBb6hE3/IbSdl2+JfvONueMfEX?=
 =?us-ascii?Q?Z0f/SBVGMbEcRcX2QFImexW46zMNXMY/0vtJuhFTLjMQu14/a1wuIdAYIrMo?=
 =?us-ascii?Q?z4RPIyeq7HDWMAAe0hRpiLa24DZnTCfzKEVPAmwma1AfXAb0uzALBB6CgbHW?=
 =?us-ascii?Q?wfYHfijYzCdu/bltZstH+b+ql1uLinHXA1UnV26GeRwhkloeIUQVyyoxnQvK?=
 =?us-ascii?Q?7ybaQqNrxPhMxykd0j/SurC6zT5QOtnErvKqBeF1aXCXDcg3zcxhBbfAMhT+?=
 =?us-ascii?Q?PQ0eJmwRtw1WR5F9WIdLV5uGETXFT7pAUUG6WGtSsZlZEkG7BydBq8ZWOw/7?=
 =?us-ascii?Q?1tesHobOOp/cPDQbq9hpLOTWvx2g7C+ndsvzFcV+gbhaXyjaYnIuw3ZrxQ+/?=
 =?us-ascii?Q?EJoJcpIDz7u8ELSex/WecpYrV16TzGsiIY8IV75Pg1RKXYcmYEJZNE8JyBPM?=
 =?us-ascii?Q?Vuw2cbvHhl8R9H6lN+jadR4wwwy2urtNZG/0NQbvj8tLLh0NsHeqCuIE6z9X?=
 =?us-ascii?Q?3dfLAYqHByKsn421JsjjtlB6TX/sW/T/BifpAmt62ABts3BWJqtaptROtzSY?=
 =?us-ascii?Q?Y0kiNv5x9H1NV9cNZ7qnBUHo5tLPQg+seGwAs8fr7chqO3yMaJk6G6K4TzVy?=
 =?us-ascii?Q?PWgFUcWumdAJ6NJiV9KSK6p1SdG4m4v5VS4/fARydWw/539WAkowRC4u9Cqa?=
 =?us-ascii?Q?U1GdaPgsA8q7HVYM0QqCCJH5ouTb1P2H8274GuVWV5aFz326ZpR7s6z7sUYR?=
 =?us-ascii?Q?bwvIKRvnC5mfrEAyrnG8XZfZ5xDsalyXxrCs3TG7og7+t8ewK87HX3qYXoIE?=
 =?us-ascii?Q?XFHJnlH+V6cfLtpdiuBbDo7zlzCcbz9Nre6TOmdwYh6K29UTvOAxnzTJkN5M?=
 =?us-ascii?Q?ONQwfzUr9Q=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4c7b5f-5dea-41be-b670-08da341cb0c0
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 13:38:25.7525
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jYAF3cN83+6a7ba6mG7cw+LmHEU0et3dYdJ6srQFAWrpytnRy5GG8jUhlXuobAW+FbS/1OcAVLjIqUatSUlm5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3606
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix the following coccicheck warnings:

drivers/target/iscsi/cxgbit/cxgbit_cm.c:1042:12-13: WARNING
opportunity for min()
drivers/target/iscsi/cxgbit/cxgbit_cm.c:1011:12-13: WARNING
opportunity for min()

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/target/iscsi/cxgbit/cxgbit_cm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/target/iscsi/cxgbit/cxgbit_cm.c b/drivers/target/iscsi/cxgbit/cxgbit_cm.c
index 3336d2b78bf7..6d9a13da6cb7 100644
--- a/drivers/target/iscsi/cxgbit/cxgbit_cm.c
+++ b/drivers/target/iscsi/cxgbit/cxgbit_cm.c
@@ -1008,7 +1008,7 @@ int cxgbit_ofld_send(struct cxgbit_device *cdev, struct sk_buff *skb)
 	ret = cxgb4_ofld_send(cdev->lldi.ports[0], skb);
 	if (ret < 0)
 		kfree_skb(skb);
-	return ret < 0 ? ret : 0;
+	return min(ret, 0);
 }
 
 static void cxgbit_release_tid(struct cxgbit_device *cdev, u32 tid)
@@ -1039,7 +1039,7 @@ cxgbit_l2t_send(struct cxgbit_device *cdev, struct sk_buff *skb,
 	ret = cxgb4_l2t_send(cdev->lldi.ports[0], skb, l2e);
 	if (ret < 0)
 		kfree_skb(skb);
-	return ret < 0 ? ret : 0;
+	return min(ret, 0);
 }
 
 static void cxgbit_send_rx_credits(struct cxgbit_sock *csk, struct sk_buff *skb)
-- 
2.20.1