Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 May 2022 11:12:02 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc:     linux-amarula@amarulasolutions.com, linuxfancy@googlegroups.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: max98088: add support for reg_4a_cfg_bypass reg
Message-ID: <YnzdcubW7m+CwnvN@sirena.org.uk>
References: <20220512074359.446999-1-tommaso.merciai@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Rk/8LQJNy9MPTC4G"
Content-Disposition: inline
In-Reply-To: <20220512074359.446999-1-tommaso.merciai@amarulasolutions.com>
Precedence: bulk


--Rk/8LQJNy9MPTC4G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 12, 2022 at 09:43:58AM +0200, Tommaso Merciai wrote:

> Add mixer controls support for M98088_REG_4A_CFG_BYPASS register

> +++ b/sound/soc/codecs/max98088.c
> @@ -486,6 +486,11 @@ static const struct snd_kcontrol_new max98088_snd_co=
ntrols[] =3D {
>         SOC_SINGLE("EQ1 Switch", M98088_REG_49_CFG_LEVEL, 0, 1, 0),
>         SOC_SINGLE("EQ2 Switch", M98088_REG_49_CFG_LEVEL, 1, 1, 0),
> =20
> +       SOC_SINGLE("SPK Bypass Switch", M98088_REG_4A_CFG_BYPASS, 0, 1, 0=
),
> +       SOC_SINGLE("REC Bypass Switch", M98088_REG_4A_CFG_BYPASS, 1, 1, 0=
),
> +       SOC_SINGLE("MIC2 Bypass Switch", M98088_REG_4A_CFG_BYPASS, 4, 1, =
0),
> +       SOC_SINGLE("INA Bypass Switch", M98088_REG_4A_CFG_BYPASS, 7, 1, 0=
),

These look like they should be DAPM controls since they're controlling
audio routing but they're being added as regular controls.

--Rk/8LQJNy9MPTC4G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJ83XEACgkQJNaLcl1U
h9B8ngf+PqafSiaHQZbAhE4xWyxrNCZE8LZdLVxT4EoKR0laiFWL/7SXyI7tdfRl
KK9c0GvCubb9MbNPl3lhFmsPutwnNGpfZmG9JQt3DNcPuyyubB9AJAxq2QUQkIPr
buGHa5C3sFvBgWK7s/tkbSiZRvAYDCYlNZULXD27e8l02qUUK/H5QH9ZB+6EM+j5
n/y4IGIU8FfioDS52UQE11f/lEaRG/arItQ8QYbdBEKOInA+Vm3eCu54j+nLknjr
zBnkr+920iw3UdzBNIasCDnzF2oW5W5tMGWvZEDT8QuQnwGDVuRvkajAylFn+PkE
BbRJ2CENvy9DMpzy5+Wg4RJVTUTuuA==
=emk8
-----END PGP SIGNATURE-----

--Rk/8LQJNy9MPTC4G--