Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp50058iob; Thu, 12 May 2022 18:14:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxT2tcZB1q/GsU9GOxQwYmGN4XMsN4izWNBUtZdOgf2c4kY2nCJbiiy19Qhj/P+2nznr+9c X-Received: by 2002:a05:6402:26d3:b0:427:c590:ae2 with SMTP id x19-20020a05640226d300b00427c5900ae2mr38126524edd.242.1652404440829; Thu, 12 May 2022 18:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652404440; cv=none; d=google.com; s=arc-20160816; b=g/OjVc6KWocwEo8NfWDXKPEipGxOYjbPUHSS2vnj2tkk2sqrFN/YYNurHnKFPKN6xo JhNqChaurPUwiIp3PeFl+0CbJI9pXICmaSn7jZdneNy1Hl3ozuFQrUc+t3JER5xsekcc lASt/WByzQTMPBLWmpuWXsqXo2sePjwDXaV1KwgEfTv63uQuUVhRcvYZgWFOrElg3d2A 3ZurVzl8lF3RqlARu3oLBJitrfMl0U1PE5BbioRwLKfVkTeMpu0r5WIaIkNmUdmyo3nK a95xg7KmzizEK1asdR2PyVk+x39nnZr4nbahP7hulxDuodbMERHXmhmgrWs9pp1zuK85 Fxrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=ylF0qR3cnArBFeQQZFpnmn4XVgr7CRhcI0Foaxzbq1g=; b=VgG3HShV+OLMySQOEDFBpvfXCfHPMso+Sbb5gU6uy+8szHl9uWrrx5ZU49IXGSae+j 6M1TydZA8ZKrkr80kSAmU9vUeKXXyVbufdlyc8Gc62vNv6Nfaqt+IzxcibVIYbaIJd/d omb8v08YfHmQwsF4WJm1EP4sgf3j4iapKHQmbMvSaT+5WzvbsD7JuY4B7hVk3vqLjqKR 8oEdnrgqLsjjnf9xz9EKrFsPUfsJi5fofiRvhzP0GiQTcdy6LEt4/cxhLhiA6sMcCOdw I2B+rCeo9SKxdkaNWLWU3qyJu06xDFCCP0FsBE7DNreJBemShPR+Xr7LQydFtwSCkJvN L7uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oHOnjfSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk20-20020a1709077f9400b006f387f81489si876584ejc.302.2022.05.12.18.13.35; Thu, 12 May 2022 18:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oHOnjfSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357874AbiELTGf (ORCPT + 99 others); Thu, 12 May 2022 15:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353630AbiELTGc (ORCPT ); Thu, 12 May 2022 15:06:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A813F32C; Thu, 12 May 2022 12:06:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11D9AB82910; Thu, 12 May 2022 19:06:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DC36C385B8; Thu, 12 May 2022 19:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652382388; bh=wvLUTuIMgQTvcQXrs4U57mL2ISHtMlc8i3bkcudyddU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=oHOnjfSblftFf7mckEYu4OwFmrcvKPCGxMPa1xLr4OEbpxYoTKN5NXMvEw/bIAQHh 3pHwiKD4BsP8Fr2aAuNb1D/WTP4YfSlIx7W2QapLVYfwXDm4V1jfOkeMFqVp8cLDbk SC/uE2EVsWrnmFsjFWF0I9bWBoWxe8Uk1f2BzN5Dvmc+1ega5Wvi3w/ItRBcvlX6M6 fch8iQKhO8uib8EqCcAfYkV9Yw56D+cExi+iggPBbG/xDrRaK/n4KbPwwydFA1DJge SvTA+BuGqUlTLO+Tu9iWkg22Y/hNKr4Vl8FNgcTzI7nmRGQkIprnA7sRnvFt0u6J5/ y9hsMkZYbjkfw== Date: Thu, 12 May 2022 14:06:26 -0500 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Parshuram Raju Thombare , tjoseph@cadence.com, bhelgaas@google.com, robh@kernel.org, kishon@ti.com, kw@linux.com, mparab@cadence.com, linux-pci@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: cadence: Clear FLR in device capabilities register Message-ID: <20220512190626.GA862290@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165228494389.11307.11313445181760109588.b4-ty@arm.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 05:02:35PM +0100, Lorenzo Pieralisi wrote: > On Mon, 15 Nov 2021 23:39:16 -0800, Parshuram Raju Thombare wrote: > > From: Parshuram Thombare > > > > Clear FLR (Function Level Reset) from device capabilities > > registers for all physical functions. > > > > During FLR, the Margining Lane Status and Margining Lane Control > > registers should not be reset, as per PCIe specification. > > However, the controller incorrectly resets these registers upon FLR. > > This causes PCISIG compliance FLR test to fail. Hence preventing > > all functions from advertising FLR support if flag quirk_disable_flr > > is set. > > > > [...] > > Applied to pci/cadence, thanks! > > [1/1] PCI: cadence: Clear FLR in device capabilities register > https://git.kernel.org/lpieralisi/pci/c/d3dbd4d862 Obviously you've already seen the kbuild report: https://lore.kernel.org/r/202205120700.X76G7aC2-lkp@intel.com but it looks like most of this patch got lost somehow :) Happy to fix it up for you if you want! Bjorn