Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp200101iob; Thu, 12 May 2022 23:01:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRVKdNH/nb4wITF2xnO7ioTjRaW7yn96trRy8qWsDBoKEGGOMZ7MbzfKgbIQotC9f6vQZa X-Received: by 2002:a63:f046:0:b0:3c6:a37b:1613 with SMTP id s6-20020a63f046000000b003c6a37b1613mr2745494pgj.168.1652421661241; Thu, 12 May 2022 23:01:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652421661; cv=none; d=google.com; s=arc-20160816; b=D6WtrutR/lmi9G0Hp722G25R9G6snq3PZRfeVjTDO5fsXqG4aeYF7zlAoh3vQLAfx1 cvetlVAFTTydX4glXd230avu4agkAm2YvgSvI/mRmyvmTDiPiquN9uQ8P6ALI2B1SyH2 qrB1qz3FzPNG5iLwwEJurEvUjDiiKm9ZbGWDKc7DHPum+Iosan44OwKateqy4Jrbn76J W2b0QbBGTswzQVAPMwZIydIYutxZd7cs+iMwlzE+5v+6iheCDVjY9GISC9mfNax1+V/i jle1Eh1jZ7QHGcU9ilYremQF5VyqpkJQ7+9PLGDYzDMEjF1lmMre5zjnCkZ5t7taXhq+ SGGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LSnVqN79z87/ecp/GFGLDH926MCm4llrto7e2SoU8II=; b=VABTQGWDmi+Yd4Q23Dg+6oXQ4T53ELaWaPt1iHTOtzg9d53tQiMOHE/yYr57ZqxuoV RiWyEc+y3itpETnynV2xQaBMwFTgqg1MuMOKT0tK16APZzxZeSs9/39fI1Kd2Yhoq2vq IGgcV4KfyTDRvg/i+1aSgnfqaY4H88AHJ8gi6vIgEMYLPytJaXXK09APAOcgJZxsG4m8 1h5MMUT1ypP/AmHDPnultrcvPC1naDjSanZ2Bw1y9bMba9PG3LOwIV2MxVX2HLnRkXF5 qHIvTArFUYu4IcxgXvIEZZ+3/hzXpd+bbBQSnKvRVDyvPkvm0m2vqFL1fnZZ+pb84W8P CUmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=rpxV0gia; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr16-20020a17090b4b9000b001c6c8e19f0csi6539902pjb.98.2022.05.12.23.00.36; Thu, 12 May 2022 23:01:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=rpxV0gia; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347861AbiEKUna (ORCPT + 99 others); Wed, 11 May 2022 16:43:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343539AbiEKUn0 (ORCPT ); Wed, 11 May 2022 16:43:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B2816D5EC; Wed, 11 May 2022 13:43:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 942BFB82613; Wed, 11 May 2022 20:43:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A9F8C340EE; Wed, 11 May 2022 20:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652301803; bh=xEM/blzijv5Co5pQRjkedHvSJ+0PM6YfCWj1XIj4ZlQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rpxV0gia6NaJ/rSETbrV1QhlvcpbI6rQ4WC3j/kvlTk8wpxdDQtIV0XN1IdiKxUPp A0Q+IKzDEPf/FGcQlfeJmqf2ZhKSzeddyxPxpXg9wbLQt2D6j6bhCMsHnJjL9S87rd 7WcNtdTnmCRFW14s29jr20QwAF6X5k9lEx8YusMo= Date: Wed, 11 May 2022 13:43:22 -0700 From: Andrew Morton To: Sultan Alsawaf Cc: Minchan Kim , stable@vger.kernel.org, Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zsmalloc: Fix races between asynchronous zspage free and page migration Message-Id: <20220511134322.54c44cb0cdd17a0f7fd9f761@linux-foundation.org> In-Reply-To: References: <20220509024703.243847-1-sultan@kerneltoast.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 May 2022 12:50:20 -0700 Sultan Alsawaf wrote: > > Shouldn't the fix be Fixes: 77ff465799c6 ("zsmalloc: zs_page_migrate: skip > > unnecessary loops but not return -EBUSY if zspage is not inuse)? > > Because we didn't migrate ZS_EMPTY pages before. > > Hi, > > Yeah, 77ff465799c6 indeed seems like the commit that introduced the bug. I updated the changelog, thanks.