Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Maxime Ripard <maxime@cerno.tech>
To:     emma@anholt.net, Hui Tang <tanghui20@huawei.com>
Cc:     Maxime Ripard <maxime@cerno.tech>, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        p.zabel@pengutronix.de, mripard@kernel.org, airlied@linux.ie
Subject: Re: (subset) [PATCH -next] drm/vc4: hdmi: Fix build error for implicit function declaration
Date:   Thu, 12 May 2022 11:09:36 +0200
Message-Id: <165234657363.650256.10198774771301868859.b4-ty@cerno.tech>
In-Reply-To: <20220510135148.247719-1-tanghui20@huawei.com>
References: <20220510135148.247719-1-tanghui20@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 10 May 2022 21:51:48 +0800, Hui Tang wrote:
> drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_connector_detect’:
> drivers/gpu/drm/vc4/vc4_hdmi.c:228:7: error: implicit declaration of function ‘gpiod_get_value_cansleep’; did you mean ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration]
>    if (gpiod_get_value_cansleep(vc4_hdmi->hpd_gpio))
>        ^~~~~~~~~~~~~~~~~~~~~~~~
>        gpio_get_value_cansleep
>   CC [M]  drivers/gpu/drm/vc4/vc4_validate.o
>   CC [M]  drivers/gpu/drm/vc4/vc4_v3d.o
>   CC [M]  drivers/gpu/drm/vc4/vc4_validate_shaders.o
>   CC [M]  drivers/gpu/drm/vc4/vc4_debugfs.o
> drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’:
> drivers/gpu/drm/vc4/vc4_hdmi.c:2883:23: error: implicit declaration of function ‘devm_gpiod_get_optional’; did you mean ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration]
>   vc4_hdmi->hpd_gpio = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN);
>                        ^~~~~~~~~~~~~~~~~~~~~~~
>                        devm_clk_get_optional
> drivers/gpu/drm/vc4/vc4_hdmi.c:2883:59: error: ‘GPIOD_IN’ undeclared (first use in this function); did you mean ‘GPIOF_IN’?
>   vc4_hdmi->hpd_gpio = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN);
>                                                            ^~~~~~~~
>                                                            GPIOF_IN
> drivers/gpu/drm/vc4/vc4_hdmi.c:2883:59: note: each undeclared identifier is reported only once for each function it appears in
> cc1: all warnings being treated as errors
> 
> [...]

Applied to drm/drm-misc (drm-misc-fixes).

Thanks!
Maxime