Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220513102616.48040-1-max.oss.09@gmail.com> <20220513102616.48040-4-max.oss.09@gmail.com>
In-Reply-To: <20220513102616.48040-4-max.oss.09@gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 13 May 2022 07:53:23 -0300
Message-ID: <CAOMZO5Au5_=0enWpfQBOK6_62r_5iL4m-pd93Px-NUO9dXb5-w@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] ARM: dts: imx6qdl-colibri: backlight pwm: Simplify
 inverted backlight
To:     Max Krummenacher <max.oss.09@gmail.com>
Cc:     Max Krummenacher <max.krummenacher@toradex.com>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Max,

On Fri, May 13, 2022 at 7:27 AM Max Krummenacher <max.oss.09@gmail.com> wrote:
>
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Set #pwm-cells to the default 3 to gain access to the parameter
> which allows inverting the PWM signal. This is useful to specify
> a backlight which has its highest brightness at 0.
>
> With the change to use the PWM with inverted polarity the PWM signal
> is inverted to how it was before this patch.
> This changes the meaning of the values in the brightness-levels
> property. I.e. the duty-cycle changes from x/255 to (255-x)/255.
> Keeping the brightness-levels will then have a big brightness
> jump from 0 to 127 duty cycle, the other 6 steps will then be
> barely noticeable.
>
> Change the brightness-levels to provide the same brightness-levels
> as before.
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Thanks for the rework:

Reviewed-by: Fabio Estevam <festevam@gmail.com>