Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7056fb8-d218-4ef4-ec45-a9af8e13045c@huawei.com>
Date:   Thu, 12 May 2022 16:32:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 01/20] perf vendors events arm64: Arm Cortex-A5
To:     Nick Forrington <nick.forrington@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
        <acme@kernel.org>
CC:     Will Deacon <will@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        "Namhyung Kim" <namhyung@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        James Clark <james.clark@arm.com>,
        Andrew Kilroy <andrew.kilroy@arm.com>
References: <20220510104758.64677-1-nick.forrington@arm.com>
 <20220510104758.64677-2-nick.forrington@arm.com>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <20220510104758.64677-2-nick.forrington@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/05/2022 11:47, Nick Forrington wrote:
> --- a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> +++ b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> @@ -35,6 +35,18 @@
>           "EventName": "L1D_TLB_REFILL",
>           "BriefDescription": "Attributable Level 1 data TLB refill"
>       },

This is a comment on the general situation of pmu-events support for arm64:

> +    {
> +        "PublicDescription": "Instruction architecturally executed, condition code check pass, load",
> +        "EventCode": "0x06",
> +        "EventName": "LD_RETIRED",
> +        "BriefDescription": "Instruction architecturally executed, condition code check pass, load"
> +    },
> +    {
 > +[
 > +    {
 > +        "ArchStdEvent": "L1I_CACHE_REFILL"
 > +    },

The JSONs for some cores list these common arch events and some don't. 
The effect (if we do) is that the perf tool creates the alias for the 
event and we get all the event info in "perf list", which is useful.

It would be good to have consistency here, but so many arm 
implementations exist and it's tricky to have all cores supported in 
pmu-events. So I had a patch series which makes perf read the armv8 pmu 
sysfs event file to learn all the events which the core supports and 
create the aliases from that. So, in this, we don't require the JSONs to 
list these events explicitly. Maybe I'll revisit it soon.

Thanks,
John