Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dylan Yudaken <dylany@fb.com>
To:     Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>
CC:     <io-uring@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>, Dylan Yudaken <dylany@fb.com>
Subject: [PATCH 2/2] io_uring: only wake when the correct events are set
Date:   Thu, 12 May 2022 02:18:34 -0700
Message-ID: <20220512091834.728610-3-dylany@fb.com>
In-Reply-To: <20220512091834.728610-1-dylany@fb.com>
References: <20220512091834.728610-1-dylany@fb.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
Precedence: bulk

The check for waking up a request compares the poll_t bits, however this
will always contain some common flags so this always wakes up.

For files with single wait queues such as sockets this can cause the
request to be sent to the async worker unnecesarily. Further if it is
non-blocking will complete the request with EAGAIN which is not desired.

Here exclude these common events, making sure to not exclude POLLERR whic=
h
might be important.

Fixes: d7718a9d25a6 ("io_uring: use poll driven retry for files that supp=
ort it")
Signed-off-by: Dylan Yudaken <dylany@fb.com>
---
 fs/io_uring.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 44c57dca358d..44661a1f695a 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6782,6 +6782,7 @@ static void io_poll_cancel_req(struct io_kiocb *req=
)
=20
 #define wqe_to_req(wait)	((void *)((unsigned long) (wait)->private & ~1)=
)
 #define wqe_is_double(wait)	((unsigned long) (wait)->private & 1)
+#define IO_ASYNC_POLL_COMMON	(EPOLLONESHOT | POLLPRI)
=20
 static int io_poll_wake(struct wait_queue_entry *wait, unsigned mode, in=
t sync,
 			void *key)
@@ -6816,7 +6817,7 @@ static int io_poll_wake(struct wait_queue_entry *wa=
it, unsigned mode, int sync,
 	}
=20
 	/* for instances that support it check for an event match first */
-	if (mask && !(mask & poll->events))
+	if (mask && !(mask & (poll->events & ~IO_ASYNC_POLL_COMMON)))
 		return 0;
=20
 	if (io_poll_get_ownership(req)) {
@@ -6973,7 +6974,7 @@ static int io_arm_poll_handler(struct io_kiocb *req=
, unsigned issue_flags)
 	struct io_ring_ctx *ctx =3D req->ctx;
 	struct async_poll *apoll;
 	struct io_poll_table ipt;
-	__poll_t mask =3D EPOLLONESHOT | POLLERR | POLLPRI;
+	__poll_t mask =3D IO_ASYNC_POLL_COMMON | POLLERR;
 	int ret;
=20
 	if (!def->pollin && !def->pollout)
--=20
2.30.2