Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 May 2022 13:56:28 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <vincent.mailhol@gmail.com>
Cc:     Srinivas Neeli <srinivas.neeli@xilinx.com>, wg@grandegger.com,
        davem@davemloft.net, edumazet@google.com,
        appana.durga.rao@xilinx.com, sgoud@xilinx.com,
        michal.simek@xilinx.com, kuba@kernel.org, pabeni@redhat.com,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        git@xilinx.com
Subject: Re: [PATCH] can: xilinx_can: Add Transmitter delay compensation
 (TDC) feature support
Message-ID: <20220513115628.tiplo5wtucri6hy2@pengutronix.de>
References: <20220512135901.1377087-1-srinivas.neeli@xilinx.com>
 <CAMZ6Rq+z69CTY6Ec0n9d0-ri6pcyHtKH917M1eTD6hgkmyvGDQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vddfwce3cegun5mc"
Content-Disposition: inline
In-Reply-To: <CAMZ6Rq+z69CTY6Ec0n9d0-ri6pcyHtKH917M1eTD6hgkmyvGDQ@mail.gmail.com>
Precedence: bulk


--vddfwce3cegun5mc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 13.05.2022 10:24:06, Vincent Mailhol wrote:
> >  #define XCAN_BTR_SJW_SHIFT             7  /* Synchronous jump width */
> >  #define XCAN_BTR_TS2_SHIFT             4  /* Time segment 2 */
> >  #define XCAN_BTR_SJW_SHIFT_CANFD       16 /* Synchronous jump width */
> > @@ -259,7 +261,7 @@ static const struct can_bittiming_const xcan_bittim=
ing_const_canfd2 =3D {
> >         .tseg2_min =3D 1,
> >         .tseg2_max =3D 128,
> >         .sjw_max =3D 128,
> > -       .brp_min =3D 2,
> > +       .brp_min =3D 1,
>=20
> Was there any reason to have brp_min =3D 2 in the first place?
> I think this change  should be a different patch. If the brp_min =3D 2
> is just a typo, you might also want to backport it to stable branches.

+1

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--vddfwce3cegun5mc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJ+R2kACgkQrX5LkNig
011GeQf+LzltNxNz6ZYdvq6yIaIO39Yezh+I+SEnF4qsY5YaMHolOc5EEIAK93Si
wXDfQ4v/uXWIIXTKXXzkIHShHnrtj5JBVOONGLqRr15dp+zoFWQ9cym0toL45h+J
CYeTu+aHAoouoqxIfW5yZ9TRSrrtX6EKasrVZn8Qo3xWw+A2aom5Tx2HSPI82uNj
uzUt2IDUG6Vbghe/WyCoA3ggaJ7D5qR3KMVrW87RjU5XiCPFUZVMx8K7RibTwn3a
vn8HDwC2ICcnpy9HUpY9E/tKp+GGR9FazpNVVuRB7WMMNpjqgrjy91FtlW/viZh6
ubzjc2Hy9P+9V3R5mSyd6H3ZTBDyPA==
=Szv2
-----END PGP SIGNATURE-----

--vddfwce3cegun5mc--