Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 May 2022 08:51:01 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        Baolu Lu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 03/12] iommu: Add attach/detach_dev_pasid domain ops
Message-ID: <20220512115101.GU49344@nvidia.com>
References: <20220510061738.2761430-1-baolu.lu@linux.intel.com>
 <20220510061738.2761430-4-baolu.lu@linux.intel.com>
 <20220510140238.GD49344@nvidia.com>
 <f56ea479-aa82-37ae-91c3-754816a4ed8b@linux.intel.com>
 <BN9PR11MB5276100AC9BBB7DE5CB800CF8CC89@BN9PR11MB5276.namprd11.prod.outlook.com>
 <Yntrv+nq2t/IeVo2@myrica>
 <20220511120240.GY49344@nvidia.com>
 <Ynywqxo4P+aEeS6c@myrica>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ynywqxo4P+aEeS6c@myrica>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z4emeG/Y4sdDgMLtzpZZ7FLSV0a2PIPbNMW0YPsvvMzOR9jg5939gs/atwfF?=
 =?us-ascii?Q?DXBxddVJAfomxfmxWHzXOQHACq2WFzYc6+RUCYrXQRKzSIJcWSbhxSoX327u?=
 =?us-ascii?Q?AFaZptydJ/AJMLDoQxDpuzq0KgmEfuSzlhljfA4GVKYzhFOuGapZxW7CtKSI?=
 =?us-ascii?Q?LSPFmHEMt6SurvAQ7isCiFAzQWedAK9El5GOtInKMIzVvlzL3hMh1L5s8iqu?=
 =?us-ascii?Q?9b16cJKjJKwdKszYziwq+Ez7/j36SImAhbZJh+ITeiwJHQ+OWkDvvLRGOnTn?=
 =?us-ascii?Q?Hys573xpaIR9RB8klqvvdBHMV6h3FFbG7r/DN8GqHhbQ4oOIvPtAe3lXLCde?=
 =?us-ascii?Q?fZL9wGvPtOGkx8G7XW4S/S/BZD1rM52l2GmjObxCRitbst29hwra1boLnzIs?=
 =?us-ascii?Q?cYJddlkwiwNG4bF0qNPBkULnaenL+p8PhDXRx2TEi4c4g1xgvO5kMcfUB8Th?=
 =?us-ascii?Q?G85n24OlXKyqh6Kttu2KQM6j7fLVunx60TsmWUNc3q8ULSSZZJ6d26vAcJ0T?=
 =?us-ascii?Q?vcmP6qGoRxhSt+WQNhwcWfE939OMO3YsJO0HNyccFjut0yqOtBxBIT/vhIh+?=
 =?us-ascii?Q?eQsJ/Qd8e70Z1ps4ZKPQAkD13M2yiMiKj8ppaWgu48YT2BIpn8KOxejHqu8A?=
 =?us-ascii?Q?+txbvjquPew3Cqq++cKdAT6TyK5Fz45JadXDm00Y57PwUYYumSchMdk1pxjB?=
 =?us-ascii?Q?aUg2N4d0D5fEqIk7c/IDxw9uKPVBmaik7gRUX9Dam3zgPkOJQBBLRHzl3PoZ?=
 =?us-ascii?Q?H3DtU/KK2o2QDxnvz7DtBGReEnUnbJX44AxOYLT59JcH2EVsbhgUN6IxMjjx?=
 =?us-ascii?Q?2uTPYOLdlNF6vzIvgaVvkJR7hnGblmFN5YfVhgU4XVlnUU8ypYR2nWaN3FCc?=
 =?us-ascii?Q?GCBwwHU/EM8dqV8AoU0hMlu2KvT8a7H+JfRhw8EVbS5eDINX4CCd1NerPkrh?=
 =?us-ascii?Q?lM9PaZ10i188/1TYsL5BOuBo2yWFdm1lkhqq/Y4Nqx3zpnFGOrnvAJI4QDCv?=
 =?us-ascii?Q?rt4K2AI+MuP8yZrDSK6ytt1ntlhq7g/qzTBy4kTf1Wx1l0CxZBY/Qx19E9q/?=
 =?us-ascii?Q?JnZ+uGgvXibiboJ6k+nEG2F1rztG+jyPIiJA0y7tRhmhd4wUhIcVHVc1vdIi?=
 =?us-ascii?Q?9B3okxVCIH4S6PlriPMfsqPT3CRCeVxwXKsVCJHnyWKsF1YnhDRSSHLEE1Mi?=
 =?us-ascii?Q?U6bP8d3Q1w+lUXVBkLons4JVXHJWzDnYIdxOEu5omlJsHvas5a2b2L1aoTVE?=
 =?us-ascii?Q?ybSOtygXou4zZFIO18qcFq73s5+kOKk9gQ9mEW+t8zkiYEhFgx2Pdiy11xlS?=
 =?us-ascii?Q?f66dHFkjZL9VAST1Tc8R2TPneFvI4uA9BaTX5H0K3XQID+0zbRf33xfQINId?=
 =?us-ascii?Q?+9E2YnZHaxCLxU7u77Sx4s5PImiaLbiBFbUB59Pv0hnkr4l1YrWqwDUQmLX0?=
 =?us-ascii?Q?L+mtgAEBWZh8dKEw535klJDsbhpWIfaLzW6oyuUnPq571mnyDHcCsMeTL78Q?=
 =?us-ascii?Q?MzWvfBVz7NacAqPT9v7NRYkBt7zuPy0VwSY9zSNifjpcs8n0mkjem1jkWV3F?=
 =?us-ascii?Q?5EyQWa/L8BmHR7Y+XKslt7Dq3txrPHwwXCGVhB+BNLrbvtAnAnDg9fhcowPp?=
 =?us-ascii?Q?oq0e1LO2JTAXAZUKUsNVodxWPHnlHjDkKrJMSYocdUkHyBLFlZxPYYsm1lea?=
 =?us-ascii?Q?T6tV/L7ladLDgmPBfj3xeQcJdv/iyYIfxvwYutZrMO66MFpWN2g3xklZLEUT?=
 =?us-ascii?Q?nqbvhJKXxw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c974da9-ef31-4211-3295-08da340db0c8
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 11:51:03.3819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EzMDfUvc3IBtulv4z0uhetqcJkvVSCnvTU72z381+XXJ0fICX9XTI3GNpZEyVRAP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4893
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 12, 2022 at 08:00:59AM +0100, Jean-Philippe Brucker wrote:

> > It is not "missing" it is just renamed to blocking_domain->ops->set_dev_pasid()
> > 
> > The implementation of that function would be identical to
> > detach_dev_pasid.
> 
>   attach(dev, pasid, sva_domain)
>   detach(dev, pasid, sva_domain)
> 
> versus
> 
>   set_dev_pasid(dev, pasid, sva_domain)
>   set_dev_pasid(dev, pasid, blocking)
> 
> we loose the information of the domain previously attached, and the SMMU
> driver has to retrieve it to find the ASID corresponding to the mm. 

It would be easy to have the old domain be an input as well - the core
code knows it.

Jason