Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp564801iob;
        Fri, 13 May 2022 07:45:59 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwrsEFPsuIbQypzV4feNa7fmn5U3tMp925HMEpxkcglEUfwleeSnLOEBiyAfn/hDteACl3x
X-Received: by 2002:a17:907:2da7:b0:6f4:801c:6c3d with SMTP id gt39-20020a1709072da700b006f4801c6c3dmr4425191ejc.310.1652453159062;
        Fri, 13 May 2022 07:45:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1652453159; cv=none;
        d=google.com; s=arc-20160816;
        b=iG3aj+OWJZ3iN3WCB/dM8yfjgLxyOdoso82pufmnXitin9DM5SqHnkg3isuJ2AukGF
         8Ww8mFd47m0VcoxEgXpTO2fwS8LtIn5wS8FXySxFkp0mRxvg/EKzUcnRFSEN3O6fm904
         6+TA8ikooFoE4gHygl08B7E8NkQNsxb7WAwijtqkXpvH29ninvk42V0Wfsi3W+nhHd3K
         EH58eTDQ2krGTnlt9QI8QiAscs8+Z5JXG6MFLkmWWcFx40ETGwhp/JSq0kvpMcjThrDS
         6kDkpmW0gVKWYYd4YUBf46flVGtR36ab3xHPe4i/ps5C+jXaBwbtpeP3IDBBK5Ho+7oz
         3CAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=lY5s4swBg7qFq+qfj+bTaun5I4OB95sIbgcujXJp3Do=;
        b=snkBYx486C7AhdTKfP365m4zty8yXjZkHq4myZi4gU3JLAioWk9tHKK9QnhfJEV9w8
         Yn2AraCmpDaYuLy1kT9TKqlXvnUGC/fx+ftWBieIBno67bIHWrXO4Cjaxa4XcNEII8TT
         Mt59vO8kwcu6XHL4n2gx4R9LyUpMj5iffup5Ja7UJSt6AXUkL5U7yW2IYKwe7ZKs9gUD
         H4f2sR6Ac4UYpUXKZXBdCryNk3+qnpMAiBkuiu1FYhitRoitmj22ouQEYdBUyDbGAQGg
         fyctaBs87EUJ9kbt73sp5vJfX7ezEpAnHLOJWO6SpdXmcJnBJFZFgYAF59tNUd2z2Gm1
         xehA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CsqWIYBI;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id f9-20020a0564021e8900b00425b13acf86si2678246edf.323.2022.05.13.07.45.32;
        Fri, 13 May 2022 07:45:58 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CsqWIYBI;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S245154AbiEKOyW (ORCPT <rfc822;shakeebbk@gmail.com> + 99 others);
        Wed, 11 May 2022 10:54:22 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50912 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S245135AbiEKOyT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 May 2022 10:54:19 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 768432013B0;
        Wed, 11 May 2022 07:54:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=lY5s4swBg7qFq+qfj+bTaun5I4OB95sIbgcujXJp3Do=; b=CsqWIYBIQLAIUxJyn/xWGZA8eg
        HuXtCkWYNU3FffXGdn2FgBsC1nKJcM8xIDu3fQ4LZw6ZvnA20X4dqBHtufRXTnwttYrOkqRfex88v
        wKmAqbJjGM1NJmaUiQFdZEIwp5ezZngDhjKQvgGtb4Ezb5ct1Qd8bMal70JPYECrJbMF1fFQP66kO
        CxbS818lbwsP5L1jdDHgTiqo9sXpYYa4NR4WSGdnXKCImJmZVl6g0XVbIqyWkdWcDErpZtVQ+6FzW
        JsYSTfLcr6KSrVxmCWKhoCRGN/uCgeRw1w0wyAj+lS0DKl4yvf4j66a443+aNjaYo/Urz9L/PMgkL
        d80VtVog==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1nonjC-007KxH-7q; Wed, 11 May 2022 14:54:14 +0000
Date:   Wed, 11 May 2022 07:54:14 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Daniil Lunev <dlunev@chromium.org>
Cc:     linux-fsdevel@vger.kernel.org, fuse-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] fs/super: Add a flag to mark super block defunc
Message-ID: <YnvOFt3sC/XLJj05@infradead.org>
References: <20220511013057.245827-1-dlunev@chromium.org>
 <20220511113050.1.Ifc059f4eca1cce3e2cc79818467c94f65e3d8dde@changeid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220511113050.1.Ifc059f4eca1cce3e2cc79818467c94f65e3d8dde@changeid>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 11, 2022 at 11:30:56AM +1000, Daniil Lunev wrote:
> File system can mark a block "defunc" in order to prevent matching
> against it in a new mount.

Why use a bool instead of using s_iflags?

Also I suspect we should never reuse a force mounted superblock,
but at least for block devices we should also not allow allocating
a new one for that case but just refuse the mount.