Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 May 2022 14:19:48 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        Smita.KoralahalliChannabasappa@amd.com, muralidhara.mk@amd.com,
        naveenkrishna.chatradhi@amd.com
Subject: Re: [PATCH 02/18] EDAC/amd64: Remove scrub rate control for Family
 17h and later
Message-ID: <Yn0XhDwRGB5uBY6E@yaz-fattaah>
References: <20220509145534.44912-1-yazen.ghannam@amd.com>
 <20220509145534.44912-3-yazen.ghannam@amd.com>
 <YnuPU41KWLer9d5T@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YnuPU41KWLer9d5T@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WjbXR6RDNrS5tquzpti0BxxmUTlWnDas4wTrU42xkkU9q+GFF9Ndgrg92/h7?=
 =?us-ascii?Q?K1yc2HrNT7nwUcEjUY1UPFjsL7tB/UDnam4kUNRzRXIB6DzXYhPHU/eAAVXC?=
 =?us-ascii?Q?81SzlbY607YmqtkpPeKB2kNZ6XJQ50i/QElzx+LFD+WViNoyRnirb6ZNSPvB?=
 =?us-ascii?Q?EsKwOT2MtMw+5yb/RSSdHNRbjPnC9GffbDpgHrgo7Q52j1kGhXnTsbhGc6KP?=
 =?us-ascii?Q?TSN8+IAueHB33vlsPwv5D5uldYtkEXP9bZHTUt3ex/c7ko2S1jeay9q0pvme?=
 =?us-ascii?Q?6xOm1efXM1a5743/rzSoEc755F2aI5ctWhyw93UYt7HRDohKtcfg1B3FLopZ?=
 =?us-ascii?Q?rlw54Xw712EdyFpYveQchTs2//VtjU2oknz5ROTmemETRKvFN6HnndQvSB1g?=
 =?us-ascii?Q?50FTNuw9Acl3aaZO+6UqCrnr8owPGfmkub1HfQn0Db00jJhksWkfLFp3fWmb?=
 =?us-ascii?Q?qq0LXjV5nv8JM0ISl7bDOzbeUS8wwo2dYSkoqMItdDAMAXr3hO1lgF4LmyZA?=
 =?us-ascii?Q?SG2NWgSsBKcvPgQjV13M/yIDXt6OuiBUljUEm1bCgHd1RHVXxIPFJJjB2Ibe?=
 =?us-ascii?Q?95R8gxEik8XFBDuxxHELuwBHm0fbi+s7QZeJtBhMOWAR/vXQ2A4JK6QxPQRf?=
 =?us-ascii?Q?ChvnAFt9JJ8emPMsZWkR+dvnCvl9XrM8OHOwwD599j4V5BCQUh/pmL7W943P?=
 =?us-ascii?Q?CQdy/zAEj87RadfM4US3zceQLwoPKa8Iu0mo6lRj+giAhhOHIFNe1zCNqx4P?=
 =?us-ascii?Q?YqirNA0y0Gy61pIoVh66xnNFfPf+07F5BAYw/e7Ygh0DW5h3WBK6qeLHW9dG?=
 =?us-ascii?Q?ud3NUOS/QlqiyNyYZoHPSfF0iAYuwWhYNbA6yN0DTzgj4ZX/5/Og5kI++DAY?=
 =?us-ascii?Q?gyNrYVnmXxqABS14npQf0FI+nhhCjYYX6algiZl4nekaZlgPOYCbOpCqJvaB?=
 =?us-ascii?Q?ChVQZ7ugcBMgEa6YDR3O2qK5DlWQHxackhYtpACOkJTj0KZ07/Z3Lbdwu3sn?=
 =?us-ascii?Q?+7YqK1LviVRZnFoJrHY//YQxECRlRVRqbniy+jAz5Cl7cp/xDWpOZt1+RLxV?=
 =?us-ascii?Q?nWv0w+sKLXfnqMbOStZaKXkpUeuO2P9S5M8HRyc6LtUc+9BPhsjYYhsFVNwb?=
 =?us-ascii?Q?S/q/S3zzU9OIK0rPMiIe/30CD/HBRKBB5sHrz+6SUdXf/7aDEFvhnALD2AZr?=
 =?us-ascii?Q?aZF5bbvaMXsvnSqiKOT8+yb+02QRB49sfie+jfvB8BlVPOksWBTycTE2qsYX?=
 =?us-ascii?Q?7V/640RIgwfLL8MlG9egh+9TKuUOxgwcV+2ZthP9EUTEnMr7+4zyyK8225HD?=
 =?us-ascii?Q?C0bzGPa8pvu8rfZEsDJD0ACBwVvDjSMXvBF4HS80qIBMnIMBdQI98kcPdd50?=
 =?us-ascii?Q?G7vDd0Th/5ESzjnSV/lTE1xkbYkeDq9odfUnMsk1Nnsyfatj0316k6K4jk6Y?=
 =?us-ascii?Q?z++SoinWZUfkdp4sqcwG3bR/gEivuw49cFkUP60h9X8WdPBpG58f4fcnsRSt?=
 =?us-ascii?Q?ka28pgwmgllLssZdy/9AlgbgoAsUXzI9guCGQzYKo+yZCtOV8G8rpX29GwAR?=
 =?us-ascii?Q?Yxv/lWaCsJ8tqMeoDjYfIWt7tTEnHmbLX7t7vH1KaoWDZXo+urDxQdGV+ROD?=
 =?us-ascii?Q?dKzEx8eIex53Fps2FEBPh8mifhhquu8x7Gumnza6AVx90a4gBQvZ/tuDnhWl?=
 =?us-ascii?Q?HeQ0wqg7BlKHapwD+REFhPLijWFpKuBsLJJFs3ox7DNMf99k+anrvZj7lZdt?=
 =?us-ascii?Q?h7fZDXILWw=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 449616ee-df7d-482c-781f-08da34227b22
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:19:52.8235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ASKFfo9FHugxoe0uujxFxJvMPmb1QFgOTjiwfFChPKc27WO68QmTZX7qmZW8hHWSYorWrGWqE/m4kqAdbDnEag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3928
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 11, 2022 at 12:26:27PM +0200, Borislav Petkov wrote:
> On Mon, May 09, 2022 at 02:55:18PM +0000, Yazen Ghannam wrote:
> > @@ -251,6 +234,9 @@ static int set_scrub_rate(struct mem_ctl_info *mci, u32 bw)
> >  	struct amd64_pvt *pvt = mci->pvt_info;
> >  	u32 min_scrubrate = 0x5;
> >  
> > +	if (pvt->umc)
> > +		return -EPERM;
> 
> Since this function is testing families, it might be more
> straightforward for the check to be:
> 
> 	if (pvt->fam >= 0x17)
>

Yes, I'll make that change.

Thanks,
Yazen