Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 May 2022 21:06:37 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Jonas Paulsson <paulsson@linux.vnet.ibm.com>,
        Ulrich Weigand <ulrich.weigand@de.ibm.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Alexander Egorenkov <egorenar@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Andreas Krebbel <krebbel@linux.ibm.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 8/8] scripts/min-tool-version.sh: raise minimum clang
 version to 14.0.0 for s390
Message-ID: <Yn1avbuIFdU87/Jj@osiris>
References: <20220511120532.2228616-1-hca@linux.ibm.com>
 <20220511120532.2228616-9-hca@linux.ibm.com>
 <CAKwvOd=EQa9tyWUi-ZfKrK-AABDRG7=TErHK+yb+_Z_dkjrmfQ@mail.gmail.com>
 <CAKwvOd=T5bd69-pduh8OnYdzGuBdJmF692VYP833ZG3BfGUA+A@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKwvOd=T5bd69-pduh8OnYdzGuBdJmF692VYP833ZG3BfGUA+A@mail.gmail.com>
MIME-Version: 1.0
Precedence: bulk

On Wed, May 11, 2022 at 12:56:27PM -0700, Nick Desaulniers wrote:
> On Wed, May 11, 2022 at 12:27 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > On Wed, May 11, 2022 at 5:05 AM Heiko Carstens <hca@linux.ibm.com> wrote:
> > >
> > > Before version 14.0.0 llvm's integrated assembler fails to handle some
> > > displacement variants:
> > >
> > > arch/s390/purgatory/head.S:108:10: error: invalid operand for instruction
> > >  lg %r11,kernel_type-.base_crash(%r13)
> > >
> > > Instead of working around this and given that this is already fixed
> > > raise the minimum clang version from 13.0.0 to 14.0.0.
> >
> > Do you have the commit in LLVM that fixed this? Might be nice to link
> 
> Maybe it's
> https://reviews.llvm.org/D113341?

Yes, looks like it.

> Also, these are the open issues we had for the integrated assembler.
> https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+label%3A%22%5BARCH%5D+s390%22+label%3A%22%5BTOOL%5D+integrated-as%22
> 
> Any chance you could include relevant Link tags on your commit
> messages for patches that address these? It makes it easier to track
> when/where things land if we ever intend to backport anything to
> stable.

Sure, will do.