Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 10:59:43 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH V10 14/44] mm/pkeys: Introduce pks_set_readwrite()
Message-ID: <Ynv5j6nN8hyHob3C@iweiny-desk3>
References: <20220419170649.1022246-1-ira.weiny@intel.com>
 <20220419170649.1022246-15-ira.weiny@intel.com>
 <202205091304.434A9B45@keescook>
 <YnraD8URWxWtaltF@iweiny-desk3>
 <202205101504.5B5C693F7C@keescook>
 <76ee55622592d531c82cb42b96d4bb27deb26287.camel@intel.com>
 <202205102008.88C15972@keescook>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202205102008.88C15972@keescook>
Precedence: bulk

On Tue, May 10, 2022 at 08:15:45PM -0700, Kees Cook wrote:
> On Tue, May 10, 2022 at 10:26:43PM +0000, Edgecombe, Rick P wrote:
> > v2: 
> > https://lore.kernel.org/lkml/20210830235927.6443-1-rick.p.edgecombe@intel.com/#r
> > 
> > Mostly it fit together pretty easily, but there was memory overhead
> > required to protect the page tables that map the direct map fully
> > (unless a better solution can be found).
> 
> Oh my, I totally missed this. Yay for Too Much Email Every Day. ;)
> 
> I'll give this a read; thanks for working on it!
> 
> Also, can you speak to the schedule of availability for PKS?

Sapphire Rapids is the first CPU.  But I can't speak to any dates.

I'm reworking the series now with your changes.

Thanks again for the review!
Ira