Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V9 2/8] fork/vm: Move common PF_IO_WORKER behavior to new flag
Date:   Thu, 12 May 2022 16:46:58 -0500
Message-Id: <20220512214704.104472-3-michael.christie@oracle.com>
In-Reply-To: <20220512214704.104472-1-michael.christie@oracle.com>
References: <20220512214704.104472-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YVQtemFZVzFK5qIzKigYR1XfrtT8rujuWm7hpn0TkKzI81JCUYVKGa0aPs8I?=
 =?us-ascii?Q?YODz5Kg0SoUMCjwsqQ1dxMeXCcod7/E2nvbsN1IjHC2ifap390GC07dsIJa5?=
 =?us-ascii?Q?x8MMWhl8LZ1NG7Szo4cYx3g8UJNEgG+Plb2CJqSlu1DMuYS/o+Nj8FqvmIQB?=
 =?us-ascii?Q?hddSlHkT1/jIuprG+BHGtCmNmeDEBD0jx1QRhEVuM16Zre5oc1tQN/9vBJka?=
 =?us-ascii?Q?0P+JLjApNmVQ1OwVOq1y7CJcYbVtOnKtNNHTBRmyCSVHBXBGRd6MGx9h4Kgy?=
 =?us-ascii?Q?+KrKZ0c5WDBfqB3Eig/avQJbV1ecjoFoLg5d23DeBko/pFPDkXq3lj3B6LOV?=
 =?us-ascii?Q?5INSeK1vYZfnV9WDC6OSfk4Ng2mtlXuoafROoECiSpDWSjbkijZRBejk2Io/?=
 =?us-ascii?Q?9wGd59FOeYzX47kbm+GNmobN2U9I5s6A0I807Dc4zA84B436VVNEk4vFvRF3?=
 =?us-ascii?Q?wkud6GZqOVX3gMwFtxNYQhicEUz31xyI+9owxw784ladVdPYpt44JOY7mFMX?=
 =?us-ascii?Q?ZAKqqVct9e9GxsSqLJLDkl2oCrw5T+4VhxtUffhrPIwR2sUBo+U1GuBKb3Ua?=
 =?us-ascii?Q?HI5c36wzII2t9IMDYhl3DlQVd+27O7UzdxH68ICNZ7klqlVgPO8M7lEo3bar?=
 =?us-ascii?Q?xtLM1AUrcmNvkOZ1YlYCKZXRoQHdPDc0NNeSp0f6PCNkC5tAuA+VV+WJq06e?=
 =?us-ascii?Q?3/Uw8pOYKj4AhV0Fjar+86l8t+Hdan0O7s0RsPqRr+iBwRmBU2hWbP5UOPQU?=
 =?us-ascii?Q?L+ODdd+rcfY3mUIhzG9xheegynm3JC4+E1jL7gOdaM+jzGMI3qUTRwPLnpu5?=
 =?us-ascii?Q?dPNiWbE2ZB/aSVvfk4wdOY5GhicfpfD3ItHXfr1PECPze9uHPruKJSt5wcyu?=
 =?us-ascii?Q?93WUwx3nVe0WcVYmYfM0mQ6hUoZQZfSWC+O/w7DRbpYEonoTiz89aGo4lNJU?=
 =?us-ascii?Q?WG6+IeNOaF5ZklIhIq/dtTyEAJcKzixmBPS3luvw9LKtjz7RZgmdLNEXRaDu?=
 =?us-ascii?Q?XYaMRzwd9h3fr9cMd9DVmyOFINjJVGHzycSsAljLhHTx022FF8Rarsy34n1C?=
 =?us-ascii?Q?+WUX7TBAUXpHD5jNRXnEmYbKvZLwOtzh7VClLGzNxzPawOVb6yQPsH+bsBjh?=
 =?us-ascii?Q?nAWp8dbc9igFXSqslDui2hwH3y8P2rpw6R0w8YRyE8XQg/Z0E2Y+H7oUh5CM?=
 =?us-ascii?Q?bMQ1YQe2jQiVDG4AhdT/RzwF38JkvcYGNIP4+EJFe75P4k4oUDWsD1JEVDv+?=
 =?us-ascii?Q?eMJl/Th1z+tNUF+drGCmv6oIjiKwFhUnkc1PVlQsvmMzR5Cjw1zscA5UNlbU?=
 =?us-ascii?Q?U0IMWFOCFTUJ0c1ZkFSwIthpXTNimW3TqVrKVNQK0xyoT7YtzFLd/BubqLvO?=
 =?us-ascii?Q?AVSvhPNIYt0uDn0qZliRlQ5W/HJCnYk+BNowD4zYMyNoaQRmESsHAJIMyddf?=
 =?us-ascii?Q?nBSDMPGwLSOOpqoKIoWaFbGiFMigo/X8lpN59N+eeGd4VWiQJQuWSrrjCPNq?=
 =?us-ascii?Q?zBGVNRSrvdk++oXEJavlMyPrvwW32DrB2PyLq1Pl9IFluNI4sp7EG0cA6tFE?=
 =?us-ascii?Q?JjcJRbdkkrsW8q2nXY/IwhUjycMKTNEvOrHCxLpSQ/Umgh5FUUKCg2ogKQfJ?=
 =?us-ascii?Q?B3k7itLeBYp+JoAfKL6aC9rKkmULUWlRCL9PW9H6mXE/Q+tTPczcOsLhKRbL?=
 =?us-ascii?Q?iKidtyhLWBeI1D9iaOS4VC9hjAW0N8lgTQzjcIvDf4EaiCFIl7B3rd4YZtOZ?=
 =?us-ascii?Q?DN8ceKM8DYpYsO0/w9Cy88Hydr5BsvA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b716eb5a-2b77-4ae6-ea60-08da3460f91e
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 21:47:12.8810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8t/hGr99WsIXEWdZmVZuJeZ88iU5aWBnQPDGX7HGkFWtrIS1AtmT7k6+cU2UHZvpf+UCcfBkK0Zu4KE/0n9QMThEFFASEKhHP3TC927cd+U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3311
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-12_13:2022-05-12,2022-05-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205120091
X-Proofpoint-GUID: 5YFTjurr7syQmLBVMbnbXjXQUy64EBRM
X-Proofpoint-ORIG-GUID: 5YFTjurr7syQmLBVMbnbXjXQUy64EBRM
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This adds a new flag, PF_USER_WORKER, that's used for behavior common to
to both PF_IO_WORKER and users like vhost which will use a new helper
instead of create_io_thread because they require different behavior for
operations like signal handling.

The common behavior PF_USER_WORKER covers is the vm reclaim handling.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/sched.h      | 1 +
 include/linux/sched/task.h | 3 ++-
 kernel/fork.c              | 4 ++++
 mm/vmscan.c                | 4 ++--
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index a8911b1f35aa..0fa66a098183 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1700,6 +1700,7 @@ extern struct pid *cad_pid;
 #define PF_MEMALLOC		0x00000800	/* Allocating memory */
 #define PF_NPROC_EXCEEDED	0x00001000	/* set_user() noticed that RLIMIT_NPROC was exceeded */
 #define PF_USED_MATH		0x00002000	/* If unset the fpu must be initialized before use */
+#define PF_USER_WORKER		0x00004000	/* Kernel thread cloned from userspace thread */
 #define PF_NOFREEZE		0x00008000	/* This thread should not be frozen */
 #define PF_FROZEN		0x00010000	/* Frozen for system suspend */
 #define PF_KSWAPD		0x00020000	/* I am kswapd */
diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index b0a9d6c75bcc..9e20fa18c41f 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -18,7 +18,8 @@ struct css_set;
 /* All the bits taken by the old clone syscall. */
 #define CLONE_LEGACY_FLAGS 0xffffffffULL
 
-#define USER_WORKER_IO		BIT(0)
+#define USER_WORKER		BIT(0)
+#define USER_WORKER_IO		BIT(1)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index f4f2c88d9a2a..19293bcca001 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2071,6 +2071,10 @@ static __latent_entropy struct task_struct *copy_process(
 	p->flags &= ~PF_KTHREAD;
 	if (args->kthread)
 		p->flags |= PF_KTHREAD;
+
+	if (args->worker_flags & USER_WORKER)
+		p->flags |= PF_USER_WORKER;
+
 	if (args->worker_flags & USER_WORKER_IO) {
 		/*
 		 * Mark us an IO worker, and block any signal that isn't
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 1678802e03e7..0f58587862ef 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1051,12 +1051,12 @@ void reclaim_throttle(pg_data_t *pgdat, enum vmscan_throttle_state reason)
 	DEFINE_WAIT(wait);
 
 	/*
-	 * Do not throttle IO workers, kthreads other than kswapd or
+	 * Do not throttle user workers, kthreads other than kswapd or
 	 * workqueues. They may be required for reclaim to make
 	 * forward progress (e.g. journalling workqueues or kthreads).
 	 */
 	if (!current_is_kswapd() &&
-	    current->flags & (PF_IO_WORKER|PF_KTHREAD)) {
+	    current->flags & (PF_USER_WORKER|PF_KTHREAD)) {
 		cond_resched();
 		return;
 	}
-- 
2.25.1