Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp936562iob; Fri, 13 May 2022 17:04:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl9LC6tvspGC5Dz+GPKZXqY9sVzvLCslATheyRgYOUt6+QpCatgCTdJeBUM5ja/iP6+Pvr X-Received: by 2002:adf:f9d0:0:b0:207:bcca:7cc2 with SMTP id w16-20020adff9d0000000b00207bcca7cc2mr5779751wrr.697.1652486673863; Fri, 13 May 2022 17:04:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652486673; cv=none; d=google.com; s=arc-20160816; b=DpxZFZ9ve1BX+v+BHhLv21MI7jHTbcV3/OrCbHTe612V88gIafQqcPw9Aud6h6gw6s Wxk3FeawmZ4KYnBlcUFmBghUPIn089Z6aseYEOP2mbToYg0iKYZq+YCtyQX+Fx8fN0mf wEohJEgXnW3kl3t47fqOFS1FthJKTiOnqhBVnEjuJzKOviAlHxw8nfZ4xbWgVprT3TNb X2NBBiIdg8AMi61bfxItHlbf5UK3WnorOZaJfavsGAAaPsAGUmgXLjwEVGZZnBqgNkUA Sdhd2nQg6Hxr5idoseyrOdwMYVqrjr2kZphAgz10LfFwTyV6WU3FYn4KcmH9eBBMs3T8 UdOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :reply-to:dkim-signature; bh=CrGCN5hRJnxUm62pjm+0PSN0YfT03Pp0nPuxePlcuw4=; b=EgNzOInkKMgqhNnbKsK6RWiUmKMO3MAfjlTNdUoGso7TRLFLWdpA79tw5xcQEK4T59 3xUlDuTV46XM4DQAyYTtU8uWKpWJucVXOS2bAvTqhkKSsC8wmklXo98UJoXmDiz+tfi6 HtCds2un/Vc+X+eFDUtXb9ALLj7NVIPrWCQ5LubN31ivxteWeIWdT7hGG80w4URsQ9hE C+CVyy0vEEkcV/0BFOhSs33oLx5tmEWHEC+RS1fn1KRtDpLFmKgMVMSm/WpnirNpFwUu p8tDJZUoVnT9dVY7985JcPb1wBv5i2yOw5WGFo0lay4AiQhSmrGpIg/knHDVFYgeGnxn 6qYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=MAGgCVYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o4-20020a5d4744000000b0020ad0960f13si2970268wrs.554.2022.05.13.17.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 17:04:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=MAGgCVYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DDEBB2B166A; Fri, 13 May 2022 16:07:12 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359146AbiELW1X (ORCPT + 99 others); Thu, 12 May 2022 18:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244070AbiELW1U (ORCPT ); Thu, 12 May 2022 18:27:20 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C9556898D for ; Thu, 12 May 2022 15:27:19 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id pt10-20020a17090b3d0a00b001dd200e709dso5192460pjb.9 for ; Thu, 12 May 2022 15:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:message-id:mime-version:subject:from:to:cc; bh=CrGCN5hRJnxUm62pjm+0PSN0YfT03Pp0nPuxePlcuw4=; b=MAGgCVYbJbmTsUUkI04sS6wT4yI/vXAHYumXdYwQEPtPH3iOreL73vIeL1vS8CyaHs JR0mKpqbMETPdtOA+m/8H6q1G60wjrAv/hJ0ACZI+VpoCYnV+rTBXmoMSpWsk6TX0NhP Fl2OVJBMFGEKjvCl4085AUi0R2t7hbMxPTn9sOZSPBVwbrTkDIL8kqel05LFc+ro1fiy quntsRhh8JnuQlXnVrtbup64U9e8jmraf6JoUd7esjMO//YCkiBjjCmvMc4dHsw7gSmD yONXWUYGQib7sPoQxAS6EsfT/R5opTukg4PzVlhY1emTrym/iyC2pUEnzLy5pfc0BeHr G2jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:message-id:mime-version:subject :from:to:cc; bh=CrGCN5hRJnxUm62pjm+0PSN0YfT03Pp0nPuxePlcuw4=; b=KTUuG8OzzpVLfo1sqIGOsrVn4bmPi9ztqA1phyGE65slTmez7eRw33O0LYDsHhTpsG BhIiJ9qCHnwU/o81WC1fqxuZyi6QwJlQUfYmcLwdtdEBSS07lcTwsvziltvky1HrVBAI 1khS6RlHTE28sgFP9XCpUmIwwflGxUUP4Eiq42/h6//clJibcD7zovZzUmQ9E879KWhI LhgY522EEzgJtUbi6bZH6h3X5hcLaa1b4tivKid9fQ2bnE4iCuP3uAfcNarMFYvlNWd8 Ar6SGLYXh9LPEv/J+xhKPnJFoXTHBp0rMXyJop/dwI4vTRBLmlQGEChoMTi8ElxtU/eZ sg2w== X-Gm-Message-State: AOAM531LCHJdReSvm3gMDIntTWwKcgzk0GdsbhGlvmJxgTnXnp/5sWEJ sZH7IaNO3c5rDINlxpPeuSio3+BNcsg= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a62:e819:0:b0:510:693e:b20c with SMTP id c25-20020a62e819000000b00510693eb20cmr1667809pfi.60.1652394438872; Thu, 12 May 2022 15:27:18 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 12 May 2022 22:27:13 +0000 Message-Id: <20220512222716.4112548-1-seanjc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.0.550.gb090851708-goog Subject: [PATCH 0/3] KVM: x86: WRMSR MCi_CTL/STATUS bug fix and cleanups From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jue Wang Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix bugs in set_msr_mce() where KVM returns '-1' instead of '1' when rejecting a WRMSR, which results in -EPERM getting returned to userspace. Patches 2 and 3 are cleanups to make {g,s}et_msr_mce a bit less wierd (especially with respect to Jue's CMCI series) and a bit less magical. Sean Christopherson (3): KVM: x86: Signal #GP, not -EPERM, on bad WRMSR(MCi_CTL/STATUS) KVM: x86: Use explicit case-statements for MCx banks in {g,s}et_msr_mce() KVM: x86: Add helpers to identify CTL and STATUS MCi MSRs arch/x86/kvm/x86.c | 84 +++++++++++++++++++++++++++------------------- 1 file changed, 50 insertions(+), 34 deletions(-) base-commit: 2764011106d0436cb44702cfb0981339d68c3509 -- 2.36.0.550.gb090851708-goog