Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 12 May 2022 08:53:24 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: netxbig: Fix refcount leak in
 netxbig_leds_get_of_pdata
Message-ID: <20220512065323.GA8632@amd>
References: <20220512050253.8987-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
In-Reply-To: <20220512050253.8987-1-linmq006@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk


--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not needed anymore.
> When of_find_device_by_node() fails, of_node_put() is missing.

Can you take a look at the code and simplify it? AFAICT the node_put
should go right after

       gpio_ext_pdev =3D of_find_device_by_node(gpio_ext_np);


=2E Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--opJtzjQTFsWo+cga
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAmJ8ruMACgkQMOfwapXb+vKxKgCgq/LbToDnu8kaUevCNBdHaZOZ
AQsAnicnD76UXE6zBRhSWkb9/6Kf7A0I
=dBm7
-----END PGP SIGNATURE-----

--opJtzjQTFsWo+cga--