Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Qian Cai <quic_qiancai@quicinc.com>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v9 08/69] mm: start tracking VMAs with maple tree
Thread-Topic: [PATCH v9 08/69] mm: start tracking VMAs with maple tree
Thread-Index: AQHYX1NhZKDMPG7C/keyeY6aTlfpJ60bhQ8AgAAN4YA=
Date:   Thu, 12 May 2022 17:50:58 +0000
Message-ID: <20220512175041.7dfrtpupnomtvxo2@revolver>
References: <20220504010716.661115-1-Liam.Howlett@oracle.com>
 <20220504010716.661115-10-Liam.Howlett@oracle.com> <20220512170100.GA74@qian>
In-Reply-To: <20220512170100.GA74@qian>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1UeX1WaT5YBweurnR1ocsdHqVPRCi/eN94bMniWw/BTHNG16Lw7r3TVj/ZMA?=
 =?us-ascii?Q?/ynb6/z9RXKKfFl+tldiiiovekRte9g+E9xvPBs+B82baSBu23/FQDEqM5t1?=
 =?us-ascii?Q?syBGVllzx6H89NraGanC73/SfwfhHA3YnyIAa6LdezBZwD5VAlLvZMUDj5VR?=
 =?us-ascii?Q?Yd4dupsf58qr/aRFjjdkV++vn5BNnvjG3ebg58mWZs7g13nFbRqEIyKklMQY?=
 =?us-ascii?Q?b6RwMQ6Il6yQCJPy39b4Y+zWn18kb4PZ0QEiAS7lYbthieDmfLB/I2P9wqnQ?=
 =?us-ascii?Q?ni/n9Ep9KmGeYD6OG+ma2z2fDs4WnzxAHQpknrUR2VftI+pZTeXRS/2MftDQ?=
 =?us-ascii?Q?+fXMIdVQjdg2UOwdIb+gXXEj831uHXArjqQ/edgyFcFGKNNrONdaNgWISYJD?=
 =?us-ascii?Q?lC5kMJcGSC8I9xLLknqwm6Gv3EaiYEa19SCws2hptEJl0rHdJ5xup8rF91Fb?=
 =?us-ascii?Q?+cesv1NrXHWyDD99ZGC+mjIyftWx6VqwqM6Gjg1YEB1Q+Oiqpa048lNftV8S?=
 =?us-ascii?Q?UT0tkLmZq8vJlPusLjFf64yGAPtxGiS5ItbrBm7YjmSfwAuPFwj3sZ7ijPXx?=
 =?us-ascii?Q?gEg5znVtCsYVWcO8WIuk/61BTYnLqe57xU7kIU+5Yuownvd+4BsRsTViNJss?=
 =?us-ascii?Q?Kf9eGHYA8scx+TA3KlAmMAcenAJfoXJ3DGGmo2rwMDsRhaKPh/B60GVAyaMw?=
 =?us-ascii?Q?wlhxfLRCZbpTwvCAw6ygzjb9wdmkg58Ws6vKRGYlD1fZrNyu6nx+3nYodBd1?=
 =?us-ascii?Q?JZnyv23L48OOxCAml8Z+w2zOLnT5gDv8xgVcDCFEToQQTnFnt8sRLuk4mecL?=
 =?us-ascii?Q?+faGcLbnr4gy9f8gVOnkElESq8PiTJmfjogc0Rskdvt6B37AGL6DuEYGTksA?=
 =?us-ascii?Q?5Eyad7Wm6KqqEQx3SBdKXYMuQri2WdlLVbOyJUFuw6eYIrSMml1awi4FXika?=
 =?us-ascii?Q?qos671dirpkioD4/sGL4xdsFdMZGlstHVQzE+ZY1QbURD7M/mF5g+yojeJPd?=
 =?us-ascii?Q?numYu4j6UsNUSWtm0CNkCxBPoxZHXURwmMp0HDSpTSmTlLNhG83QS9luuulO?=
 =?us-ascii?Q?lWtpn4s2KWxeX/Ckh56zxaPlQ03/Txnrh1DxmnIQ7Sbwf4TzFROJEBUhX+HS?=
 =?us-ascii?Q?H9CBiJ2fvmnuejo/+yGp/8Vq61OOXVjY1BFtZJueyr6vprpzAIU1HcHsMIVK?=
 =?us-ascii?Q?zojvSluC1mTfxlFOrn5nPF6/8cv3ZFM6/ZqtXyF996s2bx1IJQA5i3+1v2ec?=
 =?us-ascii?Q?a2+cTION6iNop4Y3XGh7YpR70froVMllhM02DN7v8GqgfU3bgfc0IQx02TSa?=
 =?us-ascii?Q?gP7hQhJdl5XTBQMJsVU1GDmtzkETknYcjmMZ+eni8ixEAYQxcpCElkoD6lx7?=
 =?us-ascii?Q?C9zNZdNpp6B/3NUHTik/QSs7ZsmBqBuz2AUXCB0jzKDrZSlM4djVpoESh64D?=
 =?us-ascii?Q?oxpFJNRxwgluHyMI3wc1p3mJMsZRFiWYX4BoYEVYF77evBiPIkmPstNuYXUC?=
 =?us-ascii?Q?XJWnlyQHrd8vrpWsWRBocCyd6W0iaaONmdPVN1BHp7SqXGVa+rDBUFFmIKhR?=
 =?us-ascii?Q?qtpJ2DD5WiVufXTVxAB3H5raL9VxUILGpfliTB82z9IGIebCWBy9tB2nRCG4?=
 =?us-ascii?Q?2lrKHdrh9PPcrPIPteRRvfeArheOSTBIt1FATZgQi7WPStIhSQY99YlLIKN6?=
 =?us-ascii?Q?RM4l5uEVpyElPgEka4J4tBxHuaKCWFo5d6RBq5i+3j+crWwjmBLxqRgh6Tn8?=
 =?us-ascii?Q?TOiAHDq8auHOTWTuSDXywG+smjfnACY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30756F8E02B8D948A99430DBE69C8887@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 042d0631-cadd-49d8-6308-08da343ff8a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 17:50:58.4853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wAx9BxRcZQ0SPxzefRjHlOPkwG6mR/ohSBCvsXgPwqIDoeTA3xo6VAH0HcURzhhp5+w8q45SdNJO8GO0n0jO1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4699
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-12_10:2022-05-12,2022-05-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205120081
X-Proofpoint-GUID: WimObpI0Hiz48d_V1PxRkB7-qgeMQF9S
X-Proofpoint-ORIG-GUID: WimObpI0Hiz48d_V1PxRkB7-qgeMQF9S
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Qian Cai <quic_qiancai@quicinc.com> [220512 13:01]:
> On Wed, May 04, 2022 at 01:07:52AM +0000, Liam Howlett wrote:
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >=20
> > Start tracking the VMAs with the new maple tree structure in parallel w=
ith
> > the rb_tree.  Add debug and trace events for maple tree operations and
> > duplicate the rb_tree that is created on forks into the maple tree.
> >=20
> > The maple tree is added to the mm_struct including the mm_init struct,
> > added support in required mm/mmap functions, added tracking in kernel/f=
ork
> > for process forking, and used to find the unmapped_area and checked
> > against what the rbtree finds.
> >=20
> > This also moves the mmap_lock() in exit_mmap() since the oom reaper cal=
l
> > does walk the VMAs.  Otherwise lockdep will be unhappy if oom happens.
> >=20
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ...
> > @@ -2479,9 +2693,14 @@ int expand_downwards(struct vm_area_struct *vma,
> >  			return -ENOMEM;
> >  	}
> > =20
> > +	if (mas_preallocate(&mas, vma, GFP_KERNEL))
>=20
> We have thousands of leaks reports here from kmemleak while running some
> syscall fuzzers on today's linux-next tree.

Thanks for the report.  Yes, this is mine.  I am testing a fix now.

>=20
> unreferenced object 0xffff0803c0063d00 (size 256):
>   comm "trinity-c25", pid 177739, jiffies 4297781293 (age 354.988s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>      slab_post_alloc_hook
>      kmem_cache_alloc_bulk
>      mas_alloc_nodes
>      mas_preallocate
>      mas_preallocate at lib/maple_tree.c:5579
>      expand_downwards
>      expand_downwards at mm/mmap.c:2094
>      expand_stack
>      do_page_fault
>      do_translation_fault
>      do_mem_abort
>      el1_abort
>      el1h_64_sync_handler
>      el1h_64_sync
>      handle_futex_death
>      exit_robust_list
>      futex_exit_release
>      exit_mm_release
>=20
> > +		return -ENOMEM;
> > +
> >  	/* We must make sure the anon_vma is allocated. */
> > -	if (unlikely(anon_vma_prepare(vma)))
> > +	if (unlikely(anon_vma_prepare(vma))) {
> > +		mas_destroy(&mas);
> >  		return -ENOMEM;
> > +	}
> > =20
> >  	/*
> >  	 * vma->vm_start/vm_end cannot change under us because the caller=