Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220503150735.32723-1-jiangshanlai@gmail.com> <CAJhGHyA3UxremNUH6x5NfUtNMG57zWMM776jzPfj9wfjqvXd2A@mail.gmail.com>
In-Reply-To: <CAJhGHyA3UxremNUH6x5NfUtNMG57zWMM776jzPfj9wfjqvXd2A@mail.gmail.com>
From:   David Matlack <dmatlack@google.com>
Date:   Fri, 13 May 2022 11:31:53 -0700
Message-ID: <CALzav=e-4npHpR6XbCe_JO1R74_=KivoGfM9bB6uHxnuF+X+Gw@mail.gmail.com>
Subject: Re: [PATCH V2 0/7] KVM: X86/MMU: Use one-off special shadow page for
 special roots
To:     Lai Jiangshan <jiangshanlai@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" 
        <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Lai Jiangshan <jiangshan.ljs@antgroup.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 13, 2022 at 1:22 AM Lai Jiangshan <jiangshanlai@gmail.com> wrote:
>
> On Tue, May 3, 2022 at 11:06 PM Lai Jiangshan <jiangshanlai@gmail.com> wrote:
> >
> > From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
> >
> > Current code uses mmu->pae_root, mmu->pml4_root, and mmu->pml5_root to
> > setup special roots.  The initialization code is complex and the roots
> > are not associated with struct kvm_mmu_page which causes the code more
> > complex.
> >
> > So add new special shadow pages to simplify it.

FYI I plan to review this after I get a v5 Eager Page Splitting out
(today hopefully). But from looking at it so far, it looks like a
great cleanup!

> >
>
> Ping