Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <88e501de-9653-0570-74da-d1f7b858a2f0@vivo.com>
Date:   Thu, 12 May 2022 22:39:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] RDMA: replace ternary operator with min()
Content-Language: en-US
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     Potnuri Bharat Teja <bharat@chelsio.com>,
        Leon Romanovsky <leon@kernel.org>,
        Bernard Metzler <bmt@zurich.ibm.com>,
        "open list:CXGB4 IWARP RNIC DRIVER (IW_CXGB4)" 
        <linux-rdma@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        zhengkui_guo@outlook.com
References: <20220512135837.41089-1-guozhengkui@vivo.com>
 <20220512141108.GC63055@ziepe.ca>
From:   Guo Zhengkui <guozhengkui@vivo.com>
In-Reply-To: <20220512141108.GC63055@ziepe.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGF6aHc2MTA2TGhIS3l0UHlJL05CWDR5QSs3QWNIYlRnZGhySjRyQmFqcTdG?=
 =?utf-8?B?b09GZDBpQTFSREM1NXlpbGYxVEkvWE1yK2F6bnNDUjhkZkJsVEx5bDVKK2pN?=
 =?utf-8?B?YmtEdER4cDBRTzdSUk5HU1VhUDVHTHkzekxmNkdqQnZiNVJ4MDd1YlZRcXQ3?=
 =?utf-8?B?aUk5MGVXU3ZzVFVZa0hsVDBQYnZISFk0VGZiRnVtZFNTQjIvT2MyazQzWklP?=
 =?utf-8?B?VVNiQXVVZzdjZVRibjlpeG1xandYcnJkSUljNFFvaUVEcWFhSVR1U3ZSRlMy?=
 =?utf-8?B?d2dXTXpIVjROcDBqa05tUkFzMXZzZGxvN05RMWNvc2F3V29FRzY2c01ITzdR?=
 =?utf-8?B?bWh4UWR3RmpOU0ZFZ2JIOS95c0VPQ1JCc3N6VWJPV0w5MVlMZWIwNDlkQ0FX?=
 =?utf-8?B?YTBBQzVJTDJackRkR1cveUhmMGRGQW03S2p0bTZ2ZDlKOUNoSmdJUUEyekRs?=
 =?utf-8?B?ZHB2WHFZd28ybGsvWkVMd2NVb0g5aXZuWXdqRGtlNmtjeStuOWpVcERsejBD?=
 =?utf-8?B?d0xmaDJlaVJ2TWRHZGNrc0xleWh4Y0hpdjR1OFgyTEJXYmxFbkFON2ViU2N5?=
 =?utf-8?B?M1VhMXZCZ0dyNk9IZUtiMUlhR3l3OGFOb25UVE5QTFRtRDhUMVExdWhHSnA5?=
 =?utf-8?B?OHFzQVdBMkdZOTR0dUFKM2srNlJyTk1VMkxscTNwWFg2aGtzM0s3aGQrWHZW?=
 =?utf-8?B?T29HUmhxMzJsbXV2alZGSmxJN1ZQYlFSRkVvSDRLNGNZN2tOMXc2YStNa1po?=
 =?utf-8?B?NXlyL0JxV2NraUpJTEZMdTV3Q0R5eWtHT2hLUFRRSzQ1Qjl1SVFOUEgzb2R1?=
 =?utf-8?B?WFlkQnF5UWVKc2loTTVJb0owRkxOZVZpUFlKcmpHeEZqRTRwQXM3azM1ZW5G?=
 =?utf-8?B?eWFhZCtPYlVvM2R4Z3ZjanE0bFNaRzFGZWRqZm9pV1I5aisyaTZ5RExWbFov?=
 =?utf-8?B?VWlLbXlvNUg1Z1JwMXpmWlJNeHZEZm1wLzV5M0N5dVoyRTBJNnlWeHlWV2RS?=
 =?utf-8?B?emZ6WGZ6d2xoZXVnL1hPTTVNWlgrVVhTNjhSb3E0b3JtMmh2TVRJbURaWGg4?=
 =?utf-8?B?bkUzbGt4WDlldDZVV043b0ZoTElaZzhpTUIrKzU0QjM5MDJHNG5Ic1ZzaXhm?=
 =?utf-8?B?Qkszdkx4ZG1lTGN4Y1J2SFB1WHEyUGxvYVFwM2pnSzU0Wkd6dWtKQmppTSsv?=
 =?utf-8?B?b0x3Y0NEMitDb29wUUl5K1YwMTduUmxzWjNDc2pwc3ZCSWdHUGNtQllYeW55?=
 =?utf-8?B?dTF0T1lzYUljZkM4amxRdHRSV2FpWlFudlI5UUU3SllDajVMRzJkTW9IWkMw?=
 =?utf-8?B?UU1nUWZRcXhOUnl3T3VVVkpyWThhSlphNnBLMjdQb0N3TUFJV0xBVVBmV3FE?=
 =?utf-8?B?NTFPODBuQ0lyVEd6WGdsVDRFWlF1UUo1RU8wL1U2anJaRmNhRnJRR3VQNVZS?=
 =?utf-8?B?RVg5Y3RobEJGQ1Y2TS9hSU9rSWtTT0dIbGFvaDVwekJ3bzc0SXEvdm5lbnJ2?=
 =?utf-8?B?OHlUTGtCTkVRNGE1dHg3Tkc0b28wdTdXT0dWYTNuelg3QXgyaURPSUFGeS9z?=
 =?utf-8?B?RU5vUkxWRTFWSTFZeEdiemkvUTJ0bUtVK1d0ZTVPNE1hSFNrZjNHVXVMaFpE?=
 =?utf-8?B?LzVmMnpFQSsxbXZmcC8vMWFPWXI2YmV1aklqWjJ4cFNuZGc1WHcwaDk0T1VD?=
 =?utf-8?B?eHZ4MHdwSUJSQjRwM0dCNXRQN3h4UWZlSXJzSTdlZTY5blI3L3M2WGc5dzBs?=
 =?utf-8?B?N3pKaDd3aTdZYTZGUEpOM0R3bGdERTNvcGZBVEVnMUtTbERqYnhkM2c1QW8y?=
 =?utf-8?B?N0xQbG42VFM5M3FmWEdrVWs0VXJVTkk0RElxd0Z1MjM0SllwZFA0QnA1NU1X?=
 =?utf-8?B?UndmMzI3M2N1elRRcGIwVmVvSHR1UlllR0NYOUgxNlBkR1dYTXc5dUZYc0xZ?=
 =?utf-8?B?bXRlU0lmbFlCdGVZemdDT2tKdE9QbktGMHQ4OXVZeTBmcnZ0M2k2dTlMeDV2?=
 =?utf-8?B?TlRWRmJTRWgyVFFVaFBrcE9uVWhOSUlHOXUrU0xTUHR4VDIzM1BkV1Uwa3pk?=
 =?utf-8?B?WUN3dFN5eVJPNE5uamZiOE1MWXIweTFNSnQvVmRvNDVBZUNrZzBQbVVrSnNk?=
 =?utf-8?B?ZjYrYTJzWWZHbWdTQTNHUytXM08veldtOFlXRkFOOGFQa2UwMThveVh5M3B1?=
 =?utf-8?B?cm96anRVd2hNYVJjeVI5ZVd3SEdjRWJLakszOHNvYkw2VzRaZGl1R3QzNGdu?=
 =?utf-8?B?T0hOakxmTER4UGFIUUxIL2NHa1NnVGNoOG9SQmt5RVFDalAzNXhGUHZCdjNi?=
 =?utf-8?B?T2xjb1M0aTlZSW1VdG9TaVhWQmhOa2NZRmZlT1o2WXdNQXl1bDJGZz09?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52306978-f283-4760-8bba-08da3425412e
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:39:43.9912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wkho+Xbh6nLIitISyrrMLdeuLsnYeuYJ06zz5Q1jlo4H8ml5Y42+qB/1NpsZSd5DldHFOL7s5yodFDzg8Jl/ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3052
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/5/12 22:11, Jason Gunthorpe wrote:
> On Thu, May 12, 2022 at 09:58:37PM +0800, Guo Zhengkui wrote:
>> Fix the following coccicheck warnings:
>>
>> drivers/infiniband/sw/siw/siw_cm.c:1326:11-12: WARNING opportunity for min()
>> drivers/infiniband/sw/siw/siw_cm.c:488:11-12: WARNING opportunity for min()
>> drivers/infiniband/hw/cxgb4/cm.c:217:14-15: WARNING opportunity for min()
>> drivers/infiniband/hw/cxgb4/cm.c:232:14-15: WARNING opportunity for min()
>>
>> min() macro is defined in include/linux/minmax.h. It avoids multiple
>> evaluations of the arguments when non-constant and performs strict
>> type-checking.
> 
> no, these are all error return patterns, if you want to change them to
> something change them to
> 
> if (error < 0)
>     return error;
> return 0;

Do you mean we need to stress that they are error return patterns 
instead of taking "minimum value" style code?

Zhengkui

> 
> Jason