Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Guenter Roeck <linux@roeck-us.net>, Peter Rosin <peda@axentia.se>,
        linux-i2c@vger.kernel.org (open list:PCA9541 I2C BUS MASTER SELECTOR
        DRIVER), linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] i2c: mux: pca9541: replace ternary operator with min()
Date:   Thu, 12 May 2022 21:25:11 +0800
Message-Id: <20220512132511.40637-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mDnzEl/rGqFirQzVSMMXD4ST8PtUv8/8kY83uJD1a7u7dzCWpb57CvdSmQIF?=
 =?us-ascii?Q?bVnUNv86h7Fz81v6gsfNVyyAj0ZR1368ZNvXUYH0ntum7ORPImkpCDATbbj8?=
 =?us-ascii?Q?bBXz29U8eU83R7Y1Q3Lcimyy1gpXNPgFzkUB6i3hWqFSNROov5ofnzkmIjp1?=
 =?us-ascii?Q?x6BOUpzckucbXWtWH/b3DIzKCjcXYda8Lc5hmpl4cCSKOUcn41HtRDGKRY2Z?=
 =?us-ascii?Q?B9WBxbjF9VSAthME6Ev9QlU+HhTT3KZqndaNZ6bw76o5suD4oT+26nYmv9e1?=
 =?us-ascii?Q?C6zKdnLxQbRahGKf/t7jhz90Gc/wp4qVMZryC/h+EqkRa1OSqIbOP8Jkic79?=
 =?us-ascii?Q?aqFKGwpgrW1rms807kvPM/y0ZJcChWmhcVbsMClsTKDvUP4/RqAS/Lx7kwlV?=
 =?us-ascii?Q?hambmJex5+4hMrhnZ6ZfFNAOvqaTb8OMnd7RhaEjRh+ogWIrJqe6PBbvU07T?=
 =?us-ascii?Q?5baT4bjP0FoKDR9aVhuUJz9cMssrKDaISgnJgnRqeG5KCyYA0l+uV8uYRxTB?=
 =?us-ascii?Q?PcMMj/5pSNk2Kmr8YLUnPfrY51HcA8TCDIBb6K/Z7riegbCT4hsSeCTMHC73?=
 =?us-ascii?Q?hxKtuhLLbS9AIyg/c36LefXgeItu2Ui4FHREHMzcqiYMaKBEQ923tAv8BJIr?=
 =?us-ascii?Q?OyqXIO0RuyBn2wWjxUbf0yL5nyzjK5VmsVURM359yVTyoovMOTocmOw6alsO?=
 =?us-ascii?Q?HmmG2ZvujL3BkX/aTFuKRq5PCBBucuCvm6suez1eEW5b2oS5wMWC8fxJTgnC?=
 =?us-ascii?Q?ZDcmQay610sxum3Du/tF7xHGT7py602u61F/f1C9kBGxVNo3Z9YHricIMTao?=
 =?us-ascii?Q?xP7gRKE0UcuLACFon/sx6FFj6OqwYh8tEcDrsXFzg85j0TB73ela9rtP6Dt/?=
 =?us-ascii?Q?+wWnAQLaScVnC8bPbS2H0SexpOkgRajdhApULl/1p3jBg8vcLf60VgH1qL+Y?=
 =?us-ascii?Q?z/qfBhhH5DvVbWF0zdT4Gjg1hHl43E5Vefy/e+W0MxO5MVz2OWQdljnr1vz1?=
 =?us-ascii?Q?oykRheFpj0C69JCMV5MCGTe3WgEt9SfrkRXKNxPRgmKfXgVk5mf5q6I+NqgQ?=
 =?us-ascii?Q?nK6ZbmflSEGUwt5CLS9Ll5VLolmGIo253a/GMuP2q7M8+gRQe8bXHOFyesVB?=
 =?us-ascii?Q?mCVCehMIt32YUnRO4gIN+AKGvVZiW3qxYRKThx4EVpXVvQLdPp/Yv6JSeMji?=
 =?us-ascii?Q?MGfE/XF4vl7rVZEn+6FQRZHZcGzeFG7aH0erl/XHwQ73bIUxpxWigci4mMF1?=
 =?us-ascii?Q?jjMgkaU3GdgskXBWYgt++r58mQKVpJIvsj/HD2eWflZ7pBuU3GY9e84eg6/W?=
 =?us-ascii?Q?CqHoA8LP2cxvozV0L48dxhKgKkEXlozjp7HMU0KVVtFpJR92scQ4fTxZOEwq?=
 =?us-ascii?Q?osTVAVC2ojiHmZWSUy9VqRO5r1RFhcwd6xRjWPW4AxTntFv7GzcWQMriyu6N?=
 =?us-ascii?Q?aeyEdwscJ6iJKiMWyvNNa1o0mDz4QwXueSAqBmAmecBrsIZUrQHJe4flAnlc?=
 =?us-ascii?Q?fkrRuT1LUxBl2Va2QfjzfFyQr7Zb2jYfKC1JGxKyHfH+OJBkf8YXmNWW4U77?=
 =?us-ascii?Q?1ozs6cmii/r3Ej01SPMkMvvT54LBmVEGfe7BETAV1F7RQO998LN2wK9TWc3i?=
 =?us-ascii?Q?c42lNrvHx9c2VpOtSZ+Vbz5LRYPXs0oA0m7RtZ23eW1vuvHmC21DxQMkQpFd?=
 =?us-ascii?Q?JU1l6UrsT27qX46QRkmLRyVTuXzSLPo3HxC/842FL14uuYANJyhQxRPxbSE4?=
 =?us-ascii?Q?aM93yVo+0g=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9198f77a-5475-450f-ddb3-08da341afad4
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 13:26:11.0582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XPxTel1EDRkgPtJSZGG01VQ7VLHaKySdW9OOhDEWt2tB0dg+S0XvpDeQqpPItQauGm+GvXS/nbsqLelxi/gW0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2442
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix the following coccicheck warning:

drivers/i2c/muxes/i2c-mux-pca9541.c:263:14-15: WARNING opportunity
for min()

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/i2c/muxes/i2c-mux-pca9541.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
index 6daec8d3d331..f374a1e85837 100644
--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -260,7 +260,7 @@ static int pca9541_select_chan(struct i2c_mux_core *muxc, u32 chan)
 	do {
 		ret = pca9541_arbitrate(client);
 		if (ret)
-			return ret < 0 ? ret : 0;
+			return min(ret, 0);
 
 		if (data->select_timeout == SELECT_DELAY_SHORT)
 			udelay(data->select_timeout);
-- 
2.20.1