Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <5267bf1e-3d74-8344-d4db-698845d941a2@oracle.com>
Date:   Thu, 12 May 2022 14:16:22 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v5 3/3] vdpa/mlx5: Add support for reading descriptor
 statistics
Content-Language: en-US
From:   Si-Wei Liu <si-wei.liu@oracle.com>
To:     Eli Cohen <elic@nvidia.com>, mst@redhat.com, jasowang@redhat.com
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20220510112734.205669-1-elic@nvidia.com>
 <20220510112734.205669-4-elic@nvidia.com>
 <eda33c78-fd39-a5bb-9e9e-06b2c37d3fe5@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <eda33c78-fd39-a5bb-9e9e-06b2c37d3fe5@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2lFWWk2VWcvY3o5SU5oMXFiM3QwL0p2L1JXa3BwWFcwcmhwU0VjRnZsYXFD?=
 =?utf-8?B?L3MvSEU1dnBSdCtKZ1FlT3BleVE0TG5yVUg2SDBCYmh2elJzd3JLQldJZldu?=
 =?utf-8?B?cUpmR2NFUkUvUzhUM0haVVhMZkJVSjgzbUZJbEp5eDN6NTBlcVRGVnIrMzda?=
 =?utf-8?B?eWF5V0pITmlId1B4KzJLa2VHa3k0ajJIMXRkbUQxMEQ4aHE3SkFCOWpNQ25n?=
 =?utf-8?B?dnJGZ2FCSy9SbGhxVk1HeTZueWEwM0R1blA3eW1LdmNyOGV3NE5JaWxPQ1ZX?=
 =?utf-8?B?dW1YVGQycjNDVFo5MDFHL04xQ28xUTh5dHluN3Z3cmQyK2F6aHVkRkdxbDBa?=
 =?utf-8?B?K1ZjUGNzRGZpSGZnM1FZNWo5WVhHMUQ5cTZiRVRhRTNOU0E0Y29wOGlFa2Ro?=
 =?utf-8?B?aVlxeWFBYjNpdk1Ncm1VRTNrS3pRNDYzRzdmYXhKUFFOYXlhb0h1ZG1JUzN4?=
 =?utf-8?B?bXhuanRBcWNucVM3RjY5My9sZ3laT1VPVk03UjhJZ1Z1RHViNmZVTjhyTVh0?=
 =?utf-8?B?VDRIc3MycE91WXhYdjZvNW5GTDJ2RW1PT2VtWHlSeDNVQzZNLzh4dEUxNVcx?=
 =?utf-8?B?YnpwWUdCOHdJRkIxSS9RUG1XbXB0SlU0bnZaNFBkZnRnMWtDS3NzVklBa3Q4?=
 =?utf-8?B?YVFDcER1QlM1eDFpV0IySVROQWNiRWcreThyZHRkQ2R2T2hTQnRjMHVpY1pl?=
 =?utf-8?B?T2hveXdObkFPa05mMmZnTTRVdTh1ZkQyWmU4WkFOSzIxMWZEUEkydlpxY1JP?=
 =?utf-8?B?Nklici9KWFhuMjVsWWhFVnJiUlpqeld1SW95RmJNaS9kdzQxQTc4am1QR1pL?=
 =?utf-8?B?Vzk2Z3B1aHMrR0tiSGZDZDl4ZGQ3Vkw2cTlXK3gvdTh1blB6M0kxZGZITG9p?=
 =?utf-8?B?Z1pxQzZPcmJ6eENTallXdjlReGJ4V2xSZnJrMGhzVk52dDBlTXMrdWJ3VEdq?=
 =?utf-8?B?eE44YlE2d1A3TzVjdUNLZ2hGeVBRdFd4Y2JTa2VRZEhReFNhcHY5d0VISDhn?=
 =?utf-8?B?ZDRqK21rdkk0S2kzdHZxZlFPV21ZaEd0SS93WTVEOU9QSXROUmJQVnpDb2Iw?=
 =?utf-8?B?VFhEQU9hUUpVZ2V0R2l3Vys1dnRBV1ZibyttQ1c4T2Z2K1YzUFFVbzVLRjFR?=
 =?utf-8?B?UHllQjBHZHlJQ1lVZlcyREpNODd5SStSQ2tZbXZBOVU4c0J2ajR0aUF4WkxU?=
 =?utf-8?B?eTBTTVc3QWFjbW9DdmxMTmV4ckhVRm9OM0hSMmx4bDROSVVtSU9GbXhoVS9P?=
 =?utf-8?B?NGhzYnlWcFJHNXJOMVlWcWozWFpucWVTdlJPYVFXazdFSzFWQWhYVGthWTJ2?=
 =?utf-8?B?SEY3cExZZHRkeWdJb0lJTlFUNytGSVpCcW9HQ0IwZkd0VkIwWEp4dllMM0th?=
 =?utf-8?B?clNJcUk1cWxucGRNVXEzMG9nNmxxNFIxZVBRejQ1OVk0TTV1NncySXY1OWJY?=
 =?utf-8?B?TDBVaVF1d2owWHpFMXlCdUU2clE5Z0lEOU5VYTZaQWt2YW85N3BmTFZZbUUy?=
 =?utf-8?B?NW85Y2E1eFlyQ1ZXMUY1WDF5T21sZ243VzJjdDhkanc4dEoxY3pITk9ldTh6?=
 =?utf-8?B?YlprTUptcEV3QzVXMmhmMnFvWW5JbHNST3cxNHVhNHR3TTVFQ1VBeW15ZFJx?=
 =?utf-8?B?SGpIb1hudlgvZ3Z6SHppSzQvbWRjT1pGcmxOYlRmL0Y5UHNnVE54NTdEcDhp?=
 =?utf-8?B?eHRPbllQMjJqamFyQmtJTElRTHVCaGQrZ0xuWEIrbkE1WEhLU0hpSllOelJX?=
 =?utf-8?B?bTdzY1c3TGpVQm4wejRPSDhxWFlEbkhQWlRmVmdNeXBLVzZpazk3MTRNczQx?=
 =?utf-8?B?UEQvNDJKNk5BRXNVWlNXVXZOOERoZ0pRZWxtdVBZUkZFV0h0YXRJYWJlT2V6?=
 =?utf-8?B?RnMzS2JNT01Ma1d3VDBIQzNReHpQU3lpeDZsdkc0M2lrMGZQS213YnJUYUtp?=
 =?utf-8?B?ZGVlbUY2WkVZTzU3UTR4em9maG9HUEg1SjlUOW9KajdsVE1zdVYwYmh6ankz?=
 =?utf-8?B?bG5ZVkNJMU4way81OUpDem5jS3hzcDFQNkNCNVJKMDNCajZ1OUFieFR3UHNt?=
 =?utf-8?B?aW1jZDVpK2trc3Q3WDJZSEtCMVB2SFR2ZWtZemRqOUdWUUtxaHMvWnBWV2lS?=
 =?utf-8?B?cUYzUERucnBmRXJid3NpMlZHeFdma2M0QzlsZVZDd1hNaHV5dXpCWS9TZGxI?=
 =?utf-8?B?VHlMZEFYY3gzODVBQzRvTlNaQjNIb1FpVzZka1hVWXBvcU1sOTFQb0VEV2lS?=
 =?utf-8?B?YWhCSUZJaC9lMHRVRWs5Z0RVQ3I3Q253ZUxRemg1aU9BVlpqUDZuZVB1bFlT?=
 =?utf-8?B?b3p2SUxOSnBSd3F2ZmlnMWcvb1JGSDVjS2JNVFlpaVNkeGsyWlV3UT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 596d5d9e-df43-4a7e-d539-08da345cabb0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3287.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 21:16:25.0349
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mB1p6cBza9BCxDDaUJesNEFboMHol8NMy8fDowAtvqzuQ56R7PkA+5iDnAv7iXrYt9r9f+aNqHdN8BhHw2YXOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4157
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-12_13:2022-05-12,2022-05-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=971
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205120088
X-Proofpoint-GUID: ZbO7uJCZz3f_f4BKFaTW0rrrUguaL4Jk
X-Proofpoint-ORIG-GUID: ZbO7uJCZz3f_f4BKFaTW0rrrUguaL4Jk
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/11/2022 10:25 AM, Si-Wei Liu wrote:
>>
>> @@ -164,6 +165,7 @@ struct mlx5_vdpa_net {
>>       struct notifier_block nb;
>>       struct vdpa_callback config_cb;
>>       struct mlx5_vdpa_wq_ent cvq_ent;
>> +    /* sync access to virtqueues statistics */
> Dangling code change?
... and this.

Thanks,
-Siwei