Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 12 May 2022 21:11:37 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     dave.hansen@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
        luto@kernel.org, mingo@redhat.com, linux-sgx@vger.kernel.org,
        x86@kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org,
        seanjc@google.com, kai.huang@intel.com, cathy.zhang@intel.com,
        cedric.xing@intel.com, haitao.huang@intel.com,
        mark.shanahan@intel.com, vijay.dhanraj@intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 00/31] x86/sgx and selftests/sgx: Support SGX2
Message-ID: <Yn1N2chUNs9EcnM3@iki.fi>
References: <cover.1652137848.git.reinette.chatre@intel.com>
 <YnrllJ2OqmcqLUuv@kernel.org>
 <395657d1-b040-89e7-046f-3cbd358ed7c1@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <395657d1-b040-89e7-046f-3cbd358ed7c1@intel.com>
Precedence: bulk

On Wed, May 11, 2022 at 11:47:31AM -0700, Reinette Chatre wrote:
> Hi Jarkko,
> 
> On 5/10/2022 3:22 PM, Jarkko Sakkinen wrote:
> > If there is any patch that does not have my reviewed-by, please put it
> > there. I was totally happy with v4 already. I went through these, and
> > did not see anything worth of complaining about.
> > 
> > Great job, thank you for doing this.
> > 
> > I can also add my tag separely to each patch, which have not have it on
> > request if that makes things easier in any possible way on request.
> 
> Thank you very much. I do appreciate all the feedback and testing.
> 
> All patches in this series have some tag from you, a few have "Acked-by"
> instead of "Reviewed-by".
> 
> Patch 20/31 "x86/sgx: Free up EPC pages directly to support large
> page ranges" is the only x86/sgx patch that has an "Acked-by" from you
> instead of a "Reviewed-by". All selftests/sgx patches have an "Acked-by"
> from you.
> 
> Here is a summary of your tags if you would like to make changes:
> 
> [PATCH V5 01/31] x86/sgx: Add short descriptions to ENCLS wrappers
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 02/31] x86/sgx: Add wrapper for SGX2 EMODPR function
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 03/31] x86/sgx: Add wrapper for SGX2 EMODT function
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 04/31] x86/sgx: Add wrapper for SGX2 EAUG function
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 05/31] x86/sgx: Support loading enclave page without VMA
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 06/31] x86/sgx: Export sgx_encl_ewb_cpumask()
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 07/31] x86/sgx: Rename sgx_encl_ewb_cpumask() as sgx_encl_cpumask()
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 08/31] x86/sgx: Move PTE zap code to new sgx_zap_enclave_ptes()
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 09/31] x86/sgx: Make sgx_ipi_cb() available internally
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 10/31] x86/sgx: Create utility to validate user provided offset and length
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 11/31] x86/sgx: Keep record of SGX page type
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 12/31] x86/sgx: Export sgx_encl_{grow,shrink}()
> 	Suggested-by: Jarkko Sakkinen <jarkko@kernel.org>
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 13/31] x86/sgx: Export sgx_encl_page_alloc()
> 	Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 14/31] x86/sgx: Support VA page allocation without reclaiming
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 15/31] x86/sgx: Support restricting of enclave page permissions
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 	Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 16/31] x86/sgx: Support adding of pages to an initialized enclave
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 	Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 17/31] x86/sgx: Tighten accessible memory range after enclave initialization
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 18/31] x86/sgx: Support modifying SGX page type
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 	Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 19/31] x86/sgx: Support complete page removal
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 	Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 20/31] x86/sgx: Free up EPC pages directly to support large page ranges
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 21/31] Documentation/x86: Introduce enclave runtime management section
> 	Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 22/31] selftests/sgx: Add test for EPCM permission changes
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 23/31] selftests/sgx: Add test for TCS page permission changes
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 24/31] selftests/sgx: Test two different SGX2 EAUG flows
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 25/31] selftests/sgx: Introduce dynamic entry point
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 26/31] selftests/sgx: Introduce TCS initialization enclave operation
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 27/31] selftests/sgx: Test complete changing of page type flow
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 28/31] selftests/sgx: Test faulty enclave behavior
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 29/31] selftests/sgx: Test invalid access to removed enclave page
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 30/31] selftests/sgx: Test reclaiming of untouched page
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> [PATCH V5 31/31] selftests/sgx: Page removal stress test
> 	Acked-by: Jarkko Sakkinen <jarkko@kernel.org>	
> 
> 
> Reinette

It looks good. And yeah, I've been running different versions of this patch
set since April with zero issues, about a month, in our platform. No high
doubts that anything would wrong that could not be later fixed, if problems
arise.

BR, Jarkko