Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp973997iob; Fri, 13 May 2022 18:14:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXRjM1zRHGc/IaVPp/Xpv3BQFoAceTDg9ur9X9oTfcBbcB6c2eZhmMT6lPR0oO4WBzv0/K X-Received: by 2002:a05:600c:3d16:b0:394:4ff0:d818 with SMTP id bh22-20020a05600c3d1600b003944ff0d818mr6769302wmb.5.1652490855594; Fri, 13 May 2022 18:14:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652490855; cv=none; d=google.com; s=arc-20160816; b=Z0PzYPRnP26DimpjNHI1aHLAoKJEokgXlqbKpBYDDJ4btqF+X00sd5fs4zdp/n/NRT ua9eXfA9JE0Rxgs225AA7bv2u/pX8kqA3V466EAtnL+O/9kME1eBssFdNj1rJJ1LLB0/ 8PoLsW7FFHLf9iTYP+M6izo/k+c10Uz2rUZdmnnwBdhTFREoUK62uSUrksBO4QZsK1sq vc29g49oqh/VAAo91q9TyNYG9/7jFmEpXeU1FT6gHiqYTsMJ9k4rk7IkaYnNymZri+hT VOkJopCvWnRdrQDwJ2OmAE5fdSe7X33A2Jy9t+en8DpOj7ek422xFrrakWrujlL8ge+o DILA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date; bh=xeysOfUywMKqyGOwfOFMrBgEkRJ7u8UgspWEfFtdWdQ=; b=nZsq1JkJsXJ3w4GeXPZBxp4qz21ApxPWng2hA8lNSo4hX5PGT8nFzpIqtc42JLxtaR rpORzUMPbObCltvkdsMcPUBMfUpS5L51qNlz/slZ9YWW0eP+ez8CN5hNQOGlKQJlzSsk pabVJqUPORSQbhcVgXxFcjOzgHO4kpzcd8ME6tnmqglqaN4nUTGKOP0LDyW6fd7xQeek ImFSEGUZA93J8DjVnuY8e5q8nPbRYNJRvDfi3pOYOlM/DXKvBjDtpxRE01nAUlLHNRCw JSC/y+DZVubY9g81BN5RflRKG+qgbitxUMmTU5DucmI9pHwlgds72Tj3S24BzepNIgob Nn6g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a14-20020a056000188e00b0020c6300269bsi3667437wri.820.2022.05.13.18.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 18:14:15 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BD7A53A55DD; Fri, 13 May 2022 16:45:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344666AbiELDnx (ORCPT + 99 others); Wed, 11 May 2022 23:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233136AbiELDns (ORCPT ); Wed, 11 May 2022 23:43:48 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7E8473547; Wed, 11 May 2022 20:43:46 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R701e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=tonylu@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VCyzSpy_1652327023; Received: from localhost(mailfrom:tonylu@linux.alibaba.com fp:SMTPD_---0VCyzSpy_1652327023) by smtp.aliyun-inc.com(127.0.0.1); Thu, 12 May 2022 11:43:43 +0800 Date: Thu, 12 May 2022 11:43:42 +0800 From: Tony Lu To: Guangguan Wang Cc: kgraul@linux.ibm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 1/2] net/smc: non blocking recvmsg() return -EAGAIN when no data and signal_pending Message-ID: Reply-To: Tony Lu References: <20220512031156.74054-1-guangguan.wang@linux.alibaba.com> <20220512031156.74054-2-guangguan.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512031156.74054-2-guangguan.wang@linux.alibaba.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 11:11:55AM +0800, Guangguan Wang wrote: > Non blocking sendmsg will return -EAGAIN when any signal pending > and no send space left, while non blocking recvmsg return -EINTR > when signal pending and no data received. This may makes confused. > As TCP returns -EAGAIN in the conditions described above. Align the > behavior of smc with TCP. > > Fixes: 846e344eb722 ("net/smc: add receive timeout check") > Signed-off-by: Guangguan Wang > Reviewed-by: Tony Lu I see that you have already sent this patch to net, so this patch is a duplicate. There is no need to send it again to net-next. Thanks, Tony Lu