Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 12 May 2022 12:53:06 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
cc:     Pablo Ceballos <pceballos@google.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] HID: Driver for Google Hangouts Meet Speakermic
In-Reply-To: <CAKdAkRQ7yxFFGJg41UxptxapKiP4bmHsfw7dRNE+LPzs1PRk=A@mail.gmail.com>
Message-ID: <nycvar.YFH.7.76.2205121252090.28985@cbobk.fhfr.pm>
References: <20220405183953.2094007-1-pceballos@google.com> <nycvar.YFH.7.76.2204210947590.30217@cbobk.fhfr.pm> <CAKdAkRQ7yxFFGJg41UxptxapKiP4bmHsfw7dRNE+LPzs1PRk=A@mail.gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 12 May 2022, Dmitry Torokhov wrote:

> > > This driver works around a problem with the HID usage sent by this
> > > device for the mute button. It prevents key events from being generated
> > > for that HID usage since they would be incorrect.
> > >
> > > Signed-off-by: Pablo Ceballos <pceballos@google.com>
> >
> > Applied to hid.git#for-5.19/google. Thanks,
> 
> I am curious, could not this be achieved without a kernel driver by
> simply using udev to map this usage code to KEY_RESERVED?

Hmm, good point, using KEY_RESERVED mapping to achieve the key being 
actually ignored didn't immediately occur to me.

Pablo, could you please verify that it behaves in the expected way, and 
confirm that we could drop the 'driver' in favor of udev rule?

Thanks,

-- 
Jiri Kosina
SUSE Labs