Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 12 May 2022 10:58:36 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mark Gross <markgross@kernel.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Enrico Weigelt <lkml@metux.net>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH v2 2/4] watchdog: simatic-ipc-wdt: convert to use P2SB
 accessor
Message-ID: <20220512105836.3fb3ff95@md1za8fc.ad001.siemens.net>
In-Reply-To: <7c458add-a496-6b3a-a04f-e6b68865daf4@roeck-us.net>
References: <20220511153905.13980-1-henning.schild@siemens.com>
        <20220511153905.13980-3-henning.schild@siemens.com>
        <7c458add-a496-6b3a-a04f-e6b68865daf4@roeck-us.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y1qWKtAcdg+ymxQd7KhZ+u/SnS1XtqsoOiKyvdkow+zt7A5px2+tiPqPLMel?=
 =?us-ascii?Q?bVkGYCMHGAHToUn0bnBymhwmFlTqXPgJGf6EETckb553Lkbwiz9mDo3X4RG6?=
 =?us-ascii?Q?/1NuH0KUsm+5O20OL7m3K2VJ2nFXzy0LJHcql2TIRHibVDMMP7FNPfdfimpu?=
 =?us-ascii?Q?z0iBoSsKsUYta4aVsRSh+n8/6szU0Z5eE/A81xt89QPjTlgefUT16iTnOStW?=
 =?us-ascii?Q?IAPNI6Vau8hz2LYwS9NbTGxgvCbjNpSHBkmszgCHGYpB0pVFDH6TuU1Ur3FG?=
 =?us-ascii?Q?muyG0uPOcDzcUzSPMofDnNxOwU24rGo+3mTHGmQdtecDQf9TvaEhl9sFJIex?=
 =?us-ascii?Q?evPusHgVlR2l6X2NYZoGE3rR1z4aLo7VzEUzqWvoc7C0SRakUxMlN6pb/gcv?=
 =?us-ascii?Q?s8T4p1Rd/7tvOBdwYsbP2ad0bUB2UedPlvL9HQtV/ZLkk1ktWsvjpWGEin8Q?=
 =?us-ascii?Q?0lA1moqRPbb4Ts3wbVNepuAGGJQ9zsqnWWL6Vn0NxvJQ8k7cFIMDiSt36rPV?=
 =?us-ascii?Q?Gg8R9LX3r0/yPYsqRwAcuWl9PjC9JfSBj8ub01bAo0NOUmSAQqkk9dr5pxa/?=
 =?us-ascii?Q?jqeg4XAgk0reNKfG4BDLMgFjLNWo1S/mJID2KL8+RSCLYLEYkRrUmFug2vp/?=
 =?us-ascii?Q?6QLhJrWEzthobSjeOvD3b+Cxz/kDzBLOtmjuikcmbmoVSOXFLx/d4hibPZ5T?=
 =?us-ascii?Q?NFR/U2leNlYlXVzpHyGvokfLKGpZsVTy3sXa/7w3Pq0uBD5W37sFY15d5AB5?=
 =?us-ascii?Q?8SmxV45wNcE1Pae0B2Hj8mwdyQtFtbhbTDdWTTdUNhQbhXigQh7jyMcgDl70?=
 =?us-ascii?Q?HXZAYgHTnxq67570GEWrCJiZ79NmbepY6KLrAg1gxv5VoiXaGtC7or9xhoFg?=
 =?us-ascii?Q?+v1Z4ouetB8nASI5zyb+THJ619VWyAHo9yfJGg1PjZ+9RB9RDvMDyEGY39EZ?=
 =?us-ascii?Q?KaD8PnukygDFrmRYfzy90dPaiPgTD7SLrp8cxqjd4e1l1bmGOAbgz7JrFnWg?=
 =?us-ascii?Q?K3AxwVL0gwpT6Dx1NgRRxvtBzJ74EupTaWQAymvc6eFYC3g530YiN4KWRny+?=
 =?us-ascii?Q?uiTf+ieriEUWd+xhEBORtoowKFTQct5eiUmY5NKDnx2p96XVz2uIoqpJfZoe?=
 =?us-ascii?Q?8TPqAJhty+9vx1v35+U52VUyMf/Y7KcIN/0wGND32gdCCuFWJNm30ZcUpHU0?=
 =?us-ascii?Q?Y9MxjiIsRGliWQWfR9vfW+T4bwq9KjW+mnSYg+PniY2YXSKjwVPcgoKm4qXf?=
 =?us-ascii?Q?s1EwkC5dQ7XDVeKU8dYQjADJSHn7PdrkIJ5BJcFXwpc4uqYEckQgd8ZPcQfQ?=
 =?us-ascii?Q?+NBnqVcJ/K5cUwp6aQ7+JbgP/MNcYKVEtUb1N06ROOsU6ODDUEvFnfaCDeWe?=
 =?us-ascii?Q?OLch8y71aQEFzgLdlnN0i1jBmi/3G3xrsfMRb7vr7hYfaXaBAMu32cWc7daM?=
 =?us-ascii?Q?hL3ikk62Lg5ySnB1GmZm+cmDWcxmpj2SWbGOZQU0RUIRXAqKx8ArqHDefdpf?=
 =?us-ascii?Q?jAXHzjPmUDMI3B/OVYhyVUOClj5sMsjF0Up7fMuNtcsBJAI40P4DI0sZEO2h?=
 =?us-ascii?Q?1jZgEfc6XKaeveDcxZg3w22R/LnhmlkCQV7jJYyrswpbc7kZHYqmVTXGGMof?=
 =?us-ascii?Q?l4xfX4ao0nhuIp3CwHhe3L8UJ3JWryzCCs9t8s2e7hy6bWrhNMgWWoWZPzEB?=
 =?us-ascii?Q?A0EC4zEtMo3LyC962l3a6WLcTR8dN6TRPY3xddtbFaTpcxfgKRpUWpGLWE/R?=
 =?us-ascii?Q?YH2bLkuUW3z9t8ca92ZMinJ1uB5YyCmJJHJmm/rgTC/SD7CDZXO9?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b44789b7-03f6-465e-21b2-08da33f59b11
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB5762.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 08:58:38.8879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o5Si+QI7BmkcNF1KioNYvfpDXDV8wGXycM5AMy62jpfrXrmcjeLGODMqxNZSRYQdBi9cuLk56eQFTn9zYajBmNIIcDPyYDy0dHp96pbV5eQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3211
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 11 May 2022 11:03:04 -0700
schrieb Guenter Roeck <linux@roeck-us.net>:

> On 5/11/22 08:39, Henning Schild wrote:
> > Since we have a common P2SB accessor in tree we may use it instead
> > of open coded variants.
> > 
> > Replace custom code by p2sb_bar() call.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >   drivers/watchdog/Kconfig           |  1 +
> >   drivers/watchdog/simatic-ipc-wdt.c | 15 ++++++++-------
> >   2 files changed, 9 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index c4e82a8d863f..643a8f5a97b1 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -1628,6 +1628,7 @@ config SIEMENS_SIMATIC_IPC_WDT
> >   	tristate "Siemens Simatic IPC Watchdog"
> >   	depends on SIEMENS_SIMATIC_IPC
> >   	select WATCHDOG_CORE
> > +	select P2SB if X86  
> 
> Why "if X86" ? SIEMENS_SIMATIC_IPC already depends on it.

Thanks, will remove that.

> Also, I just noticed that P2SB is neither in mainline nor
> in linux-next, meaning this code won't even compile right now.
> That should be mentioned in the introduction e-mail (the use
> of "introduced" suggests that it is already there; you could
> just use "will be introduced" instead).

It was kind of in the cover letter, but maybe not verbose enough. Sorry
for the confusion. v1 was sent in-reply-to on top of P2SB, maybe i will
do that again for v3 but for sure point out the order in case i send it
without the reply.

Thanks,
Henning

> Thanks,
> Guenter