Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
CC:     Jakub Kicinski <kuba@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "outreachy@lists.linux.dev" <outreachy@lists.linux.dev>,
        "jdenham@redhat.com" <jdenham@redhat.com>,
        "sbrivio@redhat.com" <sbrivio@redhat.com>,
        "jesse.brandeburg@intel.com" <jesse.brandeburg@intel.com>,
        "anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "shshaikh@marvell.com" <shshaikh@marvell.com>,
        "manishc@marvell.com" <manishc@marvell.com>,
        "razor@blackwall.org" <razor@blackwall.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "GR-Linux-NIC-Dev@marvell.com" <GR-Linux-NIC-Dev@marvell.com>,
        "bridge@lists.linux-foundation.org" 
        <bridge@lists.linux-foundation.org>
Subject: Re: [PATCH net-next v7 2/2] net: vxlan: Add extack support to
 vxlan_fdb_delete
Thread-Topic: [PATCH net-next v7 2/2] net: vxlan: Add extack support to
 vxlan_fdb_delete
Thread-Index: AQHYZeaGVmJ2NLPAj0ictYFP1xlh760bbReAgAAHG4CAAAg+gIAACWuA
Date:   Thu, 12 May 2022 17:50:56 +0000
Message-ID: <20220512175055.65ftcpkig3t3ttsq@skbuf>
References: <cover.1652348961.git.eng.alaamohamedsoliman.am@gmail.com>
 <c6069fb695b25dc2f33e8017023ddd47c58caa8d.1652348962.git.eng.alaamohamedsoliman.am@gmail.com>
 <c5ec2677-3047-8a70-9769-d48a79703220@nvidia.com>
 <20220512094743.79f36d81@kernel.org>
 <c6b41db9-78e7-e752-3945-29c70a3d8cb4@nvidia.com>
In-Reply-To: <c6b41db9-78e7-e752-3945-29c70a3d8cb4@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KhpUttgt1XWCTHALy8mVFHJYmvkA9t2tCFjG4py6yNX1g1/Hhy7ei89g8t5V?=
 =?us-ascii?Q?9RNUx0UWCa3NCglEveCjwfPGXxlovLlp5rYVboBD1Kr7NaWc6yWC56otM+cG?=
 =?us-ascii?Q?CBe/riR+yseJHvSRLuL/I8JFD3L0DPQJ36YNsqQ9/oiTx2CilsCq3KYEgh94?=
 =?us-ascii?Q?pZGlR0uoUCAzfvzO24w2+4rqUvArW3D7m8fPlCUu/w9thRJo8UmmXr7R5kKq?=
 =?us-ascii?Q?6C5ysDFociNb8kBzWGroorKoaiqf2xxM5MfZjsrblsbxdhYHK1Sr1PNnkh99?=
 =?us-ascii?Q?3IB/UfN2R8d3CPCC3Z6xhGEfl3kSRxMdKaH/bdWg/3eMjXDr/jnraqbI8RT+?=
 =?us-ascii?Q?8mJOjYAyVz6dwN2imOad++CCzF3nZDV6pgTrobRTE4dTSG089JoQu4LCK8VS?=
 =?us-ascii?Q?VM7Es0jfwEzHB0c4XxJK8TsTeCk0+1Z6kxCclylh7ONwppE9ho7PGa3VuYw8?=
 =?us-ascii?Q?HxXA1JmK1nxqhUWBok0gjIc54yYjq44bRdDaQEofvrVQLYnIfs2onlngoAQ7?=
 =?us-ascii?Q?dU+hvq3L7o3nPhPOI8v5p6eEitUqNoP2iNkNhqGldONTrAAUEoOvOEn/9NuX?=
 =?us-ascii?Q?TIuPV402mM49zRguoyXcz5xa7lSdx8JjqLdo++Rn122rQHJGyXrFh51KtC9r?=
 =?us-ascii?Q?IpuscJDGU3GxY7sycCVeLf1g5YXi2us9sY7i+NRyBxjXqwcWVDAU06By1uLE?=
 =?us-ascii?Q?EUDLes8WHU/VkwNYsG9efFsliLc2sJJGnByaDpzK6O/yIJTQdDOrX8AYbJ2x?=
 =?us-ascii?Q?hGOFgxQhKyP27U1cXDA463HsY9JLqczPn7FhiGsHlafv/ge2Lyq/ONDkHe+9?=
 =?us-ascii?Q?t5sSVT1Ymdlx//A/6LFHmSIreONAp9YHkXvkZkA+ppD9HhISnkCV8gR7rDwk?=
 =?us-ascii?Q?K5ECMWqxE4C0le88IH6LvA1OAhfyVEE2hJ5OtvgexfoqPM2ZFC0tNQABzsz5?=
 =?us-ascii?Q?kIPwcwHVlWUh8s6WGBfBA2DK7WgNW0vj6MiornLj67SXqLC1ZB9IT+2WNZmv?=
 =?us-ascii?Q?Ekpidc81aAn7CyJCoxjnZPJvYRXmMloaRkneBbCbjLDLURVgYYhfhsq1lb6E?=
 =?us-ascii?Q?795Ysh0oa+4cjAioXAey0D5ewLuGv+TQzBjdjHkFmEOAzGQGdzA41Lytwogc?=
 =?us-ascii?Q?NJgBVZ7YezlYuXh0iuhwhDDi2Ju8eUNNeeL3W6WsZ+BjS73EL6ioEasWp4qP?=
 =?us-ascii?Q?42Sl4rRPLPbtkvvAUiGfqX6g3hInGzDcDIkJ6pW0mGDb5zNchjWem3QgnS0a?=
 =?us-ascii?Q?iWlMHAtOYi2WBx2uaGLqdMAPIM07h72TZnqVp9/KHG5TPRStqyON5OJHvd5l?=
 =?us-ascii?Q?eS78hUOheTb2PQZHahv6E1c2BHawpuqRC/S+mZ7LsQpom65Q6gP8HhQTBzSx?=
 =?us-ascii?Q?OAkSahofGQOzp4Bj64nKVtUSC+iEcvruKqqiAGy1FAn5dvCT9C7jLXldZlT0?=
 =?us-ascii?Q?TJev6umj+TK4Uep+gOJYqXZoAwjHeun3YTrTMY1F7cxMGQtDilnmqvfjyqEz?=
 =?us-ascii?Q?ZINH1mX28zNzKCYXuUkcNFzXVKyOrsxgZyolKaGVM/V+stIz0FvlBeSKKFdv?=
 =?us-ascii?Q?4d90P0olEzsSgx5IC2L204iDnOa6LKhZ4lh3PCobbAp5QDXCnjjIhHHYXqMo?=
 =?us-ascii?Q?2FkDdOf8ICJsPorKU7JxN1R9hk4cSCcG8jMYCL/U8AUFm8bRtuA5CVzPL0uI?=
 =?us-ascii?Q?HZLOBmj0cQtolSI7eaoEMZwiJxJ0Be5ALPU1s8zZfuOm+DpA1WUkkEvBsryQ?=
 =?us-ascii?Q?GzA7HKNyY8kzUU7h7vJWrapstGCrLCw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1FBBF271EF790D4EA63BD40553277A08@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3225fac-f5d6-4be9-b3fc-08da343ff772
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 17:50:56.4795
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XbuJTDgMrXuLKY1QEX5L7hZ61k9TLUm0tIhempDTGvYqmzF/y44lWB2y9b5QFdWWm+3uhYjyUEi6cjzWkHswFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3153
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 12, 2022 at 10:17:13AM -0700, Roopa Prabhu wrote:
>=20
> On 5/12/22 09:47, Jakub Kicinski wrote:
> > On Thu, 12 May 2022 09:22:17 -0700 Roopa Prabhu wrote:
> > > On 5/12/22 02:55, Alaa Mohamed wrote:
> > > > This patch adds extack msg support to vxlan_fdb_delete and vxlan_fd=
b_parse.
> > > > extack is used to propagate meaningful error msgs to the user of vx=
lan
> > > > fdb netlink api
> > > >=20
> > > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> > Also the patches don't apply to net-next, again.
>=20
> that's probably because the patches were already applied. Ido just told m=
e
> abt it also
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commi=
t/?id=3D5dd6da25255a9d64622c693b99d7668da939a980
>=20
> I have requested Alaa send an incremental fix (offline).
>=20
> thanks
>

Alaa, when you send the incremental fixup patch requested by Roopa,
could you please also:

- properly align the extack argument of the ocelot_port_fdb_del()
  function
- properly align the extack argument of the vxlan_fdb_delete() function
- properly align the "DST, VNI, ifindex and port are mutually exclusive wit=
h NH_ID"
  string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_p=
arse().
- make actual use of the extack in ice_fdb_add() and ice_fdb_del(), and
  remove the __always_unused from ice_fdb_add().

Thank you.=