Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp981747iob; Fri, 13 May 2022 18:29:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCtKZC3zgMNpVdZvl+NBP4wsJ9Kai3qICoJ9ZvdihXQw9BIgbghAm05CJos8NQr9SysMFe X-Received: by 2002:adf:f6c4:0:b0:20a:cd34:9f68 with SMTP id y4-20020adff6c4000000b0020acd349f68mr5818520wrp.122.1652491799802; Fri, 13 May 2022 18:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652491799; cv=none; d=google.com; s=arc-20160816; b=KPgIrZuyRS4E8/rTKoaeOFYAL/KtGSuNzuzEINQ8Hn8BK3V6CpfzovAga+HqrJgRxZ fh9oRhz5exA7kgJc7x6U4K5kQf7ZJe27bqHJnes0WV5QrYVN+6r21W0ZhduWUmY2uoFS 4s2fi537nM6c5ogN4cXKN0h8Y8Ez9wan46J7xSJkbyZ2a7Vd5PzNcGqrIiNVszMLr5wL iI7K1+IYI+JraX0ON+hxTv2aXa/k0FtJKs+5jq+3x0YjwWJzaUxOsAs5cSYmRJK/Ifge xpGlQEMenhXz5Bai7/LMudn3sWhru+T+rXd5rEMDDG0OWe6ZdDClgTGMUt2/2hvtfdnK 5EdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=H5A1bm8vsDCwwfI6eGxlETDJ1arOL6HlCCkz47nzziQ=; b=m6leHlTlm+3a8pAO2D6KLzZ4y4NPuLRLWXZwGX1bSsKx0vDA+fk4B5RSlpvfseH5bW DeDmQ7bGdwuIt3KB/zj3Prx+3ZWo3PL2pEDLN2cTywvM/gTGfBoX0j8DiCzs4AdEXHdB Y1kkksl95BatlqFgwkMTx/v0E2ShGHuDsm4naMvkSNQefrC/TmzvThzIJaCXR8acwToI WbnDhvExk3XOEMptIAteYSTCAEqnoCrVuPmOyvO08+yXxxoz8OartffSDrneoM4Y0AKv 81Mfy1/e7TuiA6JCr1QJej6IWHJibq2omEbCZdQW8pQx046vxCzrHOygxu4DZZ1x3lIg XoVA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f1-20020a5d64c1000000b0020cfd39a39csi309366wri.429.2022.05.13.18.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 18:29:59 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3DCB43F59EC; Fri, 13 May 2022 16:58:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377449AbiEMGuH (ORCPT + 99 others); Fri, 13 May 2022 02:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359479AbiEMGuC (ORCPT ); Fri, 13 May 2022 02:50:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9522A28F3; Thu, 12 May 2022 23:50:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3B1D9B82C44; Fri, 13 May 2022 06:50:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98F39C34100; Fri, 13 May 2022 06:49:57 +0000 (UTC) From: Greg Ungerer To: linux-m68k@vger.kernel.org Cc: geert@linux-m68k.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Greg Ungerer , kernel test robot Subject: [PATCH] m68knommu: fix undefined reference to `mach_get_rtc_pll' Date: Fri, 13 May 2022 16:49:52 +1000 Message-Id: <20220513064952.3610672-1-gerg@linux-m68k.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Configuring for a nommu classic m68k target and enabling the generic rtc driver (CONFIG_RTC_DRV_GENERIC) will result in the following compile error: m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl': time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll' m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll' m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll' "mach_set_rtc_pll" and "mach_get_rtc_pll" are only defined in the common MMU setup code, and are really only implemented in any meaningful way on classic M68K MMU enabled machines. So conditionally limit their use to MMU enabled classic M68K systems. Reported-by: kernel test robot Signed-off-by: Greg Ungerer --- arch/m68k/kernel/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/m68k/kernel/time.c b/arch/m68k/kernel/time.c index 340ffeea0a9d..c8b70b425ada 100644 --- a/arch/m68k/kernel/time.c +++ b/arch/m68k/kernel/time.c @@ -62,7 +62,7 @@ void timer_heartbeat(void) } #endif /* CONFIG_HEARTBEAT */ -#ifdef CONFIG_M68KCLASSIC +#if defined(CONFIG_M68KCLASSIC) && defined(CONFIG_MMU) #if !IS_BUILTIN(CONFIG_RTC_DRV_GENERIC) void read_persistent_clock64(struct timespec64 *ts) { @@ -140,7 +140,7 @@ static int __init rtc_init(void) module_init(rtc_init); #endif /* CONFIG_RTC_DRV_GENERIC */ -#endif /* CONFIG M68KCLASSIC */ +#endif /* CONFIG M68KCLASSIC && CONFIG_MMU */ void __init time_init(void) { -- 2.25.1