Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
IronPort-SDR: JfS5fipLNLHQRMavL4JEAiTCAzGGdtnLIHwiF5G64s9VuSbkEVPjNTtVuBfRXmDq0kxLapm7YT
 LcWFsGYUrzknTZBfNVJ17ayXmSZfKCGe7EWvJtDQ2XFbMU7yjSQx6bnqyZx0QGlPw9/9glGdjO
 hdbIM2sp/iDMxXgYctI6OS6YUpHLYy3wTGqV94e0+2/jRL272BDoT4jD/oujorGC7w5azG/TmH
 emCUL4U1NlKcgb3pSevwsJRsoulhKExS0gUKY/yyV7uD9KCkAnvatu2yJplNUzbwGyOFBON4Aw
 w4hzrF3FEepQt8iQzldvUJ2A
IronPort-SDR: GNBZd+P4W75G9FS1neDhiaqYs0tGStF36V0qjTYUStE9PPY/ToQfbBr1RbpcunRLOAgbd5TQkr
 QlEboewOy2v1IKRi8d7W1uv2JSEmoabR+mx882+WF2Hv2EZh0JhJfKkZoRYsFL04KKsydDI2M+
 6YIAOF2h+UzojO/tZQn9VqC5dC6Pw8DslVGeBZ2e+8LvRZma6EDAQEOhgWe6r+MJUOvRTBnJu9
 06aXWyKwa1UYXO6DvKlm7W2gqdTXtv0OBlFFAAMPjFQyUFNdLsv7MLaHztdjf+Qqvawfjon64v
 iqY=
WDCIronportException: Internal
Message-ID: <83ae3312-36ea-fa01-9b53-28818a04699f@opensource.wdc.com>
Date:   Fri, 13 May 2022 11:32:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH v3 08/23] ata: libahci_platform: Add function returning a
 clock-handle by id
Content-Language: en-US
To:     Serge Semin <fancer.lancer@gmail.com>,
        Hannes Reinecke <hare@suse.de>
Cc:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Rob Herring <robh+dt@kernel.org>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220511231810.4928-1-Sergey.Semin@baikalelectronics.ru>
 <20220511231810.4928-9-Sergey.Semin@baikalelectronics.ru>
 <0732a28c-579e-52f8-21ad-653fd9a10aa2@suse.de>
 <20220512142607.u2kls35pevnjsjjh@mobilestation>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220512142607.u2kls35pevnjsjjh@mobilestation>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2022/05/12 16:26, Serge Semin wrote:
> On Thu, May 12, 2022 at 08:32:37AM +0200, Hannes Reinecke wrote:
>> On 5/12/22 01:17, Serge Semin wrote:
>>> Since all the clocks are retrieved by the method
>>> ahci_platform_get_resources() there is no need for the LLD (glue) dri=
vers
>>> to be looking for some particular of them in the kernel clocks table
>>> again. Instead we suggest to add a simple method returning a
>>> device-specific clock with passed connection ID if it is managed to b=
e
>>> found. Otherwise the function will return NULL. Thus the glue-drivers
>>> won't need to either manually touching the hpriv->clks array or calli=
ng
>>> clk_get()-friends. The AHCI platform drivers will be able to use the =
new
>>> function right after the ahci_platform_get_resources() method invocat=
ion
>>> and up to the device removal.
>>>
>>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>>>
>>> ---
>>>
>>> Changelog v2:
>>> - Fix some grammar mistakes in the method description.
>>> ---
>>>   drivers/ata/libahci_platform.c | 27 +++++++++++++++++++++++++++
>>>   include/linux/ahci_platform.h  |  3 +++
>>>   2 files changed, 30 insertions(+)
>>>
>>> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_pla=
tform.c
>>> index 3cff86c225fd..7ff6626fd569 100644
>>> --- a/drivers/ata/libahci_platform.c
>>> +++ b/drivers/ata/libahci_platform.c
>>> @@ -94,6 +94,33 @@ void ahci_platform_disable_phys(struct ahci_host_p=
riv *hpriv)
>>>   }
>>>   EXPORT_SYMBOL_GPL(ahci_platform_disable_phys);
>>> +/**
>>> + * ahci_platform_find_clk - Find platform clock
>>> + * @hpriv: host private area to store config values
>>> + * @con_id: clock connection ID
>>> + *
>>> + * This function returns a pointer to the clock descriptor of the cl=
ock with
>>> + * the passed ID.
>>> + *
>>> + * RETURNS:
>>> + * Pointer to the clock descriptor on success otherwise NULL
>>> + */
>>> +struct clk *ahci_platform_find_clk(struct ahci_host_priv *hpriv, con=
st char *con_id)
>>> +{
>>> +	struct clk *clk =3D NULL;
>>> +	int i;
>>> +
>>> +	for (i =3D 0; i < hpriv->n_clks; i++) {
>>> +		if (!strcmp(hpriv->clks[i].id, con_id)) {
>>> +			clk =3D hpriv->clks[i].clk;
>>> +			break;
>>> +		}
>>> +	}
>>> +
>>> +	return clk;
>>> +}
>>> +EXPORT_SYMBOL_GPL(ahci_platform_find_clk);
>>> +
>>>   /**
>>>    * ahci_platform_enable_clks - Enable platform clocks
>>>    * @hpriv: host private area to store config values
>>> diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platf=
orm.h
>>> index 49e5383d4222..fd964e6a68d6 100644
>>> --- a/include/linux/ahci_platform.h
>>> +++ b/include/linux/ahci_platform.h
>>> @@ -13,6 +13,7 @@
>>>   #include <linux/compiler.h>
>>> +struct clk;
>>>   struct device;
>>>   struct ata_port_info;
>>>   struct ahci_host_priv;
>>> @@ -21,6 +22,8 @@ struct scsi_host_template;
>>>   int ahci_platform_enable_phys(struct ahci_host_priv *hpriv);
>>>   void ahci_platform_disable_phys(struct ahci_host_priv *hpriv);
>>> +struct clk *
>>> +ahci_platform_find_clk(struct ahci_host_priv *hpriv, const char *con=
_id);
>>>   int ahci_platform_enable_clks(struct ahci_host_priv *hpriv);
>>>   void ahci_platform_disable_clks(struct ahci_host_priv *hpriv);
>>>   int ahci_platform_enable_regulators(struct ahci_host_priv *hpriv);
>>
>=20
>> Where is this function being used?
>=20
> It will be used in the DWC AHCI SATA driver and can be utilized in the
> rest of the drivers to simplify the available clocks access.
> BTW Damien asked the same question in v1. My response was the same.

Please squash this patch together with the patch introducing the first us=
e of
this function.

>=20
> -Sergey
>=20
>>
>> Cheers,
>>
>> Hannes
>> --=20
>> Dr. Hannes Reinecke		           Kernel Storage Architect
>> hare@suse.de			                  +49 911 74053 688
>> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnbe=
rg
>> HRB 36809 (AG N=C3=BCrnberg), GF: Felix Imend=C3=B6rffer


--=20
Damien Le Moal
Western Digital Research