Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp984414iob; Fri, 13 May 2022 18:35:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxDafvY6IH0nd+TpPpjU75ZQ+EAjHZ6v/VIverpt7QM80xeJkmF5XMyyDQGOKEmUbfMBbg X-Received: by 2002:a05:600c:4ed1:b0:394:8352:3ea1 with SMTP id g17-20020a05600c4ed100b0039483523ea1mr6673267wmq.153.1652492113889; Fri, 13 May 2022 18:35:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652492113; cv=none; d=google.com; s=arc-20160816; b=yiLPWTls09dK+x9xoVZbDdAFGramk0j1pUfggQJZKDPd+jHyOsU+Ds4BRGoq7GXKKR AgHu+Nhc+EAQx+TpJyKlbr7Acvt9H8I7FeLbKp3divqfGIY1yuDpotMUDTRXUGGtDOVx jMpXHmeItpF8F8I1k5ZQseuY0rLdKGyo3pyGDX0mbOLSfVR2VFgXkxT9+qBK8HoWyOID /w8LPIHSasq1G38Gz7mOuNm2v86tGtvYZKmaKTWN+c5g4VXZnxiZV6sXa4h5yeg55LFJ Rwd297YO0JpNk7g1FpHer4rhaoxiLDUVAU7Ud4JcvIlXlp+5rwfiIzs/SycuGoAbbpSZ NyOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=iEa/8mAzzO9RlCYIla5k70SI1Iglg8mw5NOlpxJMReg=; b=lui8ls5w8pNaHpJ0mcX2T4g0IITCNVAZnJZAcWhEfSs6o5QePI4MgQ64UoAgOYZADP EtbUjaqPqHOEh87DD5MNertRttvVII5O2Nsx2y/sFyG9a0qPRg26d+nJOVLs/XBP9NUO aGy5eyd7HSD9wvrAPCeI/Tfxr4QbIZo4y+/cIdyk/sCJh18JGvn22QmVlRDw3cYhZSXg msmYkESV/7ZAkGCVf5GHDmlKEo5zo0WeppHKUL1t6q0sTSGVJapEIlXCAdh/3v4qxFTl aWd6G1wd09iT81yioXhFpvGZxm6U98sa5nPZg+ieKSIaLIAIZBJefFigs5R+xjmdW5gv 9MuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NaCvW4b1; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d9-20020a05600c3ac900b0038e7c5c1ad9si3695511wms.76.2022.05.13.18.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 18:35:13 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NaCvW4b1; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4D30740BE5E; Fri, 13 May 2022 17:02:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356543AbiELQgl (ORCPT + 99 others); Thu, 12 May 2022 12:36:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356533AbiELQf7 (ORCPT ); Thu, 12 May 2022 12:35:59 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1193248E2 for ; Thu, 12 May 2022 09:35:58 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id d5so8040418wrb.6 for ; Thu, 12 May 2022 09:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iEa/8mAzzO9RlCYIla5k70SI1Iglg8mw5NOlpxJMReg=; b=NaCvW4b10j7Xtxd2Yrgzm1tQkfxe+qxD9X9km6qswM7R5iviuD+vgUXO/gH9LW5YQ4 MLI5HZxCyI8HcHDS240rMWOuEAfzQZ/cTa4nsQK4a8QfD4WHNpbJ5iO6lA0yLQwpwEZ0 eUOs1Ui2jlWss3IsKQmh3zsj79p5rz1POnbv8G0aNVjWXKxpaYgiu4eFY3LbNvi9mMv5 YA8OjL2p/sBfGY5yfuy0BUR0O2YlLrIXJebV+xkfppf5bpmMUvE1U1QkR3Y6eifRf4cK 1o0eG4n3HkJxG50Vd/PQWKs8o39BKS/pyVi/KfedPTGZL5vACqA1/KVgo87s9Q7yNx0y 97Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iEa/8mAzzO9RlCYIla5k70SI1Iglg8mw5NOlpxJMReg=; b=jdtJIoDByKPRpXv+wElCCrVzrHl4k4wbxMopNMOzGlUMLBq441g7ae7qfZ6mzC19gU GqagthSp7JHglgn++AWehdXyBC1C0hKxqsMcyxdQEzEK2e3/dX+fL9kSvYaj34fBssX8 81q4km8U7C57MAGHF77pg8630VqEIlbWgrGH8MHEz29AIPMYQTUT2YsRgRKYxesR4NBO BxE4LrvYAcVTY3ESvR+7vnam49IG4ybgSOWbHQ2Vnz7NYxUWJ4lVUHXICpdjPb2aTRMC 8GRDlXCxWX9yGyyr2Wi7Gjo/MXhqYL9+uBkyzgaiMVReO5pR6QBp9XTSz5kgU1gahvwF iatQ== X-Gm-Message-State: AOAM5309iMf75nj6ANPvjFslp7I9YPGnHXJoG8CnE2hmmZ8f1tgg5zUL 56UHEs1uPR8BY8yG3pn57TNSbQ== X-Received: by 2002:adf:ed8f:0:b0:20a:e2a7:7201 with SMTP id c15-20020adfed8f000000b0020ae2a77201mr463281wro.26.1652373357971; Thu, 12 May 2022 09:35:57 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:253e:ae0a:544b:2cb1]) by smtp.gmail.com with ESMTPSA id j25-20020adfa799000000b0020c5253d8dbsm21814wrc.39.2022.05.12.09.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 09:35:56 -0700 (PDT) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, parth@linux.ibm.com Cc: qais.yousef@arm.com, chris.hyser@oracle.com, valentin.schneider@arm.com, patrick.bellasi@matbug.net, David.Laight@aculab.com, pjt@google.com, pavel@ucw.cz, tj@kernel.org, qperret@google.com, tim.c.chen@linux.intel.com, joshdon@google.com, Vincent Guittot Subject: [PATCH v2 4/7] sched/core: Add permission checks for setting the latency_nice value Date: Thu, 12 May 2022 18:35:31 +0200 Message-Id: <20220512163534.2572-5-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220512163534.2572-1-vincent.guittot@linaro.org> References: <20220512163534.2572-1-vincent.guittot@linaro.org> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Parth Shah Since the latency_nice uses the similar infrastructure as NICE, use the already existing CAP_SYS_NICE security checks for the latency_nice. This should return -EPERM for the non-root user when trying to set the task latency_nice value to any lower than the current value. Signed-off-by: Parth Shah [rebase] Signed-off-by: Vincent Guittot --- kernel/sched/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 036bd9ff66e9..2c0f782a9089 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7340,6 +7340,10 @@ static int __sched_setscheduler(struct task_struct *p, return -EINVAL; if (attr->sched_latency_nice < MIN_LATENCY_NICE) return -EINVAL; + /* Use the same security checks as NICE */ + if (attr->sched_latency_nice < p->latency_nice && + !capable(CAP_SYS_NICE)) + return -EPERM; } if (pi) -- 2.17.1