Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7427ccc1-c830-56c1-1577-dee5afff3809@kernel.dk>
Date:   Thu, 12 May 2022 06:21:19 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] io_uring: Fix incorrect variable type in
 io_fixed_fd_install
Content-Language: en-US
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220512120511.4306-1-wanjiabing@vivo.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220512120511.4306-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/12/22 6:05 AM, Wan Jiabing wrote:
> Fix following coccicheck warning:
> fs/io_uring.c:5352:15-24: WARNING: Unsigned expression compared with zero: file_slot < 0
> 
> 'file_slot' is an unsigned variable and it can't be less than 0.
> Use 'ret' instead to check the error code from io_file_bitmap_get().
> 
> And using bool to declare 'alloc_slot' makes the code better.  

Thanks, I'm going to fold this one in.

-- 
Jens Axboe