Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 13 May 2022 13:46:42 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <vincent.mailhol@gmail.com>
Cc:     Max Staudt <max@enpas.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220513114642.77jfdscjwzgyiwm3@pengutronix.de>
References: <20220512182921.193462-1-max@enpas.org>
 <CAMZ6Rq+BwL1NPTLtC5sQAd4z1Kc1TFJPPoW-i+0RZ5dnFaWYiw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="m3okyqmyt2uyv2he"
Content-Disposition: inline
In-Reply-To: <CAMZ6Rq+BwL1NPTLtC5sQAd4z1Kc1TFJPPoW-i+0RZ5dnFaWYiw@mail.gmail.com>
Precedence: bulk


--m3okyqmyt2uyv2he
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 13.05.2022 11:38:31, Vincent Mailhol wrote:
> > +static void elm327_parse_line(struct can327 *elm, size_t len)
> > +{
> > +       lockdep_assert_held(&elm->lock);
>=20
> You are using many of those lockdep_assert_held(&elm->lock);
>=20
> I guess you put them for debug purpose and probaly some of those can
> be removed (if you see a genuine risk at some places, then OK to keep
> as a safety net, but a bit of clean up can be done here, I think).
>=20
> This comment applies to all use of lockdep_assert_held().

These statements document that the code must be called with the lock
held. They optimize away if lockdep is not enabled. Better keep them in
place.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--m3okyqmyt2uyv2he
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJ+RSAACgkQrX5LkNig
012MwwgAm4xVfAxO42VZQ8ps/XQLvThpyouR3oifOiYnXEGYdIaIqDgPWxvWBJIV
wmj8CBnW2CePSkFQofw8tkT1RH1wSyLf8vPzvOPpXkFAlLT5PbAq86cfeyRxyR8L
0jPsGPrRYnQtYQ/tLMqPaCOVypsndd+kAYZGSzRkvzTiroKtgeTNbKZUYwTjvcbG
rcbFsPNNJjizATaINWrR+C9irJ6E3KPixRAI/3/dn4Xt6uVEJweGGHzm/sciyczz
1TvdOsU3f0rRJ3Xh0zbc9dQRWl5npYUaA2CMBeZu9rm/J5amgmxf2EA9YTtc0YiW
7Wz3qq3BmSoUKqmoZCca4aSwCKilPA==
=K50O
-----END PGP SIGNATURE-----

--m3okyqmyt2uyv2he--