Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <093ebfa2-9584-ab89-9d52-f21b2841ec56@oracle.com>
Date:   Thu, 12 May 2022 11:10:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v8 2/7] crash: prototype change for
 crash_prepare_elf64_headers
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
References: <20220505184603.1548-1-eric.devolder@oracle.com>
 <20220505184603.1548-3-eric.devolder@oracle.com>
 <c26a28cc-9955-9724-3271-602c9bddf8a2@redhat.com>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <c26a28cc-9955-9724-3271-602c9bddf8a2@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3lvNHhudzh3ZUhxWSthZ3FPd1ZzNDJrWkdTeXhjdWZNV3lCQVpud2dFa2o1?=
 =?utf-8?B?S2J1cUxxUWxwV2NreEZpdEVJQWZRMGFaMCtDL3BCS0ZNbVJpRk1EV1VnRjhz?=
 =?utf-8?B?bXEycUR1aTBvRWV6RGFBYzcwQTQybjRnckRIUkxGaWRPSzQ1WWtOeThzNmtr?=
 =?utf-8?B?dVRMR2ZncnZUYjhvM2lPT2V4a3lnQ083M0FCYzU1NFIycFdrdy9KL1ZJOC94?=
 =?utf-8?B?K3dqNzc2ZlpDSUJVT2szNEkvclp2VFZ6aWNFVlVJMWUxVEIzUXJ4NkpwVG0y?=
 =?utf-8?B?TVFOUjdYbnF0MW92Vkk1eG1ETENiUkhHd1MzZ2VOSmxYbGxQR3d6K0pWc1dV?=
 =?utf-8?B?QWRhRmdQYmh2b0NqanV3enBnZkt3Y09jTTlYeDY4WHJmVzhMNGtNbnE4SEg4?=
 =?utf-8?B?Zk9UaldodU1BTk9nakMreVVaTmczbUdRWnhFbUtCU01CNVMyU2Znc1BZTWJ0?=
 =?utf-8?B?d2kwTUhtWXNFRTdGbDFBQWVwbjFDRWhudVYxRHBiQ2VVdzMxL25mNXpRdExR?=
 =?utf-8?B?bERNcUpqbWVvQW1aVVdDeVRPVWw5eUtDWkxkZFlYamlMclBRV1laWlQ4Z01z?=
 =?utf-8?B?NUZSV2dXY3M3NU4xRjd0ZVNwUWFqR1R2c2FYRFd1YjJOV2ZQQy9CQ2JFYzFp?=
 =?utf-8?B?SHMzZ0U2QnY4NFhRaURDL2N6RnR5dU9PTUFhcEtIek1tdWQ2UmRCWjg3ME03?=
 =?utf-8?B?amVtYTlxMTIzZDRBNzBwSjE3WDV2c0c2Ui81YVdPaFV3b1pYSzltUmVyMFZM?=
 =?utf-8?B?Vi9QN3JHRmxqWENWeHFnRThWQ2k5Sk9DeE1JWThDYVI5akE0czJEQ3oySEEr?=
 =?utf-8?B?MGY0MWM0bDlaLy9KajduZndKeXJHRmxJRmxtcG9STndUQURlakVPbFRRaFdS?=
 =?utf-8?B?TGsrV2wwVG12djJjSEFoMTNSTy9GVG4ydEJDeWI1ejMwaVM0SWFBSTQvbzhs?=
 =?utf-8?B?ekxhYlN5OXE5N3ZkSU9WeHFCdnYyak5Da1VvM2EwWFpKQmNob3UxeGxJSk4v?=
 =?utf-8?B?Y3JVc3U2UXNGcVI4YlUzNTJPVC83dGIzbGZpbG1mOVJsRmhsTzR6Q2lrYVZs?=
 =?utf-8?B?QUhtdERiWXRrZHhnSVZoaVliWFhMNnl4RzRCam9HRVZmaGZQRVVuVUFPNkg1?=
 =?utf-8?B?VUh1NzNuKy80dnYyeElMK04zZkpIWFMyb0NvNU9xSmsranBQVmhoSXpwdjJQ?=
 =?utf-8?B?WmVmSkRTYm90YVA0TXVzR3MxeU9rZU96cEZTeW1xSXZrSDk1TXlDNkQvZU4z?=
 =?utf-8?B?TjRjK0UxNU9jYVI2VGJiS2s5YjMrcTg2dGdZa21pNTFHdTVBZlVtcmpUQndT?=
 =?utf-8?B?bXdPbmpaZmRrVlBKbWRiVVB6ZUswNy85TnczMjJ4dlpWUEQzc3cvODE5MmRS?=
 =?utf-8?B?N0Y1SnYvMVkyaEN0L1VBeG5yY2Ztd05pdTFySjl6YWM5dE16OENrb0U5S1RI?=
 =?utf-8?B?YUYxbUREdUJSc1VpSGJ0M0hOUElnVjV4RjhkQ1hzdkVqVTBrWWkwYzZmb0xy?=
 =?utf-8?B?OTRJZzVlY1NYakhZbzVxU05TaHAyc2hNZHB1OTBxTWlkeTRPd2FBOXJQMUZi?=
 =?utf-8?B?R1FzcnVaZXB5K1NMN0x5NHlDS0N5TEZWUy9PLzBtSWt5L1IxUFdPWSswc2d2?=
 =?utf-8?B?anRleldaczgrR1JlM0R1UXRlNkwvT2xoYXc2bUF2L2hJTVZ0UjN0azRzT2VD?=
 =?utf-8?B?bXdQNHAwMU9aTGhKbjRTSFlxUDl2QVpQZW02ZzNnSUc1SjJQdUVxMjVFSk9k?=
 =?utf-8?B?TThNdklrcGlFdENmSGJlVm1GNmgrMDZUeTlpdDlPZWVQVjhVampQU09pTTZr?=
 =?utf-8?B?SmEwZFdSR09xaThCSEcwL2ZJL1RZUmJ4ZUM0cXpvZWVwakQ2Z1BjcmJ3NWhp?=
 =?utf-8?B?NzV0L2VWWGc0VkN6L0VKM1hKdGZkcWxIaTh1clNqaTl1b1ZqbFpSYlJnWGRY?=
 =?utf-8?B?WmFiM3oySEprYzRMYUVvOUswSDI4eDUydS9OYkNXY0ZLbjMwcHJCd05iQXVq?=
 =?utf-8?B?ZU1RczhDSEtlNzM0am9kUnJadWtpTmtNSjZpdktZdlZuV2M5Q2JpMXBJRVhM?=
 =?utf-8?B?SUtRUHJkSEcrNU1QcW5KZVp3VGk3ellmR2oyT2tEZWNHeTFaelo4RktLaUhj?=
 =?utf-8?B?QUJGeHpSWWhFeE9oN2hLV0k2Smw1YVJvc2t2aU5KOVplbWRMY3VMNmtWcFZu?=
 =?utf-8?B?a3FBN1M1ZFA3alowWlJmNFlZNFh5TUcxZStWNVkwZVhvMUF2dGQ2cXZjcGwx?=
 =?utf-8?B?RFdrcERyV0U1K3VCRzB3WmNLM2Rpc1BScUJabzVpWllMdnFvTmVTVEg3a3Bk?=
 =?utf-8?B?aGtvVGlGRWsyNGlrZjd1Q3pWbFpGOHFUMDlhYXZtWWtBbkRJMjV3WWRUQ3JR?=
 =?utf-8?Q?Ps1YZLJvqiP2oSVpihDy0WxeRlWvIgRnb+G/4?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37baca51-35f9-4bd4-7004-08da3431e6ea
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 16:10:16.1636
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JVOB3oaMzxCRFWvpoZ52dWowKdIpX4z9ldaivsqMybcnwICrpAJGLomLGgEl8nMCDsuHYxO1a4SrgnP/j/JcHQcwm3PGQ2AnGoYz5vNIYKE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5375
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-12_09:2022-05-12,2022-05-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205120076
X-Proofpoint-ORIG-GUID: DONibuQf_tLnJ4WPeoe_NpLuaX4d_97A
X-Proofpoint-GUID: DONibuQf_tLnJ4WPeoe_NpLuaX4d_97A
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/12/22 03:42, David Hildenbrand wrote:
> On 05.05.22 20:45, Eric DeVolder wrote:
>>  From within crash_prepare_elf64_headers() there is a need to
>> reference the struct kimage hotplug members. As such, this
>> change passes the struct kimage as a parameter to the
>> crash_prepare_elf64_headers().
> 
> You should make it clearer that the hotplug members will be added by
> successive patches.
I've tweaked the commit message to indicate as such.

> 
>>
>> This is preparation for later patch, no functionality change.
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>> Acked-by: Baoquan He <bhe@redhat.com>
> 
> Acked-by: David Hildenbrand <david@redhat.com>
Thank you!
eric

>