Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220510131136.1103-1-mario.limonciello@amd.com> <CAPpJ_efn1YiLRtbhNwDEr8j+jJfZrHBM9fukDJpuH0czJpgRTQ@mail.gmail.com>
In-Reply-To: <CAPpJ_efn1YiLRtbhNwDEr8j+jJfZrHBM9fukDJpuH0czJpgRTQ@mail.gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 12 May 2022 16:58:03 +0200
Message-ID: <CAJZ5v0iUM0oYxFnRZ9g_UGOY43v9ori=pdO2FWVO+L8hKKYfAw@mail.gmail.com>
Subject: Re: [PATCH] ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default
To:     Jian-Hong Pan <jhp@endlessos.org>,
        Mario Limonciello <mario.limonciello@amd.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, May 11, 2022 at 4:40 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
>
> Mario Limonciello <mario.limonciello@amd.com> 於 2022年5月10日 週二 下午9:11寫道：
> >
> > ASUS B1400CEAE fails to resume from suspend to idle by default.  This was
> > bisected back to commit df4f9bc4fb9c ("nvme-pci: add support for ACPI
> > StorageD3Enable property") but this is a red herring to the problem.
> >
> > Before this commit the system wasn't getting into deepest sleep state.
> > Presumably this commit is allowing entry into deepest sleep state as
> > advertised by firmware, but there are some other problems related to
> > the wakeup.
> >
> > As it is confirmed the system works properly with S3, set the default for
> > this system to S3.
> >
> > Reported-by: Jian-Hong Pan <jhp@endlessos.org>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215742
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > ---
> >  drivers/acpi/sleep.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> > index c992e57b2c79..3147702710af 100644
> > --- a/drivers/acpi/sleep.c
> > +++ b/drivers/acpi/sleep.c
> > @@ -373,6 +373,18 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
> >                 DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
> >                 },
> >         },
> > +       /*
> > +        * ASUS B1400CEAE hangs on resume from suspend (see
> > +        * https://bugzilla.kernel.org/show_bug.cgi?id=215742).
> > +        */
> > +       {
> > +       .callback = init_default_s3,
> > +       .ident = "ASUS B1400CEAE",
> > +       .matches = {
> > +               DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > +               DMI_MATCH(DMI_PRODUCT_NAME, "ASUS EXPERTBOOK B1400CEAE"),
> > +               },
> > +       },
> >         {},
> >  };
> >
> > --
> > 2.34.1
> >
>
> Tested-by: Jian-Hong Pan <jhp@endlessos.org>

Applied as 5.19 material, thanks!