Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <8babc23b-5e24-f662-6c4a-eb1c30e0e6da@quicinc.com>
Date:   Wed, 11 May 2022 12:51:36 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v4 03/14] modpost: split the section mismatch checks into
 section-check.c
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
CC:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-modules <linux-modules@vger.kernel.org>,
        linux-s390 <linux-s390@vger.kernel.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        "Sami Tolvanen" <samitolvanen@google.com>,
        clang-built-linux <llvm@lists.linux.dev>
References: <20220508190631.2386038-1-masahiroy@kernel.org>
 <20220508190631.2386038-4-masahiroy@kernel.org>
 <CAKwvOd=LR=UNOeWJDmM-McJ=FrCWTo8w1ox+KGMQCwCVpiUyFg@mail.gmail.com>
 <CAK7LNARGNEDzPPUsPjDXsXUUUPSFK2erQRuyPocR_v5hTYRihg@mail.gmail.com>
 <CAKwvOdmK4oH0t8Q6F19sWKX1fT=AgS=kfvn05FT01HffLJwgMQ@mail.gmail.com>
 <CAK7LNAR5preB59HJH1-F_ZfEmoF3N8b9z4eRhYzsEVwu_XUH4Q@mail.gmail.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <CAK7LNAR5preB59HJH1-F_ZfEmoF3N8b9z4eRhYzsEVwu_XUH4Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/11/2022 12:27 PM, Masahiro Yamada wrote:
> On Thu, May 12, 2022 at 3:48 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
>>
>> On Mon, May 9, 2022 at 11:57 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>
>>>>> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>>>>> index a78b75f0eeb0..e7e2c70a98f5 100644
>>>>> --- a/scripts/mod/modpost.c
>>>>> +++ b/scripts/mod/modpost.c
>>>>> @@ -31,7 +31,7 @@ static bool external_module;
>>>>>   /* Only warn about unresolved symbols */
>>>>>   static bool warn_unresolved;
>>>>>
>>>>> -static int sec_mismatch_count;
>>>>> +int sec_mismatch_count;
>>>>
>>>> ^ this should go in modpost.h if it is to be used in two translation
>>>> units, rather than forward declaring it in section-check.c.  You did
>>>> this for the functions.
>>>
>>>
>>> Sorry, I do not understand.
>>>
>>>
>>> In modpost.h, I put the declaration:
>>>
>>>    extern int sec_mismatch_count;
>>>
>>> If I moved it to the header without 'extern'
>>> I would get multiple definitions.
>>
>> Yeah, you need to _declare_ it w/ extern in the header, then _define_
>> it in one source file.
>>
>> That way, if the type ever changes, the sources will agree on type in
>> all source files. You will get a redefinition error if the definition
>> changes the type of the variable since the last declaration.
>>
>> What you're doing is forward declaring, which works, and is a common
>> pattern for (bloated) C++, but is less type safe than sharing a single
>> common declaration between multiple source files via a single common
>> shared header. (Sorry I didn't respond before you sent v5)
> 
> Sorry, I still do not understand your suggestion.
> 
> 
> Could you provide me with a code diff
> showing how to do this better?

I think you are doing exactly what he's asking for:
declare it with extern in the header (modpost.h change)
define it in one source file (modpost.c change)