Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 12 May 2022 09:18:17 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Mikhail Zhilkin <csharper2005@gmail.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        NOGUCHI Hiroshi <drvlabo@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Karim <Karimdplay@gmail.com>, M <x1@disroot.org>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: add support for Sercomm partitions
Message-ID: <20220512091817.25c653e4@xps13>
In-Reply-To: <10ce5bf1-bf12-b028-49cb-a3f1999f9a07@gmail.com>
References: <20220329122016.4122899-1-csharper2005@gmail.com>
        <20220330100958.57dc4d61@xps13>
        <ede9e050-3b60-ba0e-c626-044f7825adb7@gmail.com>
        <20220511091643.064f9d13@xps13>
        <10ce5bf1-bf12-b028-49cb-a3f1999f9a07@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mikhail,

csharper2005@gmail.com wrote on Wed, 11 May 2022 23:36:18 +0300:

> On 5/11/2022 10:16 AM, Miquel Raynal wrote:
>=20
> >>>> This is essentially the same code as proposed by NOGUCHI Hiroshi
> >>>> <drvlabo@gmail.com> here:   =20
> >>> I would credit Hiroshi with a Suggested-by at least   =20
> >> I read submitting patches rules again and thought that Signed-off-by is
> >> suitable for this case. Is this ok? =20
> > Either you take his work almost like it is and he must be the author
> > *and* the first signed-off-by line, or you take the authorship if you
> > think you did enough modifications to the code and in this case you can
> > either credit him with a suggested-by before your signed-off, or you
> > can credit him with a co-developed-by + his signed-off and then yours. =
=20
>=20
> Thank you for clarification! My modifications were quite small:
>  - Remove redundant braces and logical NOT operator
>  - Define pr_fmt
>  - Replace kcalloc by kzalloc
>  - Use of_get_child_count() and alloc big enough array before the
>    for_each_child_of_node()
>=20
> Therefore, I prefer to keep the authorship of the original author (NOGUCH=
I Hiroshi).=20
>=20
> Patch is really good and was successfully tested on the hundreds of Serco=
mm devices (5.4, 5.10, 5.15 Kernel). My motivation for upstreaming is work =
under official support for these devices in OpenWrt.
>=20
> What are the next steps from my side in this case? Should I wait for revi=
ew of this patch here (Link: https://lore.kernel.org/linux-mtd/202205101626=
55.21011-1-csharper2005@gmail.com/T/#u
> ) or do I need to do something additionally (for example, send updated se=
t v5 with Acked-by from Krzysztof in the first patch)?=20
>=20
> And sorry for the many questions... I haven't fully mastered the Linux ch=
ange management process and best practices yet.

We are used to incremental changes, so please send another version with
the tags collected, the changes that I requested regarding the
authorship and we'll see what happens to the next version.

Thanks,
Miqu=C3=A8l