Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Ian Abbott <abbotti@mev.co.uk>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guo Zhengkui <guozhengkui@vivo.com>,
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com
Subject: [PATCH] drivers: comedi: replace ternary operator with min()
Date:   Fri, 13 May 2022 15:16:06 +0800
Message-Id: <20220513071608.49047-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RSBRgIGAsH7Wpw3lXWhHPS/xWUpenFm9aOtuQHZhAXh4Hc8WS9dFiragyptW?=
 =?us-ascii?Q?PDOHWflUzLApiXW4MWRlKaXDTscyTeHaAgD4kmeqTrMnjDMzKCSGZ67nd1L6?=
 =?us-ascii?Q?PfDvtwAwuHpDbfuNYdBZC38kY5ZxJ4kDbGqmF+NlbcXd3HJLGZg7yacz9nwt?=
 =?us-ascii?Q?FONHrHMhcMbhKdOxE/5BT2Kf4hx+d8Stu0HK5jh0EbANPoy3F3Fo3qzaakoI?=
 =?us-ascii?Q?T6RVy2QO5XO2oQj39Vz/h0pQE23CEzyK1iKJhMl1K0luL03uLdplhBkI54Qv?=
 =?us-ascii?Q?d+Z/y/CiEYc5PjtJQ/HG9uI/HFebQKc8MlCxHx4d8JosmnUjdi2B+fSu4RhQ?=
 =?us-ascii?Q?viA1tUW/8NYfPpaxxb/Vv+GX+VXpncTIgRD/3DNer1fHGBCf9/c7C4w9sO2i?=
 =?us-ascii?Q?OjAOGmgyjaGCSYWts9XVsM5G8xLuAoZA/gqDJ9Cy4AlPrXCwOn9F5MkXO6BR?=
 =?us-ascii?Q?QXIOdKuEUltcbPOQPbDYgYv2L2BwrxkDnZqaVBkLu35QmgeGu2xvhSbLywGC?=
 =?us-ascii?Q?B8vZss+2pxpezqGA5g8Awlt/ubP/kSjIvqe89eVBCBheTGSLrmdSzSfTl2ZH?=
 =?us-ascii?Q?G5sXAPLmmzulk3cGn1Udj+NHwhC1yzmZNMKITcLE4ErfIKGLy6ih5Y6Kv1pX?=
 =?us-ascii?Q?7e4zARH7HMJFfUlrweomjwCe+wol8tN0Fy7cSzY8Al1mOBchd4yYbqot9Kfv?=
 =?us-ascii?Q?h2iDNDaKcMmwt2ITeEZ4bnG7Kk8YiluaOWlWo6apcSy/cpFzG2IlTDfTeAcV?=
 =?us-ascii?Q?TS2YXTCRS20CxWB8tB/i0439v8AD6lneSqO6+1YwWaTym0Hs4Yx5m9jPAv8h?=
 =?us-ascii?Q?GbqaH7eX39bq1ewS+N9Mxb+cC9crZbvGIt57znrUVJwio5WYE/65f3Ck7p6V?=
 =?us-ascii?Q?NAr2loMvPKyh3n5Bsm4+MBChpgdK/zuEz0Ga7dDZVjgTPy1EB+f9myFI9uDL?=
 =?us-ascii?Q?qAMK/wLwaRhBsVizB0mkAvqTF+GnHB03sv1gB3HmPsBmk023SRaBfsw22AqI?=
 =?us-ascii?Q?tcoyZ978RxrKdXa91E7lerVeHuuisAQPM6ONpW1qZwAgqqh7iu7JiFh38VrP?=
 =?us-ascii?Q?MUMOZyKnKw2UmguD+Bh+1ISBLaKkUlcR1vuUjnsXDInLYvb0Ivevr6FCLSzG?=
 =?us-ascii?Q?rq1M+5zn4aVtPDjPBcaoEUEuNhUMxnbOHIT6FIi0P8BSKR2G+1OY3MrcgPp8?=
 =?us-ascii?Q?Fa19jdGEYaG2VM4n4djbAvRXcgCT6SlYnJl9O+azW+4fxjxlQKqyY5sXDxPh?=
 =?us-ascii?Q?VkY2KYUjmZWNhyPsZFIipAjU13fmxNEpHWQooBHmIz5gyLTqqFKLNdyxjqII?=
 =?us-ascii?Q?UXPp6t+LTKHkAXdTwrWZcIYuXJWfK7Bp8nhR2KwzpBKlL7HQ4i9e4zLQhlwF?=
 =?us-ascii?Q?aE8//cCZOOQ8ngkykUbW8/D3KgiosH/eiitahtvoMsKGJAFcT6Dg3FsaY94e?=
 =?us-ascii?Q?G/nghUGD5RcN0+o9AfKu3x2vRnwkh/OQUgkk10pfKX59JLvxDh7scOpvr66B?=
 =?us-ascii?Q?BjjtesCWSovNFP5zpItcT830vq8UpTcFCk8UuQX0589nqkbtfcihC4NtebFo?=
 =?us-ascii?Q?T/FRKchfVaj+p+E8G6OAXDuUX4iNfp+hIvlmjhwthJXYeFUaqe/pyi9JEV/Q?=
 =?us-ascii?Q?40mO9MnFqUj9M1onDrFEATHrZwNDUaSoaSv4FctOsY+bNmX5zBYdgxEYEs5h?=
 =?us-ascii?Q?7o75YGyYt8aXbIHbUj6EtdCYv4GsoOEE5kgOJ3m0K0kdUf9XFpgwG0gD8bMs?=
 =?us-ascii?Q?MMCDv7ZBvQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cf72dc1-d09d-4aaf-ce67-08da34b082af
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 07:16:34.0919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bNMymhPX99C4zOTgSJ7ogYuS29JsyQJfYgQnq8pDTtZpDtgW2DzpGfAhcqQYOElU5XibrE5M4I3FRIsJiEz9KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4316
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix the following coccicheck warning:

drivers/comedi/drivers.c:857:12-13: WARNING opportunity for min().

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/comedi/drivers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/comedi/drivers.c b/drivers/comedi/drivers.c
index 8eb1f699a857..d4e2ed709bfc 100644
--- a/drivers/comedi/drivers.c
+++ b/drivers/comedi/drivers.c
@@ -854,7 +854,7 @@ int comedi_load_firmware(struct comedi_device *dev,
 		release_firmware(fw);
 	}
 
-	return ret < 0 ? ret : 0;
+	return min(ret, 0);
 }
 EXPORT_SYMBOL_GPL(comedi_load_firmware);
 
-- 
2.20.1