Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 12 May 2022 01:42:26 -0700
From:   Saeed Mahameed <saeedm@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Kees Cook <keescook@chromium.org>,
        Leon Romanovsky <leon@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>,
        Coco Li <lixiaoyan@google.com>,
        Tariq Toukan <tariqt@nvidia.com>, netdev@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH] fortify: Provide a memcpy trap door for sharp corners
Message-ID: <20220512084226.id7jghqbadluze5k@LT-SAEEDM-5760.attlocal.net>
References: <20220511025301.3636666-1-keescook@chromium.org>
 <20220511092417.3c1c60d9@kernel.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20220511092417.3c1c60d9@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MeglJ2F6pEYczcRzLaZbLhAcs+VKQmsRJKnprvCuT9TH/XBBj7uQMAZRJV9j?=
 =?us-ascii?Q?sJFCGRpCwdPLdtxhXh6C9mbBU51s1dI+6QtArPNrQyOgHKqyCgmGr4tyilmn?=
 =?us-ascii?Q?pJJ5R+WTBeR5fl0UufvD9sP9hn57YlxMl4XU4kb7CLUTa1ulPgRbXX4ea2wu?=
 =?us-ascii?Q?y+4Rul40MfcgVTAzJAi5sBn8moBA5nS0sRh2t2tM4skyyWO633mtaN+xFubk?=
 =?us-ascii?Q?ixk2dARC8J7w/v75w89IbViZFfOk1FQEr2u7ywifuRbAKgw4JmVIDgdHmUDy?=
 =?us-ascii?Q?eHUV2xvsSlYTwV+T0CFLcRjiR8Kh6EqPqXiFBJzFEs3UTr5O/vF/casoT4Vt?=
 =?us-ascii?Q?x3kAFX+OT5TwaYGvD7QKZl2EsOZ91PT0jT2HXqvI25khIUh96dDO1/6PY80G?=
 =?us-ascii?Q?nR6gZy3sGno5o9syX5BwchaEnhdhV+dI4ROkXN4Iofh7pdtdDl1ew1+acCKt?=
 =?us-ascii?Q?JpLkMkYVPUB+NZbBblI+ok/seAgbAxN3OFg/4wd3vLxMPBgOWzl7nUNCEJp4?=
 =?us-ascii?Q?ogZ5gxFJ0IJKa3WCnebDPnOluU4Bz8i+7mDA2o5+uv7UF+ITIRWBtecMf9Zo?=
 =?us-ascii?Q?vDLlhiKXuVr/mZSaDl0VWh++AIwZry514OIkENbR9RfWsdLj5ge+lY4IQiIF?=
 =?us-ascii?Q?IaBKqaG2fDxxYY3rR6wEDW0+lrxOHzl5GPktLBPbMnJQ4oYZ3rpcX+QBlfhx?=
 =?us-ascii?Q?sCkMoY9Rc2Olm1l4uyId1bs+kuIAjuw1gJLvyjpUfwhE0IdOUVZEXvIMoIS1?=
 =?us-ascii?Q?briJM/9ovEuF5ObjCSxDOjSHw/2nbENPmR+lxvc418rNDgv4HQzYIyakmmNp?=
 =?us-ascii?Q?FMys0smo+9zpd3B5mlekeI1Uu6cJYtZzHUROjT19HNAt6iR+cr5wihHWQwoL?=
 =?us-ascii?Q?bvcUtIs456FUxw8wYuGear8tdiw87qTB8b88+DxnWVC4KWzXTvYr2R3atAuY?=
 =?us-ascii?Q?3NRwhUrYQpxIHuUVD1lFI+oc1TCX2zExHnTI0Yo3iiovMhcrRMyxt5ZjSOE+?=
 =?us-ascii?Q?6J4ztJ06NbLOtUhzNOen59bLJZkz0Dxrku8bWsMQWkN4x+2CChc9pl/Yg/cX?=
 =?us-ascii?Q?oSoQsHf4XgWl6fId9CxipW4jfyugljDUJgw98NPIRHS1QP7TN0i1lMWKgsri?=
 =?us-ascii?Q?uZv+1fxG8UtLije8ksa9jFC5mOINCmD1fsoHku3u6Ppmx3K6t/2ClpVXltBN?=
 =?us-ascii?Q?Bk15IqB5tVlHvbuktoRBJ4NruwbivhevM6b1gulQBMm5LPZZHnj7cWr3tIvZ?=
 =?us-ascii?Q?zUbD6s2DBXTG0g4aAM5r/AF4m0WgDcZPsSzjQY/Qm2Ib8pMRp3WsgrGNg7FW?=
 =?us-ascii?Q?mTwia+toECPNKcPfMRYISStJHpLG2splad9/PcR0sahV+1ncQRC/61w0Ill+?=
 =?us-ascii?Q?Gh7ro8FrM2L5yGM8cTNNYBmQeJJQsLdT/YQXOFiGSlx0O3MEoA+IHNvIva5d?=
 =?us-ascii?Q?bFw+kD4jNfRdYdwvrudV1J/pFNX0j7NkCOmxrphKUim6QeRL6aut/qTSTsgV?=
 =?us-ascii?Q?7o53chlBxF5fnoJEe+Qi4nfCKnYMGV3ldkSMLdPCysyfdiT9t09FtZ0d+JFu?=
 =?us-ascii?Q?y+aur2rwvHociiuzR72YLZ9l2Bb77ldjG3O+iNxoV/NrfuQhDrio1zrzOkdv?=
 =?us-ascii?Q?mLlkqTER4E0jftAxVVmSjPF2vJ4j+4ZX9aLrrzFWVkhCmHwtyyMeJy+wiG8M?=
 =?us-ascii?Q?RMqGhXJUwlsVfAbZqXwAOADkp6PRcLDA1xnBjKXazLZmT0TrLctofkKOt2Kl?=
 =?us-ascii?Q?yZlZ77zhw8gYqC08SsOGCy7eY+InuGY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7102d372-55c8-45d6-ab88-08da33f35866
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4209.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 08:42:28.0789
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fhcm9rDDR4smXg2hEKew1g8Kf/I71sH2OPVz0rMkcikuC1LJn3qREge80SDDg2sbMwK7YC+dUNVbqvcLL3PLbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5811
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11 May 09:24, Jakub Kicinski wrote:
>On Tue, 10 May 2022 19:53:01 -0700 Kees Cook wrote:
>> As we continue to narrow the scope of what the FORTIFY memcpy() will
>> accept and build alternative APIs that give the compiler appropriate
>> visibility into more complex memcpy scenarios, there is a need for
>> "unfortified" memcpy use in rare cases where combinations of compiler
>> behaviors, source code layout, etc, result in cases where the stricter
>> memcpy checks need to be bypassed until appropriate solutions can be
>> developed (i.e. fix compiler bugs, code refactoring, new API, etc). The
>> intention is for this to be used only if there's no other reasonable
>> solution, for its use to include a justification that can be used
>> to assess future solutions, and for it to be temporary.
>>
>> Example usage included, based on analysis and discussion from:
>> https://lore.kernel.org/netdev/CANn89iLS_2cshtuXPyNUGDPaic=sJiYfvTb_wNLgWrZRyBxZ_g@mail.gmail.com
>
>Saeed, ack for taking this in directly? Or do you prefer to take this
>plus Eric's last BIG TCP patch via your tree?

Please take both, I asked Eric a question on the BIG TCP patch, but I
won't block the series.

Thanks!