Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 13 May 2022 16:42:30 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        Max Staudt <max@enpas.org>
Subject: Re: [PATCH 0/2] can: drop tx skb if the device is in listen only mode
Message-ID: <20220513144230.upuirv4ufebxvfbq@pengutronix.de>
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gqifvyadwdcbjat7"
Content-Disposition: inline
In-Reply-To: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--gqifvyadwdcbjat7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 13.05.2022 23:23:53, Vincent Mailhol wrote:
> In listen only mode, tx CAN frames can still reach the driver if
> injected via the packet socket. This series add a check toward
> CAN_CTRLMODE_LISTENONLY in can_dropped_invalid_skb() to discard such
> skb. The first patch does some preparation work and migrates
> can_dropped_invalid_skb() from skb.h to dev.h. The second and last
> patch is the actual change.

Thanks for your quick patch!

What about moving the function to a .c file? The
can_dropped_invalid_skb() grew a lot over the years, since it was added
to the header as a static inline function.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--gqifvyadwdcbjat7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJ+blQACgkQrX5LkNig
012Bigf+OBMnCULTQxKU9B8Mkb6CCPhadQ7XNbJ+RbQVPcOSTdDHr1dK3PslcrGE
dBtCKgNBXwKAPNyv6Xkv7WgcDcXXlHbik92UexT3q3dm8By1DtymBQ3SoK+jZ6Aa
CANx8blpS7Pv+GFqS3gl4F/1s9/Uoq6k5oLEhp/ZCbfSuJD9VaQxgMzDFWWU0SRC
eWoB790kCRAS7SqPUyfuPM1NCrvCSMKVoU0slhCiz2GS78sTWzxVJ4x05K5GqUTt
yd0+zimmi/LFZ75ou2UqWtzbXtxav/35+N3lOotJMLCDkddyYHd15dOB0T2qULPk
rCDvBHYOsHzQqXHssnoBmkFoYC55pQ==
=PMY2
-----END PGP SIGNATURE-----

--gqifvyadwdcbjat7--