Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f80cefa2-e238-9939-5f48-9d84bcc248f3@suse.de>
Date:   Fri, 13 May 2022 23:20:57 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH] bcache: fix wrong BITMASK offset value for
 BDEV_CACHE_MODE
Content-Language: en-US
To:     Lin Feng <linf@wangsu.com>
Cc:     axboe@kernel.dk, linux-kernel@vger.kernel.org,
        linux-bcache@vger.kernel.org
References: <20210720103246.112027-1-linf@wangsu.com>
From:   Coly Li <colyli@suse.de>
In-Reply-To: <20210720103246.112027-1-linf@wangsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/20/21 6:32 PM, Lin Feng wrote:
> Original codes:
> BITMASK(CACHE_SYNC,			struct cache_sb, flags, 0, 1);
> BITMASK(CACHE_DISCARD,			struct cache_sb, flags, 1, 1);
> BITMASK(CACHE_REPLACEMENT,		struct cache_sb, flags, 2, 3);
> ...
> BITMASK(BDEV_CACHE_MODE,		struct cache_sb, flags, 0, 4);
>
> Should BDEV_CACHE_MODE bits start from bit-nr 5(2+3) else it overlaps
> with previous defined bit chunks, since we have 4 types of cache modes,
> BDEV_CACHE_MODE will overwrite CACHE_SYNC and CACHE_DISCARD bits.

The overlap won't happen, previous lines are for cache device, and what 
you modified is for backing device.

And your patch changes the on-disk format, which is unacceptable anyway.


Coly Li

>
> This bug stays there since first upstream version of bcache, don't know
> why it lives so long, or am i missing something, please point me out
> if I'm wrong, thanks!
>
> Signed-off-by: Lin Feng <linf@wangsu.com>
> ---
>   include/uapi/linux/bcache.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/bcache.h b/include/uapi/linux/bcache.h
> index cf7399f03b71..dccd89756451 100644
> --- a/include/uapi/linux/bcache.h
> +++ b/include/uapi/linux/bcache.h
> @@ -288,7 +288,7 @@ BITMASK(CACHE_REPLACEMENT,		struct cache_sb, flags, 2, 3);
>   #define CACHE_REPLACEMENT_FIFO		1U
>   #define CACHE_REPLACEMENT_RANDOM	2U
>   
> -BITMASK(BDEV_CACHE_MODE,		struct cache_sb, flags, 0, 4);
> +BITMASK(BDEV_CACHE_MODE,		struct cache_sb, flags, 5, 4);
>   #define CACHE_MODE_WRITETHROUGH		0U
>   #define CACHE_MODE_WRITEBACK		1U
>   #define CACHE_MODE_WRITEAROUND		2U