Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1011125iob; Fri, 13 May 2022 19:32:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOP9VPVLhO8A+PAPGBbqF5ydm1SaVMxTP365V28D8C95Aaa3GWV7ylYNzplfI5d9u01fVn X-Received: by 2002:adf:f747:0:b0:20a:d30a:5f08 with SMTP id z7-20020adff747000000b0020ad30a5f08mr6058364wrp.278.1652495540145; Fri, 13 May 2022 19:32:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652495540; cv=none; d=google.com; s=arc-20160816; b=jupPS5RKsx/QKD5ortNru3vQVDvS6wYD+PNrkCfL7Z5u7YyJj83EctWwoeQykp0PCX 7ObfZNfChfh5kPnAEOYeMCiGf/HG/B6o26M2MJXp6Q/8XDdj5VRNb//ci5m0ousb1IOv oEaJzC96o5q1wKS4KnWGb159hmJFgrqE09OSRtMbK8zAsDPE1JqQa7xz18iHkc/jpfSs +zRwN0MroLDYB2Z6llEFPDCQu97heW0AOfZM2rwmB3TyCeUvi0EBlfoAo/XHCTl5KKNR /eIMRMoIXz7GJbBJOOfhNYk4ZUxbFXInXlkmcgJPUmUzy3SnTKyoScvGMxUgRYQtfUEW ltjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=Sq1AbldVJdGX8VHRbG8hsLSmaekJShcxjNp6/+wc9jKQm5zmesWhD9/Qp5bNqiCt69 0g2wi+F0hjmnwQ5eqjkJV7JsNTf9OpqfIs35TsJINsnHmRlgYRy7txsPuwbXheBVqEqH 3n8Nd3LoWMqZXdNYAGAmtdR7KET2Faavr3CIhos0tAiIyBZOSCeQhiOYVR4bMe5WViMl lKOxU2zZ30FNdPWjkwV1VhE/bXDOJez/mzBDbvuSCSbeUSJLh8MSuU6aMI3pPJi4M1kA tYNtgxlR9HM0zvSauKA9cODelADiU4zjMHXm0Vkxa5mhzWwdLUO5Xh6cR04Yk1dAToYx lK6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZjNEr+S9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id e7-20020a5d5947000000b0020a878263f9si3387506wri.457.2022.05.13.19.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 19:32:20 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZjNEr+S9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 419464E3940; Fri, 13 May 2022 17:45:26 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350581AbiELGza (ORCPT + 99 others); Thu, 12 May 2022 02:55:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238889AbiELGz0 (ORCPT ); Thu, 12 May 2022 02:55:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E21EE227837 for ; Wed, 11 May 2022 23:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652338522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=ZjNEr+S9uMezBanGXquw8oH2+rmygi6bWJ5XnCe7RZCgW+3fPe9E8meLbTDU4UIM8DP0uQ t1hZEAjd0YgrUsnsGTSoN46XXSKUwrvV9JutkIAuMpmD8hA2QnFidXNBdOPcSaRckZNAj0 JUdGWKwsUyTWDFkevejhohgGRXqFtdU= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-DnAkOJXKMr270pJdMo7Xdw-1; Thu, 12 May 2022 02:55:21 -0400 X-MC-Unique: DnAkOJXKMr270pJdMo7Xdw-1 Received: by mail-pg1-f199.google.com with SMTP id f7-20020a6547c7000000b003c600995546so2186402pgs.5 for ; Wed, 11 May 2022 23:55:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=U2RGmQbxOomS+aMJV0nzJrmUB7PrdbXufq6ZenMsMSTkVFczDe3oCx0sDphvHKnI4b ghgYtk7E7GL/Fukgi6UwIGvxNQcZ8j6b7xhtyW0M4f3oi6Fym3uMKXfjNHnnQvFkhzg5 UXRbua1pU3wuBlMgDypXaAXP3XE8h5vOz0kUggQAdjJaMqj8cdwi+utUaCSWVQvbRgYN jux9zbgR2i+eKvTs23obCW77do/hrSdKS/113N14DXwp2IdokXeN9x3h9v6g7S4TZDa+ YayHayK80q8U1JuVSr7EPdINUq4wOvJhI7hkbDBp6wXmsRETwPOmxxjW52UOQx15xLa7 zBhA== X-Gm-Message-State: AOAM530ypSwPCDn8Z7tgmHXCpNzUDcTsVRmVuaHnVH+TrDE1SSqijLhM oI1iQ3I6gvP789ddjv8HuIKX0TWttwpaEq7TJXMrF3EHzLZGnqINyuHbQ++NCzDYuY5mFtkz/AA flRDX33vY/2ujytCFDpHqAAUw X-Received: by 2002:a63:80c6:0:b0:3c2:88f0:9035 with SMTP id j189-20020a6380c6000000b003c288f09035mr24278687pgd.606.1652338520732; Wed, 11 May 2022 23:55:20 -0700 (PDT) X-Received: by 2002:a63:80c6:0:b0:3c2:88f0:9035 with SMTP id j189-20020a6380c6000000b003c288f09035mr24278669pgd.606.1652338520467; Wed, 11 May 2022 23:55:20 -0700 (PDT) Received: from localhost ([240e:3a1:2e9:efa0:e73c:e550:ac9e:58fd]) by smtp.gmail.com with ESMTPSA id l12-20020a170902d34c00b0015e8d4eb296sm3022491plk.224.2022.05.11.23.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 23:55:20 -0700 (PDT) Date: Thu, 12 May 2022 14:54:09 +0800 From: Coiby Xu To: Baoquan He Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Michal Suchanek , Dave Young , Will Deacon , "Eric W . Biederman" , Mimi Zohar , Chun-Yi Lee , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v7 2/4] kexec, KEYS: make the code in bzImage64_verify_sig generic Message-ID: <20220512065409.xxegsttgwfh63fsv@Rk> References: <20220512023402.9913-1-coxu@redhat.com> <20220512023402.9913-3-coxu@redhat.com> <20220512043310.v3e22423ybe4z65e@Rk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 02:22:57PM +0800, Baoquan He wrote: >On 05/12/22 at 12:33pm, Coiby Xu wrote: [...] >> > Just to make clear , is this patch fixing an issue, or it's just an >> > preparation for later patch's use? >> > >> > Or I should ask in another way, any problem is solved with this patch? >> >> At least it doesn't fix an issue that satisfy the criteria listed in >> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >Then it should not be CC-ed to stable. OK, I'll drop "CC:" in next version. > >> >> > >> > >> > > > Reviewed-by: Michal Suchanek >> > > > Signed-off-by: Coiby Xu >> > > > --- >> > > >> > > You can put the note here, it won't be added to commit log when merged. >> > > Maybe it can be removed when merged. >> >> Thanks for the suggestion! Shall I send a version to fix this problem or >> can I just bother the maintainer to remove it? > >Better send a clean one, it will save maintainer's time, they can pick >it directly. Thanks for the confirmation! I'll simply delete them because, 1. these notes don't make sense anymore if I don't CC the patches to the stable tree 2. I've explained in the cover letter the first two patches are the prerequisite patches for the 3rd patch. -- Best regards, Coiby